diff options
author | Peter Griffin <peter.griffin@linaro.org> | 2017-08-15 10:14:25 -0400 |
---|---|---|
committer | Xinliang Liu <xinliang.liu@linaro.org> | 2017-10-31 22:36:50 -0400 |
commit | a2f042430784d86eb2b7a6d2a869f552da30edba (patch) | |
tree | eb3234e3a085d7ce5f3b15766c3c1c993b8ba1ff | |
parent | 62884cd386b876638720ef88374b31a84ca7ee5f (diff) |
drm/hisilicon: Ensure LDI regs are properly configured.
This patch fixes the following soft lockup:
BUG: soft lockup - CPU#0 stuck for 23s! [weston:307]
On weston idle-timeout the IP is powered down and reset
asserted. On weston resume we get a massive vblank
IRQ storm due to the LDI registers having lost some state.
This state loss is caused by ade_crtc_atomic_begin() not
calling ade_ldi_set_mode(). With this patch applied
resuming from Weston idle-timeout works well.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Cc: stable@vger.kernel.org
Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
-rw-r--r-- | drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c index 9823477b1855..2269be91f3e1 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | |||
@@ -534,9 +534,12 @@ static void ade_crtc_atomic_begin(struct drm_crtc *crtc, | |||
534 | { | 534 | { |
535 | struct ade_crtc *acrtc = to_ade_crtc(crtc); | 535 | struct ade_crtc *acrtc = to_ade_crtc(crtc); |
536 | struct ade_hw_ctx *ctx = acrtc->ctx; | 536 | struct ade_hw_ctx *ctx = acrtc->ctx; |
537 | struct drm_display_mode *mode = &crtc->state->mode; | ||
538 | struct drm_display_mode *adj_mode = &crtc->state->adjusted_mode; | ||
537 | 539 | ||
538 | if (!ctx->power_on) | 540 | if (!ctx->power_on) |
539 | (void)ade_power_up(ctx); | 541 | (void)ade_power_up(ctx); |
542 | ade_ldi_set_mode(acrtc, mode, adj_mode); | ||
540 | } | 543 | } |
541 | 544 | ||
542 | static void ade_crtc_atomic_flush(struct drm_crtc *crtc, | 545 | static void ade_crtc_atomic_flush(struct drm_crtc *crtc, |