aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-06-01 05:55:37 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-06-12 19:58:33 -0400
commita14ef24b07b63669d58c16d836ddbadcce3e7ad0 (patch)
treea9f2d35e6f48f9d75b02cfe1718666fba98dce17
parentfc368ea1ea00c9418d6f2c25cd4c0869f1a16d5f (diff)
w1: fix for loop exit condition in w1_seq_show()
The W1_42_FINISHED_BYTE is 0xFF so the cast means the condition is never true. Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/w1/slaves/w1_therm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c
index d21e6864b06f..3351be667957 100644
--- a/drivers/w1/slaves/w1_therm.c
+++ b/drivers/w1/slaves/w1_therm.c
@@ -378,7 +378,7 @@ static ssize_t w1_seq_show(struct device *device,
378 w1_write_8(sl->master, W1_42_COND_READ); 378 w1_write_8(sl->master, W1_42_COND_READ);
379 rv = w1_read_block(sl->master, (u8 *)&rn, 8); 379 rv = w1_read_block(sl->master, (u8 *)&rn, 8);
380 reg_num = (struct w1_reg_num *) &rn; 380 reg_num = (struct w1_reg_num *) &rn;
381 if ((char)reg_num->family == W1_42_FINISHED_BYTE) 381 if (reg_num->family == W1_42_FINISHED_BYTE)
382 break; 382 break;
383 if (sl->reg_num.id == reg_num->id) 383 if (sl->reg_num.id == reg_num->id)
384 seq = i; 384 seq = i;