diff options
| author | Benny Halevy <bhalevy@panasas.com> | 2009-08-14 10:18:44 -0400 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2009-08-14 13:12:38 -0400 |
| commit | 9f162d2a810b4db48f7b8d7e734d0932c81ec2a1 (patch) | |
| tree | 83d0d6274cee3c82fa7485e9a85879172954cc5b | |
| parent | 64f1607ffbbc772685733ea63e6f7f4183df1b16 (diff) | |
sunrpc: hton -> cpu_to_be*
htonl is already defined as cpu_to_be32.
cpu_to_be64 has architecture specific optimized implementations.
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
| -rw-r--r-- | include/linux/sunrpc/xdr.h | 5 | ||||
| -rw-r--r-- | net/sunrpc/xdr.c | 6 |
2 files changed, 5 insertions, 6 deletions
diff --git a/include/linux/sunrpc/xdr.h b/include/linux/sunrpc/xdr.h index b99c625fddfe..f94bbdc75c4b 100644 --- a/include/linux/sunrpc/xdr.h +++ b/include/linux/sunrpc/xdr.h | |||
| @@ -117,9 +117,8 @@ static inline __be32 *xdr_encode_array(__be32 *p, const void *s, unsigned int le | |||
| 117 | static inline __be32 * | 117 | static inline __be32 * |
| 118 | xdr_encode_hyper(__be32 *p, __u64 val) | 118 | xdr_encode_hyper(__be32 *p, __u64 val) |
| 119 | { | 119 | { |
| 120 | *p++ = htonl(val >> 32); | 120 | *(__be64 *)p = cpu_to_be64(val); |
| 121 | *p++ = htonl(val & 0xFFFFFFFF); | 121 | return p + 2; |
| 122 | return p; | ||
| 123 | } | 122 | } |
| 124 | 123 | ||
| 125 | static inline __be32 * | 124 | static inline __be32 * |
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c index 406e26de584e..0d05d2554b42 100644 --- a/net/sunrpc/xdr.c +++ b/net/sunrpc/xdr.c | |||
| @@ -24,7 +24,7 @@ xdr_encode_netobj(__be32 *p, const struct xdr_netobj *obj) | |||
| 24 | unsigned int quadlen = XDR_QUADLEN(obj->len); | 24 | unsigned int quadlen = XDR_QUADLEN(obj->len); |
| 25 | 25 | ||
| 26 | p[quadlen] = 0; /* zero trailing bytes */ | 26 | p[quadlen] = 0; /* zero trailing bytes */ |
| 27 | *p++ = htonl(obj->len); | 27 | *p++ = cpu_to_be32(obj->len); |
| 28 | memcpy(p, obj->data, obj->len); | 28 | memcpy(p, obj->data, obj->len); |
| 29 | return p + XDR_QUADLEN(obj->len); | 29 | return p + XDR_QUADLEN(obj->len); |
| 30 | } | 30 | } |
| @@ -83,7 +83,7 @@ EXPORT_SYMBOL_GPL(xdr_encode_opaque_fixed); | |||
| 83 | */ | 83 | */ |
| 84 | __be32 *xdr_encode_opaque(__be32 *p, const void *ptr, unsigned int nbytes) | 84 | __be32 *xdr_encode_opaque(__be32 *p, const void *ptr, unsigned int nbytes) |
| 85 | { | 85 | { |
| 86 | *p++ = htonl(nbytes); | 86 | *p++ = cpu_to_be32(nbytes); |
| 87 | return xdr_encode_opaque_fixed(p, ptr, nbytes); | 87 | return xdr_encode_opaque_fixed(p, ptr, nbytes); |
| 88 | } | 88 | } |
| 89 | EXPORT_SYMBOL_GPL(xdr_encode_opaque); | 89 | EXPORT_SYMBOL_GPL(xdr_encode_opaque); |
| @@ -779,7 +779,7 @@ EXPORT_SYMBOL_GPL(xdr_decode_word); | |||
| 779 | int | 779 | int |
| 780 | xdr_encode_word(struct xdr_buf *buf, unsigned int base, u32 obj) | 780 | xdr_encode_word(struct xdr_buf *buf, unsigned int base, u32 obj) |
| 781 | { | 781 | { |
| 782 | __be32 raw = htonl(obj); | 782 | __be32 raw = cpu_to_be32(obj); |
| 783 | 783 | ||
| 784 | return write_bytes_to_xdr_buf(buf, base, &raw, sizeof(obj)); | 784 | return write_bytes_to_xdr_buf(buf, base, &raw, sizeof(obj)); |
| 785 | } | 785 | } |
