aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoger Quadros <rogerq@ti.com>2015-08-07 03:38:13 -0400
committerRoger Quadros <rogerq@ti.com>2016-04-15 04:55:28 -0400
commit9e6946215dbd9803e8b511928c9f61f3a49e2c58 (patch)
tree0c5e57d8bc130f40ad75763d4acec4c1ddc41ba5
parentb2bac25a4d298309bb4b2649bb1107ddaa287c47 (diff)
memory: omap-gpmc: Prevent GPMC_STATUS from being accessed via gpmc_regs
GPMC_STATUS register is private to the GPMC module and must not be accessed directly by NAND driver through the gpmc_regs. They must use gpmc_omap_get_nand_ops() instead. Signed-off-by: Roger Quadros <rogerq@ti.com> Acked-by: Tony Lindgren <tony@atomide.com>
-rw-r--r--drivers/memory/omap-gpmc.c2
-rw-r--r--include/linux/platform_data/mtd-nand-omap2.h3
2 files changed, 3 insertions, 2 deletions
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index ea9c89747950..33d69b1e4c31 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -1081,7 +1081,7 @@ void gpmc_update_nand_reg(struct gpmc_nand_regs *reg, int cs)
1081{ 1081{
1082 int i; 1082 int i;
1083 1083
1084 reg->gpmc_status = gpmc_base + GPMC_STATUS; 1084 reg->gpmc_status = NULL; /* deprecated */
1085 reg->gpmc_nand_command = gpmc_base + GPMC_CS0_OFFSET + 1085 reg->gpmc_nand_command = gpmc_base + GPMC_CS0_OFFSET +
1086 GPMC_CS_NAND_COMMAND + GPMC_CS_SIZE * cs; 1086 GPMC_CS_NAND_COMMAND + GPMC_CS_SIZE * cs;
1087 reg->gpmc_nand_address = gpmc_base + GPMC_CS0_OFFSET + 1087 reg->gpmc_nand_address = gpmc_base + GPMC_CS0_OFFSET +
diff --git a/include/linux/platform_data/mtd-nand-omap2.h b/include/linux/platform_data/mtd-nand-omap2.h
index ff27e5a77e03..7f6de5377f80 100644
--- a/include/linux/platform_data/mtd-nand-omap2.h
+++ b/include/linux/platform_data/mtd-nand-omap2.h
@@ -45,7 +45,6 @@ enum omap_ecc {
45}; 45};
46 46
47struct gpmc_nand_regs { 47struct gpmc_nand_regs {
48 void __iomem *gpmc_status;
49 void __iomem *gpmc_nand_command; 48 void __iomem *gpmc_nand_command;
50 void __iomem *gpmc_nand_address; 49 void __iomem *gpmc_nand_address;
51 void __iomem *gpmc_nand_data; 50 void __iomem *gpmc_nand_data;
@@ -64,6 +63,8 @@ struct gpmc_nand_regs {
64 void __iomem *gpmc_bch_result4[GPMC_BCH_NUM_REMAINDER]; 63 void __iomem *gpmc_bch_result4[GPMC_BCH_NUM_REMAINDER];
65 void __iomem *gpmc_bch_result5[GPMC_BCH_NUM_REMAINDER]; 64 void __iomem *gpmc_bch_result5[GPMC_BCH_NUM_REMAINDER];
66 void __iomem *gpmc_bch_result6[GPMC_BCH_NUM_REMAINDER]; 65 void __iomem *gpmc_bch_result6[GPMC_BCH_NUM_REMAINDER];
66 /* Deprecated. Do not use */
67 void __iomem *gpmc_status;
67}; 68};
68 69
69struct omap_nand_platform_data { 70struct omap_nand_platform_data {