aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.com>2017-10-16 22:46:43 -0400
committerShaohua Li <shli@fb.com>2017-11-02 00:32:19 -0400
commit9e1cc0a54556a6c63dc0cfb7cd7d60d43337bba6 (patch)
treee48763c33d781734678f61706428fc614b53cad0
parentb3143b9a38d5039bcd1f2d1c94039651bfba8043 (diff)
md: use mddev_suspend/resume instead of ->quiesce()
mddev_suspend() is a more general interface than calling ->quiesce() and is so more extensible. A future patch will make use of this. Signed-off-by: NeilBrown <neilb@suse.com> Signed-off-by: Shaohua Li <shli@fb.com>
-rw-r--r--drivers/md/md.c24
1 files changed, 12 insertions, 12 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 68de2a6ee29a..5bd4f18763bd 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -4866,8 +4866,8 @@ suspend_lo_store(struct mddev *mddev, const char *buf, size_t len)
4866 mddev->pers->quiesce(mddev, 2); 4866 mddev->pers->quiesce(mddev, 2);
4867 } else { 4867 } else {
4868 /* Expanding suspended region - need to wait */ 4868 /* Expanding suspended region - need to wait */
4869 mddev->pers->quiesce(mddev, 1); 4869 mddev_suspend(mddev);
4870 mddev->pers->quiesce(mddev, 0); 4870 mddev_resume(mddev);
4871 } 4871 }
4872 err = 0; 4872 err = 0;
4873unlock: 4873unlock:
@@ -4910,8 +4910,8 @@ suspend_hi_store(struct mddev *mddev, const char *buf, size_t len)
4910 mddev->pers->quiesce(mddev, 2); 4910 mddev->pers->quiesce(mddev, 2);
4911 } else { 4911 } else {
4912 /* Expanding suspended region - need to wait */ 4912 /* Expanding suspended region - need to wait */
4913 mddev->pers->quiesce(mddev, 1); 4913 mddev_suspend(mddev);
4914 mddev->pers->quiesce(mddev, 0); 4914 mddev_resume(mddev);
4915 } 4915 }
4916 err = 0; 4916 err = 0;
4917unlock: 4917unlock:
@@ -6642,7 +6642,7 @@ static int set_bitmap_file(struct mddev *mddev, int fd)
6642 struct bitmap *bitmap; 6642 struct bitmap *bitmap;
6643 6643
6644 bitmap = bitmap_create(mddev, -1); 6644 bitmap = bitmap_create(mddev, -1);
6645 mddev->pers->quiesce(mddev, 1); 6645 mddev_suspend(mddev);
6646 if (!IS_ERR(bitmap)) { 6646 if (!IS_ERR(bitmap)) {
6647 mddev->bitmap = bitmap; 6647 mddev->bitmap = bitmap;
6648 err = bitmap_load(mddev); 6648 err = bitmap_load(mddev);
@@ -6652,11 +6652,11 @@ static int set_bitmap_file(struct mddev *mddev, int fd)
6652 bitmap_destroy(mddev); 6652 bitmap_destroy(mddev);
6653 fd = -1; 6653 fd = -1;
6654 } 6654 }
6655 mddev->pers->quiesce(mddev, 0); 6655 mddev_resume(mddev);
6656 } else if (fd < 0) { 6656 } else if (fd < 0) {
6657 mddev->pers->quiesce(mddev, 1); 6657 mddev_suspend(mddev);
6658 bitmap_destroy(mddev); 6658 bitmap_destroy(mddev);
6659 mddev->pers->quiesce(mddev, 0); 6659 mddev_resume(mddev);
6660 } 6660 }
6661 } 6661 }
6662 if (fd < 0) { 6662 if (fd < 0) {
@@ -6942,7 +6942,7 @@ static int update_array_info(struct mddev *mddev, mdu_array_info_t *info)
6942 mddev->bitmap_info.space = 6942 mddev->bitmap_info.space =
6943 mddev->bitmap_info.default_space; 6943 mddev->bitmap_info.default_space;
6944 bitmap = bitmap_create(mddev, -1); 6944 bitmap = bitmap_create(mddev, -1);
6945 mddev->pers->quiesce(mddev, 1); 6945 mddev_suspend(mddev);
6946 if (!IS_ERR(bitmap)) { 6946 if (!IS_ERR(bitmap)) {
6947 mddev->bitmap = bitmap; 6947 mddev->bitmap = bitmap;
6948 rv = bitmap_load(mddev); 6948 rv = bitmap_load(mddev);
@@ -6950,7 +6950,7 @@ static int update_array_info(struct mddev *mddev, mdu_array_info_t *info)
6950 rv = PTR_ERR(bitmap); 6950 rv = PTR_ERR(bitmap);
6951 if (rv) 6951 if (rv)
6952 bitmap_destroy(mddev); 6952 bitmap_destroy(mddev);
6953 mddev->pers->quiesce(mddev, 0); 6953 mddev_resume(mddev);
6954 } else { 6954 } else {
6955 /* remove the bitmap */ 6955 /* remove the bitmap */
6956 if (!mddev->bitmap) { 6956 if (!mddev->bitmap) {
@@ -6973,9 +6973,9 @@ static int update_array_info(struct mddev *mddev, mdu_array_info_t *info)
6973 mddev->bitmap_info.nodes = 0; 6973 mddev->bitmap_info.nodes = 0;
6974 md_cluster_ops->leave(mddev); 6974 md_cluster_ops->leave(mddev);
6975 } 6975 }
6976 mddev->pers->quiesce(mddev, 1); 6976 mddev_suspend(mddev);
6977 bitmap_destroy(mddev); 6977 bitmap_destroy(mddev);
6978 mddev->pers->quiesce(mddev, 0); 6978 mddev_resume(mddev);
6979 mddev->bitmap_info.offset = 0; 6979 mddev->bitmap_info.offset = 0;
6980 } 6980 }
6981 } 6981 }