aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJustin Chen <justinpopo6@gmail.com>2015-09-02 14:00:17 -0400
committerWim Van Sebroeck <wim@iguana.be>2015-10-27 11:49:57 -0400
commit9dd4e173f71d5ac6ea37f7dbf49af6e5cd44f9fb (patch)
treed1927b774e1801b91446b5158252605ba68c9dee
parent7a3629fe999028e09bc96ccb0c9e22e0a9cf2725 (diff)
watchdog: watchdog_dev: Use device tree alias for naming watchdogs
Currently there is no way to easily differentiate multiple watchdog devices. The watchdogs are named by the order they are probed. 1st probed watchdog: /dev/watchdog0 2nd probed watchdog: /dev/watchdog1 ... This change uses the alias of the watchdog device node for the name of the watchdog. aliases { watchdog0 = "/...../...." watchdog3 = "/..../....." watchdog2 = "/..../....." ... } This will translate to... /dev/watchdog0 /dev/watchdog3 /dev/watchdog2 v2 Assign alias number to id in watchdog_core instead of watchdog_dev. If failed to get id, fallback to original ida_simple_get call. Signed-off-by: Justin Chen <justinpopo6@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
-rw-r--r--drivers/watchdog/watchdog_core.c15
1 files changed, 13 insertions, 2 deletions
diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c
index 1a8059455413..873f13972cf4 100644
--- a/drivers/watchdog/watchdog_core.c
+++ b/drivers/watchdog/watchdog_core.c
@@ -139,7 +139,7 @@ EXPORT_SYMBOL_GPL(watchdog_init_timeout);
139 139
140static int __watchdog_register_device(struct watchdog_device *wdd) 140static int __watchdog_register_device(struct watchdog_device *wdd)
141{ 141{
142 int ret, id, devno; 142 int ret, id = -1, devno;
143 143
144 if (wdd == NULL || wdd->info == NULL || wdd->ops == NULL) 144 if (wdd == NULL || wdd->info == NULL || wdd->ops == NULL)
145 return -EINVAL; 145 return -EINVAL;
@@ -157,7 +157,18 @@ static int __watchdog_register_device(struct watchdog_device *wdd)
157 */ 157 */
158 158
159 mutex_init(&wdd->lock); 159 mutex_init(&wdd->lock);
160 id = ida_simple_get(&watchdog_ida, 0, MAX_DOGS, GFP_KERNEL); 160
161 /* Use alias for watchdog id if possible */
162 if (wdd->parent) {
163 ret = of_alias_get_id(wdd->parent->of_node, "watchdog");
164 if (ret >= 0)
165 id = ida_simple_get(&watchdog_ida, ret,
166 ret + 1, GFP_KERNEL);
167 }
168
169 if (id < 0)
170 id = ida_simple_get(&watchdog_ida, 0, MAX_DOGS, GFP_KERNEL);
171
161 if (id < 0) 172 if (id < 0)
162 return id; 173 return id;
163 wdd->id = id; 174 wdd->id = id;