diff options
author | Felipe Balbi <felipe.balbi@linux.intel.com> | 2017-12-12 05:44:40 -0500 |
---|---|---|
committer | Felipe Balbi <felipe.balbi@linux.intel.com> | 2017-12-12 05:48:30 -0500 |
commit | 9dbe416b656bb015fc49fc17961000ffa418838a (patch) | |
tree | 7cffac986c159a5ba91cb36343da5c1eec06aaf1 | |
parent | 54eed78c5c831ba696259f7fa69966d699a173b1 (diff) |
Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"
This reverts commit 7a9618a22aadffb55027d665491adf466bced61a.
Romain Izard recently reported that commit 7a9618a22aad ended up
allowing every legacy gadget driver to statically linked to the
kernel, however that doesn't work, since only one legacy gadget can be
bound to a controller. Because of that, let's revert the original commit
and fix the problem.
Reported-by: Romain Izard <romain.izard.pro@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
-rw-r--r-- | drivers/usb/gadget/Kconfig | 4 | ||||
-rw-r--r-- | drivers/usb/gadget/legacy/Kconfig | 10 |
2 files changed, 2 insertions, 12 deletions
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 0a19a76645ad..31cce7805eb2 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig | |||
@@ -508,8 +508,8 @@ choice | |||
508 | controller, and the relevant drivers for each function declared | 508 | controller, and the relevant drivers for each function declared |
509 | by the device. | 509 | by the device. |
510 | 510 | ||
511 | endchoice | ||
512 | |||
513 | source "drivers/usb/gadget/legacy/Kconfig" | 511 | source "drivers/usb/gadget/legacy/Kconfig" |
514 | 512 | ||
513 | endchoice | ||
514 | |||
515 | endif # USB_GADGET | 515 | endif # USB_GADGET |
diff --git a/drivers/usb/gadget/legacy/Kconfig b/drivers/usb/gadget/legacy/Kconfig index 487568f2c729..784bf86dad4f 100644 --- a/drivers/usb/gadget/legacy/Kconfig +++ b/drivers/usb/gadget/legacy/Kconfig | |||
@@ -13,14 +13,6 @@ | |||
13 | # both kinds of controller can also support "USB On-the-Go" (CONFIG_USB_OTG). | 13 | # both kinds of controller can also support "USB On-the-Go" (CONFIG_USB_OTG). |
14 | # | 14 | # |
15 | 15 | ||
16 | menuconfig USB_GADGET_LEGACY | ||
17 | bool "Legacy USB Gadget Support" | ||
18 | help | ||
19 | Legacy USB gadgets are USB gadgets that do not use the USB gadget | ||
20 | configfs interface. | ||
21 | |||
22 | if USB_GADGET_LEGACY | ||
23 | |||
24 | config USB_ZERO | 16 | config USB_ZERO |
25 | tristate "Gadget Zero (DEVELOPMENT)" | 17 | tristate "Gadget Zero (DEVELOPMENT)" |
26 | select USB_LIBCOMPOSITE | 18 | select USB_LIBCOMPOSITE |
@@ -498,5 +490,3 @@ config USB_G_WEBCAM | |||
498 | 490 | ||
499 | Say "y" to link the driver statically, or "m" to build a | 491 | Say "y" to link the driver statically, or "m" to build a |
500 | dynamically linked module called "g_webcam". | 492 | dynamically linked module called "g_webcam". |
501 | |||
502 | endif | ||