aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLeo (Sunpeng) Li <sunpeng.li@amd.com>2018-08-16 15:44:39 -0400
committerAlex Deucher <alexander.deucher@amd.com>2018-08-21 15:33:59 -0400
commit9d1d02ff36783f954a206dfbf7943b7f2057f58b (patch)
tree1b043c55341c9f6b67d2464d455ad0c843568854
parentdc37a9a08d5760e405ffdd94ec6bbb6efededba6 (diff)
drm/amd/display: Don't build DCN1 when kcov is enabled
DCN1 contains code that utilizes fp math. When CONFIG_KCOV_INSTRUMENT_ALL and CONFIG_KCOV_ENABLE_COMPARISONS are enabled, build errors are found. See this earlier patch for details: https://lists.freedesktop.org/archives/dri-devel/2018-August/186131.html As a short term solution, disable CONFIG_DRM_AMD_DC_DCN1_0 when KCOV_INSTRUMENT_ALL and KCOV_ENABLE_COMPARISONS are enabled. In addition, make it a fully derived config, taking into account CONFIG_X86. Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/display/Kconfig8
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig
index 4c35625eb2c7..ed654a76c76a 100644
--- a/drivers/gpu/drm/amd/display/Kconfig
+++ b/drivers/gpu/drm/amd/display/Kconfig
@@ -4,18 +4,16 @@ menu "Display Engine Configuration"
4config DRM_AMD_DC 4config DRM_AMD_DC
5 bool "AMD DC - Enable new display engine" 5 bool "AMD DC - Enable new display engine"
6 default y 6 default y
7 select DRM_AMD_DC_DCN1_0 if X86 && !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS)
7 help 8 help
8 Choose this option if you want to use the new display engine 9 Choose this option if you want to use the new display engine
9 support for AMDGPU. This adds required support for Vega and 10 support for AMDGPU. This adds required support for Vega and
10 Raven ASICs. 11 Raven ASICs.
11 12
12config DRM_AMD_DC_DCN1_0 13config DRM_AMD_DC_DCN1_0
13 bool "DCN 1.0 Raven family" 14 def_bool n
14 depends on DRM_AMD_DC && X86
15 default y
16 help 15 help
17 Choose this option if you want to have 16 RV family support for display engine
18 RV family for display engine
19 17
20config DEBUG_KERNEL_DC 18config DEBUG_KERNEL_DC
21 bool "Enable kgdb break in DC" 19 bool "Enable kgdb break in DC"