diff options
author | Julien Grall <julien.grall@citrix.com> | 2015-10-13 12:50:11 -0400 |
---|---|---|
committer | David Vrabel <david.vrabel@citrix.com> | 2015-10-23 09:20:46 -0400 |
commit | 9cce2914e2b21339dca12c91dc9f35790366cc4c (patch) | |
tree | f92428952bfd91dd0ff312608080e021e3f05190 | |
parent | d5f985c834fbfdedcb629b009ba272ad50add5ac (diff) |
xen/xenbus: Rename *RING_PAGE* to *RING_GRANT*
Linux may use a different page size than the size of grant. So make
clear that the order is actually in number of grant.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
-rw-r--r-- | drivers/block/xen-blkback/blkback.c | 8 | ||||
-rw-r--r-- | drivers/block/xen-blkback/xenbus.c | 2 | ||||
-rw-r--r-- | drivers/block/xen-blkfront.c | 10 | ||||
-rw-r--r-- | drivers/xen/xenbus/xenbus_client.c | 34 | ||||
-rw-r--r-- | include/xen/xenbus.h | 4 |
5 files changed, 29 insertions, 29 deletions
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 809634ce3b67..f9099940c272 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c | |||
@@ -87,7 +87,7 @@ MODULE_PARM_DESC(max_persistent_grants, | |||
87 | * Maximum order of pages to be used for the shared ring between front and | 87 | * Maximum order of pages to be used for the shared ring between front and |
88 | * backend, 4KB page granularity is used. | 88 | * backend, 4KB page granularity is used. |
89 | */ | 89 | */ |
90 | unsigned int xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER; | 90 | unsigned int xen_blkif_max_ring_order = XENBUS_MAX_RING_GRANT_ORDER; |
91 | module_param_named(max_ring_page_order, xen_blkif_max_ring_order, int, S_IRUGO); | 91 | module_param_named(max_ring_page_order, xen_blkif_max_ring_order, int, S_IRUGO); |
92 | MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used for the shared ring"); | 92 | MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used for the shared ring"); |
93 | /* | 93 | /* |
@@ -1446,10 +1446,10 @@ static int __init xen_blkif_init(void) | |||
1446 | if (!xen_domain()) | 1446 | if (!xen_domain()) |
1447 | return -ENODEV; | 1447 | return -ENODEV; |
1448 | 1448 | ||
1449 | if (xen_blkif_max_ring_order > XENBUS_MAX_RING_PAGE_ORDER) { | 1449 | if (xen_blkif_max_ring_order > XENBUS_MAX_RING_GRANT_ORDER) { |
1450 | pr_info("Invalid max_ring_order (%d), will use default max: %d.\n", | 1450 | pr_info("Invalid max_ring_order (%d), will use default max: %d.\n", |
1451 | xen_blkif_max_ring_order, XENBUS_MAX_RING_PAGE_ORDER); | 1451 | xen_blkif_max_ring_order, XENBUS_MAX_RING_GRANT_ORDER); |
1452 | xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER; | 1452 | xen_blkif_max_ring_order = XENBUS_MAX_RING_GRANT_ORDER; |
1453 | } | 1453 | } |
1454 | 1454 | ||
1455 | rc = xen_blkif_interface_init(); | 1455 | rc = xen_blkif_interface_init(); |
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 01c6b41de4e5..f53cff42f8da 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c | |||
@@ -829,7 +829,7 @@ again: | |||
829 | static int connect_ring(struct backend_info *be) | 829 | static int connect_ring(struct backend_info *be) |
830 | { | 830 | { |
831 | struct xenbus_device *dev = be->dev; | 831 | struct xenbus_device *dev = be->dev; |
832 | unsigned int ring_ref[XENBUS_MAX_RING_PAGES]; | 832 | unsigned int ring_ref[XENBUS_MAX_RING_GRANTS]; |
833 | unsigned int evtchn, nr_grefs, ring_page_order; | 833 | unsigned int evtchn, nr_grefs, ring_page_order; |
834 | unsigned int pers_grants; | 834 | unsigned int pers_grants; |
835 | char protocol[64] = ""; | 835 | char protocol[64] = ""; |
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 057e05da83d1..833955f32430 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c | |||
@@ -111,7 +111,7 @@ MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used for the | |||
111 | __CONST_RING_SIZE(blkif, XEN_PAGE_SIZE * (info)->nr_ring_pages) | 111 | __CONST_RING_SIZE(blkif, XEN_PAGE_SIZE * (info)->nr_ring_pages) |
112 | 112 | ||
113 | #define BLK_MAX_RING_SIZE \ | 113 | #define BLK_MAX_RING_SIZE \ |
114 | __CONST_RING_SIZE(blkif, XEN_PAGE_SIZE * XENBUS_MAX_RING_PAGES) | 114 | __CONST_RING_SIZE(blkif, XEN_PAGE_SIZE * XENBUS_MAX_RING_GRANTS) |
115 | 115 | ||
116 | /* | 116 | /* |
117 | * ring-ref%i i=(-1UL) would take 11 characters + 'ring-ref' is 8, so 19 | 117 | * ring-ref%i i=(-1UL) would take 11 characters + 'ring-ref' is 8, so 19 |
@@ -133,7 +133,7 @@ struct blkfront_info | |||
133 | int vdevice; | 133 | int vdevice; |
134 | blkif_vdev_t handle; | 134 | blkif_vdev_t handle; |
135 | enum blkif_state connected; | 135 | enum blkif_state connected; |
136 | int ring_ref[XENBUS_MAX_RING_PAGES]; | 136 | int ring_ref[XENBUS_MAX_RING_GRANTS]; |
137 | unsigned int nr_ring_pages; | 137 | unsigned int nr_ring_pages; |
138 | struct blkif_front_ring ring; | 138 | struct blkif_front_ring ring; |
139 | unsigned int evtchn, irq; | 139 | unsigned int evtchn, irq; |
@@ -1413,7 +1413,7 @@ static int setup_blkring(struct xenbus_device *dev, | |||
1413 | struct blkif_sring *sring; | 1413 | struct blkif_sring *sring; |
1414 | int err, i; | 1414 | int err, i; |
1415 | unsigned long ring_size = info->nr_ring_pages * XEN_PAGE_SIZE; | 1415 | unsigned long ring_size = info->nr_ring_pages * XEN_PAGE_SIZE; |
1416 | grant_ref_t gref[XENBUS_MAX_RING_PAGES]; | 1416 | grant_ref_t gref[XENBUS_MAX_RING_GRANTS]; |
1417 | 1417 | ||
1418 | for (i = 0; i < info->nr_ring_pages; i++) | 1418 | for (i = 0; i < info->nr_ring_pages; i++) |
1419 | info->ring_ref[i] = GRANT_INVALID_REF; | 1419 | info->ring_ref[i] = GRANT_INVALID_REF; |
@@ -2284,9 +2284,9 @@ static int __init xlblk_init(void) | |||
2284 | if (!xen_domain()) | 2284 | if (!xen_domain()) |
2285 | return -ENODEV; | 2285 | return -ENODEV; |
2286 | 2286 | ||
2287 | if (xen_blkif_max_ring_order > XENBUS_MAX_RING_PAGE_ORDER) { | 2287 | if (xen_blkif_max_ring_order > XENBUS_MAX_RING_GRANT_ORDER) { |
2288 | pr_info("Invalid max_ring_order (%d), will use default max: %d.\n", | 2288 | pr_info("Invalid max_ring_order (%d), will use default max: %d.\n", |
2289 | xen_blkif_max_ring_order, XENBUS_MAX_RING_PAGE_ORDER); | 2289 | xen_blkif_max_ring_order, XENBUS_MAX_RING_GRANT_ORDER); |
2290 | xen_blkif_max_ring_order = 0; | 2290 | xen_blkif_max_ring_order = 0; |
2291 | } | 2291 | } |
2292 | 2292 | ||
diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c index 42abee3bbb27..b77643361853 100644 --- a/drivers/xen/xenbus/xenbus_client.c +++ b/drivers/xen/xenbus/xenbus_client.c | |||
@@ -56,11 +56,11 @@ struct xenbus_map_node { | |||
56 | struct vm_struct *area; | 56 | struct vm_struct *area; |
57 | } pv; | 57 | } pv; |
58 | struct { | 58 | struct { |
59 | struct page *pages[XENBUS_MAX_RING_PAGES]; | 59 | struct page *pages[XENBUS_MAX_RING_GRANTS]; |
60 | void *addr; | 60 | void *addr; |
61 | } hvm; | 61 | } hvm; |
62 | }; | 62 | }; |
63 | grant_handle_t handles[XENBUS_MAX_RING_PAGES]; | 63 | grant_handle_t handles[XENBUS_MAX_RING_GRANTS]; |
64 | unsigned int nr_handles; | 64 | unsigned int nr_handles; |
65 | }; | 65 | }; |
66 | 66 | ||
@@ -479,12 +479,12 @@ static int __xenbus_map_ring(struct xenbus_device *dev, | |||
479 | unsigned int flags, | 479 | unsigned int flags, |
480 | bool *leaked) | 480 | bool *leaked) |
481 | { | 481 | { |
482 | struct gnttab_map_grant_ref map[XENBUS_MAX_RING_PAGES]; | 482 | struct gnttab_map_grant_ref map[XENBUS_MAX_RING_GRANTS]; |
483 | struct gnttab_unmap_grant_ref unmap[XENBUS_MAX_RING_PAGES]; | 483 | struct gnttab_unmap_grant_ref unmap[XENBUS_MAX_RING_GRANTS]; |
484 | int i, j; | 484 | int i, j; |
485 | int err = GNTST_okay; | 485 | int err = GNTST_okay; |
486 | 486 | ||
487 | if (nr_grefs > XENBUS_MAX_RING_PAGES) | 487 | if (nr_grefs > XENBUS_MAX_RING_GRANTS) |
488 | return -EINVAL; | 488 | return -EINVAL; |
489 | 489 | ||
490 | for (i = 0; i < nr_grefs; i++) { | 490 | for (i = 0; i < nr_grefs; i++) { |
@@ -540,15 +540,15 @@ static int xenbus_map_ring_valloc_pv(struct xenbus_device *dev, | |||
540 | { | 540 | { |
541 | struct xenbus_map_node *node; | 541 | struct xenbus_map_node *node; |
542 | struct vm_struct *area; | 542 | struct vm_struct *area; |
543 | pte_t *ptes[XENBUS_MAX_RING_PAGES]; | 543 | pte_t *ptes[XENBUS_MAX_RING_GRANTS]; |
544 | phys_addr_t phys_addrs[XENBUS_MAX_RING_PAGES]; | 544 | phys_addr_t phys_addrs[XENBUS_MAX_RING_GRANTS]; |
545 | int err = GNTST_okay; | 545 | int err = GNTST_okay; |
546 | int i; | 546 | int i; |
547 | bool leaked; | 547 | bool leaked; |
548 | 548 | ||
549 | *vaddr = NULL; | 549 | *vaddr = NULL; |
550 | 550 | ||
551 | if (nr_grefs > XENBUS_MAX_RING_PAGES) | 551 | if (nr_grefs > XENBUS_MAX_RING_GRANTS) |
552 | return -EINVAL; | 552 | return -EINVAL; |
553 | 553 | ||
554 | node = kzalloc(sizeof(*node), GFP_KERNEL); | 554 | node = kzalloc(sizeof(*node), GFP_KERNEL); |
@@ -602,10 +602,10 @@ static int xenbus_map_ring_valloc_hvm(struct xenbus_device *dev, | |||
602 | void *addr; | 602 | void *addr; |
603 | bool leaked = false; | 603 | bool leaked = false; |
604 | /* Why do we need two arrays? See comment of __xenbus_map_ring */ | 604 | /* Why do we need two arrays? See comment of __xenbus_map_ring */ |
605 | phys_addr_t phys_addrs[XENBUS_MAX_RING_PAGES]; | 605 | phys_addr_t phys_addrs[XENBUS_MAX_RING_GRANTS]; |
606 | unsigned long addrs[XENBUS_MAX_RING_PAGES]; | 606 | unsigned long addrs[XENBUS_MAX_RING_GRANTS]; |
607 | 607 | ||
608 | if (nr_grefs > XENBUS_MAX_RING_PAGES) | 608 | if (nr_grefs > XENBUS_MAX_RING_GRANTS) |
609 | return -EINVAL; | 609 | return -EINVAL; |
610 | 610 | ||
611 | *vaddr = NULL; | 611 | *vaddr = NULL; |
@@ -686,10 +686,10 @@ int xenbus_map_ring(struct xenbus_device *dev, grant_ref_t *gnt_refs, | |||
686 | unsigned int nr_grefs, grant_handle_t *handles, | 686 | unsigned int nr_grefs, grant_handle_t *handles, |
687 | unsigned long *vaddrs, bool *leaked) | 687 | unsigned long *vaddrs, bool *leaked) |
688 | { | 688 | { |
689 | phys_addr_t phys_addrs[XENBUS_MAX_RING_PAGES]; | 689 | phys_addr_t phys_addrs[XENBUS_MAX_RING_GRANTS]; |
690 | int i; | 690 | int i; |
691 | 691 | ||
692 | if (nr_grefs > XENBUS_MAX_RING_PAGES) | 692 | if (nr_grefs > XENBUS_MAX_RING_GRANTS) |
693 | return -EINVAL; | 693 | return -EINVAL; |
694 | 694 | ||
695 | for (i = 0; i < nr_grefs; i++) | 695 | for (i = 0; i < nr_grefs; i++) |
@@ -722,7 +722,7 @@ EXPORT_SYMBOL_GPL(xenbus_unmap_ring_vfree); | |||
722 | static int xenbus_unmap_ring_vfree_pv(struct xenbus_device *dev, void *vaddr) | 722 | static int xenbus_unmap_ring_vfree_pv(struct xenbus_device *dev, void *vaddr) |
723 | { | 723 | { |
724 | struct xenbus_map_node *node; | 724 | struct xenbus_map_node *node; |
725 | struct gnttab_unmap_grant_ref unmap[XENBUS_MAX_RING_PAGES]; | 725 | struct gnttab_unmap_grant_ref unmap[XENBUS_MAX_RING_GRANTS]; |
726 | unsigned int level; | 726 | unsigned int level; |
727 | int i; | 727 | int i; |
728 | bool leaked = false; | 728 | bool leaked = false; |
@@ -787,7 +787,7 @@ static int xenbus_unmap_ring_vfree_hvm(struct xenbus_device *dev, void *vaddr) | |||
787 | int rv; | 787 | int rv; |
788 | struct xenbus_map_node *node; | 788 | struct xenbus_map_node *node; |
789 | void *addr; | 789 | void *addr; |
790 | unsigned long addrs[XENBUS_MAX_RING_PAGES]; | 790 | unsigned long addrs[XENBUS_MAX_RING_GRANTS]; |
791 | int i; | 791 | int i; |
792 | 792 | ||
793 | spin_lock(&xenbus_valloc_lock); | 793 | spin_lock(&xenbus_valloc_lock); |
@@ -840,11 +840,11 @@ int xenbus_unmap_ring(struct xenbus_device *dev, | |||
840 | grant_handle_t *handles, unsigned int nr_handles, | 840 | grant_handle_t *handles, unsigned int nr_handles, |
841 | unsigned long *vaddrs) | 841 | unsigned long *vaddrs) |
842 | { | 842 | { |
843 | struct gnttab_unmap_grant_ref unmap[XENBUS_MAX_RING_PAGES]; | 843 | struct gnttab_unmap_grant_ref unmap[XENBUS_MAX_RING_GRANTS]; |
844 | int i; | 844 | int i; |
845 | int err; | 845 | int err; |
846 | 846 | ||
847 | if (nr_handles > XENBUS_MAX_RING_PAGES) | 847 | if (nr_handles > XENBUS_MAX_RING_GRANTS) |
848 | return -EINVAL; | 848 | return -EINVAL; |
849 | 849 | ||
850 | for (i = 0; i < nr_handles; i++) | 850 | for (i = 0; i < nr_handles; i++) |
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h index 289c0b5f08fe..32b944b7cebd 100644 --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h | |||
@@ -46,8 +46,8 @@ | |||
46 | #include <xen/interface/io/xenbus.h> | 46 | #include <xen/interface/io/xenbus.h> |
47 | #include <xen/interface/io/xs_wire.h> | 47 | #include <xen/interface/io/xs_wire.h> |
48 | 48 | ||
49 | #define XENBUS_MAX_RING_PAGE_ORDER 4 | 49 | #define XENBUS_MAX_RING_GRANT_ORDER 4 |
50 | #define XENBUS_MAX_RING_PAGES (1U << XENBUS_MAX_RING_PAGE_ORDER) | 50 | #define XENBUS_MAX_RING_GRANTS (1U << XENBUS_MAX_RING_GRANT_ORDER) |
51 | #define INVALID_GRANT_HANDLE (~0U) | 51 | #define INVALID_GRANT_HANDLE (~0U) |
52 | 52 | ||
53 | /* Register callback to watch this node. */ | 53 | /* Register callback to watch this node. */ |