aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYisheng Xie <xieyisheng1@huawei.com>2018-01-31 19:17:29 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2018-01-31 20:18:37 -0500
commit9bebc09fcf4fb25e36cf86af764c038b92f64057 (patch)
tree816871694b79714786b9fe6e24f1ce55818530fb
parent9ac9322d7cfa35b5381a08c7eaed56eb2297377e (diff)
mm/huge_memory.c: fix comment in __split_huge_pmd_locked
pmd_trans_splitting() was removed after THP refcounting redesign, therefore related comment should be updated. Link: http://lkml.kernel.org/r/1512625745-59451-1-git-send-email-xieyisheng1@huawei.com Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/huge_memory.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 0e7ded98d114..0d3ae51ce4f7 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2205,10 +2205,9 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
2205 * for the same virtual address to be loaded simultaneously. So instead 2205 * for the same virtual address to be loaded simultaneously. So instead
2206 * of doing "pmd_populate(); flush_pmd_tlb_range();" we first mark the 2206 * of doing "pmd_populate(); flush_pmd_tlb_range();" we first mark the
2207 * current pmd notpresent (atomically because here the pmd_trans_huge 2207 * current pmd notpresent (atomically because here the pmd_trans_huge
2208 * and pmd_trans_splitting must remain set at all times on the pmd 2208 * must remain set at all times on the pmd until the split is complete
2209 * until the split is complete for this pmd), then we flush the SMP TLB 2209 * for this pmd), then we flush the SMP TLB and finally we write the
2210 * and finally we write the non-huge version of the pmd entry with 2210 * non-huge version of the pmd entry with pmd_populate.
2211 * pmd_populate.
2212 */ 2211 */
2213 pmdp_invalidate(vma, haddr, pmd); 2212 pmdp_invalidate(vma, haddr, pmd);
2214 pmd_populate(mm, pmd, pgtable); 2213 pmd_populate(mm, pmd, pgtable);