aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBart Van Assche <bart.vanassche@sandisk.com>2016-10-28 20:20:49 -0400
committerJens Axboe <axboe@fb.com>2016-11-02 14:50:19 -0400
commit9b7dd572cc439fa92e120290eb74d0295567c5a0 (patch)
treee6bb3de7badc03785a2f00805424063643a13ff0
parent52d7f1b5c2f33b5d34dc2b6af5175fb6a44999f6 (diff)
blk-mq: Remove blk_mq_cancel_requeue_work()
Since blk_mq_requeue_work() no longer restarts stopped queues canceling requeue work is no longer needed to prevent that a stopped queue would be restarted. Hence remove this function. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Mike Snitzer <snitzer@redhat.com> Cc: Keith Busch <keith.busch@intel.com> Cc: Hannes Reinecke <hare@suse.com> Cc: Johannes Thumshirn <jthumshirn@suse.de> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r--block/blk-mq.c6
-rw-r--r--drivers/md/dm-rq.c2
-rw-r--r--drivers/nvme/host/core.c1
-rw-r--r--include/linux/blk-mq.h1
4 files changed, 0 insertions, 10 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c
index d95034ae64f6..a461823644fb 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -526,12 +526,6 @@ void blk_mq_add_to_requeue_list(struct request *rq, bool at_head)
526} 526}
527EXPORT_SYMBOL(blk_mq_add_to_requeue_list); 527EXPORT_SYMBOL(blk_mq_add_to_requeue_list);
528 528
529void blk_mq_cancel_requeue_work(struct request_queue *q)
530{
531 cancel_delayed_work_sync(&q->requeue_work);
532}
533EXPORT_SYMBOL_GPL(blk_mq_cancel_requeue_work);
534
535void blk_mq_kick_requeue_list(struct request_queue *q) 529void blk_mq_kick_requeue_list(struct request_queue *q)
536{ 530{
537 kblockd_schedule_delayed_work(&q->requeue_work, 0); 531 kblockd_schedule_delayed_work(&q->requeue_work, 0);
diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c
index a9e9e781bb77..060ccc5a4b1c 100644
--- a/drivers/md/dm-rq.c
+++ b/drivers/md/dm-rq.c
@@ -116,8 +116,6 @@ static void dm_mq_stop_queue(struct request_queue *q)
116 queue_flag_set(QUEUE_FLAG_STOPPED, q); 116 queue_flag_set(QUEUE_FLAG_STOPPED, q);
117 spin_unlock_irqrestore(q->queue_lock, flags); 117 spin_unlock_irqrestore(q->queue_lock, flags);
118 118
119 /* Avoid that requeuing could restart the queue. */
120 blk_mq_cancel_requeue_work(q);
121 blk_mq_stop_hw_queues(q); 119 blk_mq_stop_hw_queues(q);
122} 120}
123 121
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 329381a28edf..a764c2aa00a1 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2081,7 +2081,6 @@ void nvme_stop_queues(struct nvme_ctrl *ctrl)
2081 queue_flag_set(QUEUE_FLAG_STOPPED, ns->queue); 2081 queue_flag_set(QUEUE_FLAG_STOPPED, ns->queue);
2082 spin_unlock_irq(ns->queue->queue_lock); 2082 spin_unlock_irq(ns->queue->queue_lock);
2083 2083
2084 blk_mq_cancel_requeue_work(ns->queue);
2085 blk_mq_stop_hw_queues(ns->queue); 2084 blk_mq_stop_hw_queues(ns->queue);
2086 } 2085 }
2087 mutex_unlock(&ctrl->namespaces_mutex); 2086 mutex_unlock(&ctrl->namespaces_mutex);
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index aa930009fcd3..a85a20f80aaa 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -217,7 +217,6 @@ void __blk_mq_end_request(struct request *rq, int error);
217 217
218void blk_mq_requeue_request(struct request *rq); 218void blk_mq_requeue_request(struct request *rq);
219void blk_mq_add_to_requeue_list(struct request *rq, bool at_head); 219void blk_mq_add_to_requeue_list(struct request *rq, bool at_head);
220void blk_mq_cancel_requeue_work(struct request_queue *q);
221void blk_mq_kick_requeue_list(struct request_queue *q); 220void blk_mq_kick_requeue_list(struct request_queue *q);
222void blk_mq_delay_kick_requeue_list(struct request_queue *q, unsigned long msecs); 221void blk_mq_delay_kick_requeue_list(struct request_queue *q, unsigned long msecs);
223void blk_mq_abort_requeue_list(struct request_queue *q); 222void blk_mq_abort_requeue_list(struct request_queue *q);