diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2018-10-30 15:46:25 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-10-30 15:46:25 -0400 |
commit | 9b190ecca11c6ed6e20f35caef5746416d8ee0f0 (patch) | |
tree | 357fa589bb8fd8daeb586697b222506bd1c0eefb | |
parent | 343a9f35409b68b6de66ecd0db90a277aee90ec2 (diff) | |
parent | 56ce68bceeefa38e5b3509bf3d39259138e2d76a (diff) |
Merge tag 'cramfs_fixes' of git://git.linaro.org/people/nicolas.pitre/linux
Pull cramfs fixes from Nicolas Pitre:
"Make the Cramfs code more robust against filesystem corruptions, plus
trivial indentation fixes"
* tag 'cramfs_fixes' of git://git.linaro.org/people/nicolas.pitre/linux:
Cramfs: trivial whitespace fixes
Cramfs: fix abad comparison when wrap-arounds occur
-rw-r--r-- | fs/cramfs/inode.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c index 0c35e62f108d..9352487bd0fc 100644 --- a/fs/cramfs/inode.c +++ b/fs/cramfs/inode.c | |||
@@ -202,7 +202,8 @@ static void *cramfs_blkdev_read(struct super_block *sb, unsigned int offset, | |||
202 | continue; | 202 | continue; |
203 | blk_offset = (blocknr - buffer_blocknr[i]) << PAGE_SHIFT; | 203 | blk_offset = (blocknr - buffer_blocknr[i]) << PAGE_SHIFT; |
204 | blk_offset += offset; | 204 | blk_offset += offset; |
205 | if (blk_offset + len > BUFFER_SIZE) | 205 | if (blk_offset > BUFFER_SIZE || |
206 | blk_offset + len > BUFFER_SIZE) | ||
206 | continue; | 207 | continue; |
207 | return read_buffers[i] + blk_offset; | 208 | return read_buffers[i] + blk_offset; |
208 | } | 209 | } |
@@ -872,8 +873,8 @@ static int cramfs_readpage(struct file *file, struct page *page) | |||
872 | if (unlikely(block_start & CRAMFS_BLK_FLAG_DIRECT_PTR)) { | 873 | if (unlikely(block_start & CRAMFS_BLK_FLAG_DIRECT_PTR)) { |
873 | /* See comments on earlier code. */ | 874 | /* See comments on earlier code. */ |
874 | u32 prev_start = block_start; | 875 | u32 prev_start = block_start; |
875 | block_start = prev_start & ~CRAMFS_BLK_FLAGS; | 876 | block_start = prev_start & ~CRAMFS_BLK_FLAGS; |
876 | block_start <<= CRAMFS_BLK_DIRECT_PTR_SHIFT; | 877 | block_start <<= CRAMFS_BLK_DIRECT_PTR_SHIFT; |
877 | if (prev_start & CRAMFS_BLK_FLAG_UNCOMPRESSED) { | 878 | if (prev_start & CRAMFS_BLK_FLAG_UNCOMPRESSED) { |
878 | block_start += PAGE_SIZE; | 879 | block_start += PAGE_SIZE; |
879 | } else { | 880 | } else { |