diff options
author | Jiri Olsa <jolsa@kernel.org> | 2016-08-17 09:54:58 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-10-21 09:32:00 -0400 |
commit | 9a406eb610e3676611ce3e32d2e6c55ccc7e5d61 (patch) | |
tree | 77cbb290ed8f3aab1e05bbfdbc837e02932cdcab | |
parent | 1a56a42534da8f1d2faf8df99787833ce67e8fdb (diff) |
perf c2c report: Add help windows
Adding help windows to display key/action mappings
for both browsers.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-zni4apopx6a9eyxsosm1ebh1@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-c2c.c | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index 205939527945..4af66835bcb7 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c | |||
@@ -2181,6 +2181,11 @@ static int perf_c2c__browse_cacheline(struct hist_entry *he) | |||
2181 | struct c2c_cacheline_browser *cl_browser; | 2181 | struct c2c_cacheline_browser *cl_browser; |
2182 | struct hist_browser *browser; | 2182 | struct hist_browser *browser; |
2183 | int key = -1; | 2183 | int key = -1; |
2184 | const char help[] = | ||
2185 | " ENTER Togle callchains (if present) \n" | ||
2186 | " n Togle Node details info \n" | ||
2187 | " s Togle full lenght of symbol and source line columns \n" | ||
2188 | " q Return back to cacheline list \n"; | ||
2184 | 2189 | ||
2185 | /* Display compact version first. */ | 2190 | /* Display compact version first. */ |
2186 | c2c.symbol_full = false; | 2191 | c2c.symbol_full = false; |
@@ -2201,7 +2206,7 @@ static int perf_c2c__browse_cacheline(struct hist_entry *he) | |||
2201 | c2c_browser__update_nr_entries(browser); | 2206 | c2c_browser__update_nr_entries(browser); |
2202 | 2207 | ||
2203 | while (1) { | 2208 | while (1) { |
2204 | key = hist_browser__run(browser, "help"); | 2209 | key = hist_browser__run(browser, "? - help"); |
2205 | 2210 | ||
2206 | switch (key) { | 2211 | switch (key) { |
2207 | case 's': | 2212 | case 's': |
@@ -2213,6 +2218,9 @@ static int perf_c2c__browse_cacheline(struct hist_entry *he) | |||
2213 | break; | 2218 | break; |
2214 | case 'q': | 2219 | case 'q': |
2215 | goto out; | 2220 | goto out; |
2221 | case '?': | ||
2222 | ui_browser__help_window(&browser->b, help); | ||
2223 | break; | ||
2216 | default: | 2224 | default: |
2217 | break; | 2225 | break; |
2218 | } | 2226 | } |
@@ -2251,6 +2259,10 @@ static int perf_c2c__hists_browse(struct hists *hists) | |||
2251 | { | 2259 | { |
2252 | struct hist_browser *browser; | 2260 | struct hist_browser *browser; |
2253 | int key = -1; | 2261 | int key = -1; |
2262 | const char help[] = | ||
2263 | " d Display cacheline details \n" | ||
2264 | " ENTER Togle callchains (if present) \n" | ||
2265 | " q Quit \n"; | ||
2254 | 2266 | ||
2255 | browser = perf_c2c_browser__new(hists); | 2267 | browser = perf_c2c_browser__new(hists); |
2256 | if (browser == NULL) | 2268 | if (browser == NULL) |
@@ -2263,7 +2275,7 @@ static int perf_c2c__hists_browse(struct hists *hists) | |||
2263 | c2c_browser__update_nr_entries(browser); | 2275 | c2c_browser__update_nr_entries(browser); |
2264 | 2276 | ||
2265 | while (1) { | 2277 | while (1) { |
2266 | key = hist_browser__run(browser, "help"); | 2278 | key = hist_browser__run(browser, "? - help"); |
2267 | 2279 | ||
2268 | switch (key) { | 2280 | switch (key) { |
2269 | case 'q': | 2281 | case 'q': |
@@ -2271,6 +2283,9 @@ static int perf_c2c__hists_browse(struct hists *hists) | |||
2271 | case 'd': | 2283 | case 'd': |
2272 | perf_c2c__browse_cacheline(browser->he_selection); | 2284 | perf_c2c__browse_cacheline(browser->he_selection); |
2273 | break; | 2285 | break; |
2286 | case '?': | ||
2287 | ui_browser__help_window(&browser->b, help); | ||
2288 | break; | ||
2274 | default: | 2289 | default: |
2275 | break; | 2290 | break; |
2276 | } | 2291 | } |