aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2017-11-15 04:16:47 -0500
committerLuca Coelho <luciano.coelho@intel.com>2017-11-28 09:39:57 -0500
commit9834781cc1ff2e6ce327d9a7ce4901ce30ec7644 (patch)
tree548e3b911ce718acc22001c4d72b232be9a975f3
parent5cd2d8fc6c6bca979ac5dd8ad0e41153f1f982f9 (diff)
iwlwifi: mvm: remove superfluous flush_work()
Since iwl_mvm_start_p2p_roc() is only called from iwl_mvm_roc(), which already flushes the same work item, doing it again in it is superfluous. Remove it and move the comment to the first one. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
-rw-r--r--drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c4
-rw-r--r--drivers/net/wireless/intel/iwlwifi/mvm/time-event.c6
2 files changed, 4 insertions, 6 deletions
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 149d301e5e98..e0226d2315bb 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -3192,6 +3192,10 @@ static int iwl_mvm_roc(struct ieee80211_hw *hw,
3192 IWL_DEBUG_MAC80211(mvm, "enter (%d, %d, %d)\n", channel->hw_value, 3192 IWL_DEBUG_MAC80211(mvm, "enter (%d, %d, %d)\n", channel->hw_value,
3193 duration, type); 3193 duration, type);
3194 3194
3195 /*
3196 * Flush the done work, just in case it's still pending, so that
3197 * the work it does can complete and we can accept new frames.
3198 */
3195 flush_work(&mvm->roc_done_wk); 3199 flush_work(&mvm->roc_done_wk);
3196 3200
3197 mutex_lock(&mvm->mutex); 3201 mutex_lock(&mvm->mutex);
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/time-event.c b/drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
index 4d0314912e94..d3b8cb1e20b6 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
@@ -759,12 +759,6 @@ int iwl_mvm_start_p2p_roc(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
759 return -EBUSY; 759 return -EBUSY;
760 } 760 }
761 761
762 /*
763 * Flush the done work, just in case it's still pending, so that
764 * the work it does can complete and we can accept new frames.
765 */
766 flush_work(&mvm->roc_done_wk);
767
768 time_cmd.action = cpu_to_le32(FW_CTXT_ACTION_ADD); 762 time_cmd.action = cpu_to_le32(FW_CTXT_ACTION_ADD);
769 time_cmd.id_and_color = 763 time_cmd.id_and_color =
770 cpu_to_le32(FW_CMD_ID_AND_COLOR(mvmvif->id, mvmvif->color)); 764 cpu_to_le32(FW_CMD_ID_AND_COLOR(mvmvif->id, mvmvif->color));