diff options
author | Fan Li <fanofcode.li@samsung.com> | 2017-11-07 06:14:24 -0500 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2017-11-09 12:43:09 -0500 |
commit | 974565744955b6154a93c85b77cb94026c85ff5a (patch) | |
tree | fefdedfa4ff3872c5a10affb50ebcd47cba59927 | |
parent | 74986213adaff2ceab81fc0bb29dbb80d05665b3 (diff) |
f2fs: optimize the way of traversing free_nid_bitmap
We call scan_free_nid_bits only when there isn't many
free nids left, it means that marked bits in free_nid_bitmap
are supposed to be few, use find_next_bit_le is more
efficient in such case.
According to my tests, use find_next_bit_le instead of
test_bit_le will cut down the traversal time to one
third of its original.
Signed-off-by: Fan li <fanofcode.li@samsung.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
-rw-r--r-- | fs/f2fs/node.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 97799bd503cc..be6fb809f519 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c | |||
@@ -1955,6 +1955,7 @@ static void scan_free_nid_bits(struct f2fs_sb_info *sbi) | |||
1955 | struct curseg_info *curseg = CURSEG_I(sbi, CURSEG_HOT_DATA); | 1955 | struct curseg_info *curseg = CURSEG_I(sbi, CURSEG_HOT_DATA); |
1956 | struct f2fs_journal *journal = curseg->journal; | 1956 | struct f2fs_journal *journal = curseg->journal; |
1957 | unsigned int i, idx; | 1957 | unsigned int i, idx; |
1958 | nid_t nid; | ||
1958 | 1959 | ||
1959 | down_read(&nm_i->nat_tree_lock); | 1960 | down_read(&nm_i->nat_tree_lock); |
1960 | 1961 | ||
@@ -1964,10 +1965,10 @@ static void scan_free_nid_bits(struct f2fs_sb_info *sbi) | |||
1964 | if (!nm_i->free_nid_count[i]) | 1965 | if (!nm_i->free_nid_count[i]) |
1965 | continue; | 1966 | continue; |
1966 | for (idx = 0; idx < NAT_ENTRY_PER_BLOCK; idx++) { | 1967 | for (idx = 0; idx < NAT_ENTRY_PER_BLOCK; idx++) { |
1967 | nid_t nid; | 1968 | idx = find_next_bit_le(nm_i->free_nid_bitmap[i], |
1968 | 1969 | NAT_ENTRY_PER_BLOCK, idx); | |
1969 | if (!test_bit_le(idx, nm_i->free_nid_bitmap[i])) | 1970 | if (idx >= NAT_ENTRY_PER_BLOCK) |
1970 | continue; | 1971 | break; |
1971 | 1972 | ||
1972 | nid = i * NAT_ENTRY_PER_BLOCK + idx; | 1973 | nid = i * NAT_ENTRY_PER_BLOCK + idx; |
1973 | add_free_nid(sbi, nid, true); | 1974 | add_free_nid(sbi, nid, true); |
@@ -1980,7 +1981,6 @@ out: | |||
1980 | down_read(&curseg->journal_rwsem); | 1981 | down_read(&curseg->journal_rwsem); |
1981 | for (i = 0; i < nats_in_cursum(journal); i++) { | 1982 | for (i = 0; i < nats_in_cursum(journal); i++) { |
1982 | block_t addr; | 1983 | block_t addr; |
1983 | nid_t nid; | ||
1984 | 1984 | ||
1985 | addr = le32_to_cpu(nat_in_journal(journal, i).block_addr); | 1985 | addr = le32_to_cpu(nat_in_journal(journal, i).block_addr); |
1986 | nid = le32_to_cpu(nid_in_journal(journal, i)); | 1986 | nid = le32_to_cpu(nid_in_journal(journal, i)); |