diff options
author | Kevin Hao <haokexin@gmail.com> | 2013-05-25 07:36:26 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2013-05-25 14:01:24 -0400 |
commit | 96ddef25b24a6159e78fb53c1b13336914ff1154 (patch) | |
tree | 5974722e8f6efe01f4b948d570c37e0073e1ff24 | |
parent | 33963e308e98064ce89d961ffeede2fb055f8ffc (diff) |
PCI: Consolidate calls to pcibios_bus_to_resource() in __pci_read_base()
Since we will invoke pcibios_bus_to_resource() unconditionally if we
don't goto fail, move it out of if/else wrap. No function change.
Signed-off-by: Kevin Hao <haokexin@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
-rw-r--r-- | drivers/pci/probe.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index d40cd05bbf64..cd7b6de9376c 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c | |||
@@ -250,12 +250,10 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, | |||
250 | pci_write_config_dword(dev, pos + 4, 0); | 250 | pci_write_config_dword(dev, pos + 4, 0); |
251 | region.start = 0; | 251 | region.start = 0; |
252 | region.end = sz64; | 252 | region.end = sz64; |
253 | pcibios_bus_to_resource(dev, res, ®ion); | ||
254 | bar_disabled = true; | 253 | bar_disabled = true; |
255 | } else { | 254 | } else { |
256 | region.start = l64; | 255 | region.start = l64; |
257 | region.end = l64 + sz64; | 256 | region.end = l64 + sz64; |
258 | pcibios_bus_to_resource(dev, res, ®ion); | ||
259 | } | 257 | } |
260 | } else { | 258 | } else { |
261 | sz = pci_size(l, sz, mask); | 259 | sz = pci_size(l, sz, mask); |
@@ -265,9 +263,10 @@ int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, | |||
265 | 263 | ||
266 | region.start = l; | 264 | region.start = l; |
267 | region.end = l + sz; | 265 | region.end = l + sz; |
268 | pcibios_bus_to_resource(dev, res, ®ion); | ||
269 | } | 266 | } |
270 | 267 | ||
268 | pcibios_bus_to_resource(dev, res, ®ion); | ||
269 | |||
271 | goto out; | 270 | goto out; |
272 | 271 | ||
273 | 272 | ||