diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2018-06-08 09:39:27 -0400 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2018-09-03 09:13:30 -0400 |
commit | 95e472da1094dfe41b7d1d3fb2d04486cf863a42 (patch) | |
tree | cd56c2e2465afa9fe5095a1d20a1eae18828ddd8 | |
parent | 7d39e59be51bddbd5cd487274d48969a39a3bcd1 (diff) |
drm/omap: hdmi: Constify video mode and related pointers
Constify many pointers to struct videomode, as well as pointers to
container structures, to ensure the video mode isn't modified after
the .check_timings() operation.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
-rw-r--r-- | drivers/gpu/drm/omapdrm/dss/hdmi.h | 8 | ||||
-rw-r--r-- | drivers/gpu/drm/omapdrm/dss/hdmi4.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/omapdrm/dss/hdmi5.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/omapdrm/dss/hdmi_wp.c | 8 |
5 files changed, 13 insertions, 13 deletions
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi.h b/drivers/gpu/drm/omapdrm/dss/hdmi.h index 3aeb4cabd59f..7f0dc490a31d 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi.h +++ b/drivers/gpu/drm/omapdrm/dss/hdmi.h | |||
@@ -313,13 +313,13 @@ void hdmi_wp_clear_irqenable(struct hdmi_wp_data *wp, u32 mask); | |||
313 | int hdmi_wp_set_phy_pwr(struct hdmi_wp_data *wp, enum hdmi_phy_pwr val); | 313 | int hdmi_wp_set_phy_pwr(struct hdmi_wp_data *wp, enum hdmi_phy_pwr val); |
314 | int hdmi_wp_set_pll_pwr(struct hdmi_wp_data *wp, enum hdmi_pll_pwr val); | 314 | int hdmi_wp_set_pll_pwr(struct hdmi_wp_data *wp, enum hdmi_pll_pwr val); |
315 | void hdmi_wp_video_config_format(struct hdmi_wp_data *wp, | 315 | void hdmi_wp_video_config_format(struct hdmi_wp_data *wp, |
316 | struct hdmi_video_format *video_fmt); | 316 | const struct hdmi_video_format *video_fmt); |
317 | void hdmi_wp_video_config_interface(struct hdmi_wp_data *wp, | 317 | void hdmi_wp_video_config_interface(struct hdmi_wp_data *wp, |
318 | struct videomode *vm); | 318 | const struct videomode *vm); |
319 | void hdmi_wp_video_config_timing(struct hdmi_wp_data *wp, | 319 | void hdmi_wp_video_config_timing(struct hdmi_wp_data *wp, |
320 | struct videomode *vm); | 320 | const struct videomode *vm); |
321 | void hdmi_wp_init_vid_fmt_timings(struct hdmi_video_format *video_fmt, | 321 | void hdmi_wp_init_vid_fmt_timings(struct hdmi_video_format *video_fmt, |
322 | struct videomode *vm, struct hdmi_config *param); | 322 | struct videomode *vm, const struct hdmi_config *param); |
323 | int hdmi_wp_init(struct platform_device *pdev, struct hdmi_wp_data *wp, | 323 | int hdmi_wp_init(struct platform_device *pdev, struct hdmi_wp_data *wp, |
324 | unsigned int version); | 324 | unsigned int version); |
325 | phys_addr_t hdmi_wp_get_audio_dma_addr(struct hdmi_wp_data *wp); | 325 | phys_addr_t hdmi_wp_get_audio_dma_addr(struct hdmi_wp_data *wp); |
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index 3e2bc85ef538..7ad173098c22 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c | |||
@@ -154,7 +154,7 @@ static void hdmi_power_off_core(struct omap_hdmi *hdmi) | |||
154 | static int hdmi_power_on_full(struct omap_hdmi *hdmi) | 154 | static int hdmi_power_on_full(struct omap_hdmi *hdmi) |
155 | { | 155 | { |
156 | int r; | 156 | int r; |
157 | struct videomode *vm; | 157 | const struct videomode *vm; |
158 | struct hdmi_wp_data *wp = &hdmi->wp; | 158 | struct hdmi_wp_data *wp = &hdmi->wp; |
159 | struct dss_pll_clock_info hdmi_cinfo = { 0 }; | 159 | struct dss_pll_clock_info hdmi_cinfo = { 0 }; |
160 | unsigned int pc; | 160 | unsigned int pc; |
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index c02e08299155..147c3550df51 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c | |||
@@ -153,7 +153,7 @@ static void hdmi_power_off_core(struct omap_hdmi *hdmi) | |||
153 | static int hdmi_power_on_full(struct omap_hdmi *hdmi) | 153 | static int hdmi_power_on_full(struct omap_hdmi *hdmi) |
154 | { | 154 | { |
155 | int r; | 155 | int r; |
156 | struct videomode *vm; | 156 | const struct videomode *vm; |
157 | struct dss_pll_clock_info hdmi_cinfo = { 0 }; | 157 | struct dss_pll_clock_info hdmi_cinfo = { 0 }; |
158 | unsigned int pc; | 158 | unsigned int pc; |
159 | 159 | ||
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c index 2282e48574c6..02efabc7ed76 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | |||
@@ -287,7 +287,7 @@ void hdmi5_core_dump(struct hdmi_core_data *core, struct seq_file *s) | |||
287 | } | 287 | } |
288 | 288 | ||
289 | static void hdmi_core_init(struct hdmi_core_vid_config *video_cfg, | 289 | static void hdmi_core_init(struct hdmi_core_vid_config *video_cfg, |
290 | struct hdmi_config *cfg) | 290 | const struct hdmi_config *cfg) |
291 | { | 291 | { |
292 | DSSDBG("hdmi_core_init\n"); | 292 | DSSDBG("hdmi_core_init\n"); |
293 | 293 | ||
@@ -325,10 +325,10 @@ static void hdmi_core_init(struct hdmi_core_vid_config *video_cfg, | |||
325 | 325 | ||
326 | /* DSS_HDMI_CORE_VIDEO_CONFIG */ | 326 | /* DSS_HDMI_CORE_VIDEO_CONFIG */ |
327 | static void hdmi_core_video_config(struct hdmi_core_data *core, | 327 | static void hdmi_core_video_config(struct hdmi_core_data *core, |
328 | struct hdmi_core_vid_config *cfg) | 328 | const struct hdmi_core_vid_config *cfg) |
329 | { | 329 | { |
330 | void __iomem *base = core->base; | 330 | void __iomem *base = core->base; |
331 | struct videomode *vm = &cfg->v_fc_config.vm; | 331 | const struct videomode *vm = &cfg->v_fc_config.vm; |
332 | unsigned char r = 0; | 332 | unsigned char r = 0; |
333 | bool vsync_pol, hsync_pol; | 333 | bool vsync_pol, hsync_pol; |
334 | 334 | ||
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c b/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c index 53bc5f78050c..100efb9f08c6 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi_wp.c | |||
@@ -131,7 +131,7 @@ void hdmi_wp_video_stop(struct hdmi_wp_data *wp) | |||
131 | } | 131 | } |
132 | 132 | ||
133 | void hdmi_wp_video_config_format(struct hdmi_wp_data *wp, | 133 | void hdmi_wp_video_config_format(struct hdmi_wp_data *wp, |
134 | struct hdmi_video_format *video_fmt) | 134 | const struct hdmi_video_format *video_fmt) |
135 | { | 135 | { |
136 | u32 l = 0; | 136 | u32 l = 0; |
137 | 137 | ||
@@ -144,7 +144,7 @@ void hdmi_wp_video_config_format(struct hdmi_wp_data *wp, | |||
144 | } | 144 | } |
145 | 145 | ||
146 | void hdmi_wp_video_config_interface(struct hdmi_wp_data *wp, | 146 | void hdmi_wp_video_config_interface(struct hdmi_wp_data *wp, |
147 | struct videomode *vm) | 147 | const struct videomode *vm) |
148 | { | 148 | { |
149 | u32 r; | 149 | u32 r; |
150 | bool vsync_inv, hsync_inv; | 150 | bool vsync_inv, hsync_inv; |
@@ -164,7 +164,7 @@ void hdmi_wp_video_config_interface(struct hdmi_wp_data *wp, | |||
164 | } | 164 | } |
165 | 165 | ||
166 | void hdmi_wp_video_config_timing(struct hdmi_wp_data *wp, | 166 | void hdmi_wp_video_config_timing(struct hdmi_wp_data *wp, |
167 | struct videomode *vm) | 167 | const struct videomode *vm) |
168 | { | 168 | { |
169 | u32 timing_h = 0; | 169 | u32 timing_h = 0; |
170 | u32 timing_v = 0; | 170 | u32 timing_v = 0; |
@@ -193,7 +193,7 @@ void hdmi_wp_video_config_timing(struct hdmi_wp_data *wp, | |||
193 | } | 193 | } |
194 | 194 | ||
195 | void hdmi_wp_init_vid_fmt_timings(struct hdmi_video_format *video_fmt, | 195 | void hdmi_wp_init_vid_fmt_timings(struct hdmi_video_format *video_fmt, |
196 | struct videomode *vm, struct hdmi_config *param) | 196 | struct videomode *vm, const struct hdmi_config *param) |
197 | { | 197 | { |
198 | DSSDBG("Enter hdmi_wp_video_init_format\n"); | 198 | DSSDBG("Enter hdmi_wp_video_init_format\n"); |
199 | 199 | ||