diff options
author | Ilya Dryomov <ilya.dryomov@inktank.com> | 2014-07-11 04:11:20 -0400 |
---|---|---|
committer | Ilya Dryomov <ilya.dryomov@inktank.com> | 2014-08-07 08:01:09 -0400 |
commit | 9584d5082653429ea219f9739a08566478b39f16 (patch) | |
tree | 230437ae046c982de7207025ff61e0e0f1c1ea1d | |
parent | 7a716aac01eedb8a7ebf36a0e81237c56f9f1bc1 (diff) |
rbd: remove extra newlines from rbd_warn() messages
rbd_warn() string should be a single line - rbd_warn() appends \n.
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
-rw-r--r-- | drivers/block/rbd.c | 25 |
1 files changed, 12 insertions, 13 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index a5ebcf28e041..623c84145b79 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c | |||
@@ -1370,7 +1370,7 @@ static void obj_request_img_data_set(struct rbd_obj_request *obj_request) | |||
1370 | struct rbd_device *rbd_dev; | 1370 | struct rbd_device *rbd_dev; |
1371 | 1371 | ||
1372 | rbd_dev = obj_request->img_request->rbd_dev; | 1372 | rbd_dev = obj_request->img_request->rbd_dev; |
1373 | rbd_warn(rbd_dev, "obj_request %p already marked img_data\n", | 1373 | rbd_warn(rbd_dev, "obj_request %p already marked img_data", |
1374 | obj_request); | 1374 | obj_request); |
1375 | } | 1375 | } |
1376 | } | 1376 | } |
@@ -1388,7 +1388,7 @@ static void obj_request_done_set(struct rbd_obj_request *obj_request) | |||
1388 | 1388 | ||
1389 | if (obj_request_img_data_test(obj_request)) | 1389 | if (obj_request_img_data_test(obj_request)) |
1390 | rbd_dev = obj_request->img_request->rbd_dev; | 1390 | rbd_dev = obj_request->img_request->rbd_dev; |
1391 | rbd_warn(rbd_dev, "obj_request %p already marked done\n", | 1391 | rbd_warn(rbd_dev, "obj_request %p already marked done", |
1392 | obj_request); | 1392 | obj_request); |
1393 | } | 1393 | } |
1394 | } | 1394 | } |
@@ -1779,7 +1779,7 @@ static void rbd_osd_req_callback(struct ceph_osd_request *osd_req, | |||
1779 | rbd_osd_trivial_callback(obj_request); | 1779 | rbd_osd_trivial_callback(obj_request); |
1780 | break; | 1780 | break; |
1781 | default: | 1781 | default: |
1782 | rbd_warn(NULL, "%s: unsupported op %hu\n", | 1782 | rbd_warn(NULL, "%s: unsupported op %hu", |
1783 | obj_request->object_name, (unsigned short) opcode); | 1783 | obj_request->object_name, (unsigned short) opcode); |
1784 | break; | 1784 | break; |
1785 | } | 1785 | } |
@@ -2014,7 +2014,7 @@ static void rbd_dev_parent_put(struct rbd_device *rbd_dev) | |||
2014 | if (!counter) | 2014 | if (!counter) |
2015 | rbd_dev_unparent(rbd_dev); | 2015 | rbd_dev_unparent(rbd_dev); |
2016 | else | 2016 | else |
2017 | rbd_warn(rbd_dev, "parent reference underflow\n"); | 2017 | rbd_warn(rbd_dev, "parent reference underflow"); |
2018 | } | 2018 | } |
2019 | 2019 | ||
2020 | /* | 2020 | /* |
@@ -2044,7 +2044,7 @@ static bool rbd_dev_parent_get(struct rbd_device *rbd_dev) | |||
2044 | /* Image was flattened, but parent is not yet torn down */ | 2044 | /* Image was flattened, but parent is not yet torn down */ |
2045 | 2045 | ||
2046 | if (counter < 0) | 2046 | if (counter < 0) |
2047 | rbd_warn(rbd_dev, "parent reference overflow\n"); | 2047 | rbd_warn(rbd_dev, "parent reference overflow"); |
2048 | 2048 | ||
2049 | return false; | 2049 | return false; |
2050 | } | 2050 | } |
@@ -2177,11 +2177,11 @@ static bool rbd_img_obj_end_request(struct rbd_obj_request *obj_request) | |||
2177 | if (result) { | 2177 | if (result) { |
2178 | struct rbd_device *rbd_dev = img_request->rbd_dev; | 2178 | struct rbd_device *rbd_dev = img_request->rbd_dev; |
2179 | 2179 | ||
2180 | rbd_warn(rbd_dev, "%s %llx at %llx (%llx)\n", | 2180 | rbd_warn(rbd_dev, "%s %llx at %llx (%llx)", |
2181 | img_request_write_test(img_request) ? "write" : "read", | 2181 | img_request_write_test(img_request) ? "write" : "read", |
2182 | obj_request->length, obj_request->img_offset, | 2182 | obj_request->length, obj_request->img_offset, |
2183 | obj_request->offset); | 2183 | obj_request->offset); |
2184 | rbd_warn(rbd_dev, " result %d xferred %x\n", | 2184 | rbd_warn(rbd_dev, " result %d xferred %x", |
2185 | result, xferred); | 2185 | result, xferred); |
2186 | if (!img_request->result) | 2186 | if (!img_request->result) |
2187 | img_request->result = result; | 2187 | img_request->result = result; |
@@ -2971,11 +2971,11 @@ static void rbd_watch_cb(u64 ver, u64 notify_id, u8 opcode, void *data) | |||
2971 | */ | 2971 | */ |
2972 | ret = rbd_dev_refresh(rbd_dev); | 2972 | ret = rbd_dev_refresh(rbd_dev); |
2973 | if (ret) | 2973 | if (ret) |
2974 | rbd_warn(rbd_dev, "refresh failed: %d\n", ret); | 2974 | rbd_warn(rbd_dev, "refresh failed: %d", ret); |
2975 | 2975 | ||
2976 | ret = rbd_obj_notify_ack_sync(rbd_dev, notify_id); | 2976 | ret = rbd_obj_notify_ack_sync(rbd_dev, notify_id); |
2977 | if (ret) | 2977 | if (ret) |
2978 | rbd_warn(rbd_dev, "notify_ack ret %d\n", ret); | 2978 | rbd_warn(rbd_dev, "notify_ack ret %d", ret); |
2979 | } | 2979 | } |
2980 | 2980 | ||
2981 | /* | 2981 | /* |
@@ -4091,7 +4091,7 @@ static int rbd_dev_v2_parent_info(struct rbd_device *rbd_dev) | |||
4091 | 4091 | ||
4092 | ret = -EIO; | 4092 | ret = -EIO; |
4093 | if (pool_id > (u64)U32_MAX) { | 4093 | if (pool_id > (u64)U32_MAX) { |
4094 | rbd_warn(NULL, "parent pool id too large (%llu > %u)\n", | 4094 | rbd_warn(NULL, "parent pool id too large (%llu > %u)", |
4095 | (unsigned long long)pool_id, U32_MAX); | 4095 | (unsigned long long)pool_id, U32_MAX); |
4096 | goto out_err; | 4096 | goto out_err; |
4097 | } | 4097 | } |
@@ -4144,8 +4144,7 @@ static int rbd_dev_v2_parent_info(struct rbd_device *rbd_dev) | |||
4144 | * overlap is zero we just pretend there was | 4144 | * overlap is zero we just pretend there was |
4145 | * no parent image. | 4145 | * no parent image. |
4146 | */ | 4146 | */ |
4147 | rbd_warn(rbd_dev, "ignoring parent of " | 4147 | rbd_warn(rbd_dev, "ignoring parent with overlap 0"); |
4148 | "clone with overlap 0\n"); | ||
4149 | } | 4148 | } |
4150 | } | 4149 | } |
4151 | out: | 4150 | out: |
@@ -5284,7 +5283,7 @@ static ssize_t do_rbd_add(struct bus_type *bus, | |||
5284 | /* The ceph file layout needs to fit pool id in 32 bits */ | 5283 | /* The ceph file layout needs to fit pool id in 32 bits */ |
5285 | 5284 | ||
5286 | if (spec->pool_id > (u64)U32_MAX) { | 5285 | if (spec->pool_id > (u64)U32_MAX) { |
5287 | rbd_warn(NULL, "pool id too large (%llu > %u)\n", | 5286 | rbd_warn(NULL, "pool id too large (%llu > %u)", |
5288 | (unsigned long long)spec->pool_id, U32_MAX); | 5287 | (unsigned long long)spec->pool_id, U32_MAX); |
5289 | rc = -EIO; | 5288 | rc = -EIO; |
5290 | goto err_out_client; | 5289 | goto err_out_client; |