diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-08-18 11:55:15 -0400 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2012-08-20 04:24:21 -0400 |
| commit | 94f3ec6b2222eb5c0af0c784f0656ff5b909d870 (patch) | |
| tree | d67fe0f941e81a1c47d9b49de144f62aeda5c4ee | |
| parent | 5e68fb3cab23b327e9f15803607e697d7eea1966 (diff) | |
sound: oss/sb_audio: prevent divide by zero bug
Speed comes from get_user() in audio_ioctl(). We use it to set the "s"
variable before clamping it to valid values so it could lead to a divide
by zero bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/oss/sb_audio.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/oss/sb_audio.c b/sound/oss/sb_audio.c index 733b014ec7d1..b2b3c014221a 100644 --- a/sound/oss/sb_audio.c +++ b/sound/oss/sb_audio.c | |||
| @@ -575,13 +575,15 @@ static int jazz16_audio_set_speed(int dev, int speed) | |||
| 575 | if (speed > 0) | 575 | if (speed > 0) |
| 576 | { | 576 | { |
| 577 | int tmp; | 577 | int tmp; |
| 578 | int s = speed * devc->channels; | 578 | int s; |
| 579 | 579 | ||
| 580 | if (speed < 5000) | 580 | if (speed < 5000) |
| 581 | speed = 5000; | 581 | speed = 5000; |
| 582 | if (speed > 44100) | 582 | if (speed > 44100) |
| 583 | speed = 44100; | 583 | speed = 44100; |
| 584 | 584 | ||
| 585 | s = speed * devc->channels; | ||
| 586 | |||
| 585 | devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff; | 587 | devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff; |
| 586 | 588 | ||
| 587 | tmp = 256 - devc->tconst; | 589 | tmp = 256 - devc->tconst; |
