aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWill Deacon <will.deacon@arm.com>2019-02-22 11:56:31 -0500
committerWill Deacon <will.deacon@arm.com>2019-04-08 07:00:56 -0400
commit949b8c72768e3a7c69d270962b8a142ee8deec1b (patch)
tree3619bd740e620872ad16daf782f7986442ab1dd4
parent915530396c788d75c40f200edd67b56ac363c728 (diff)
drivers: Remove useless trailing comments from mmiowb() invocations
In preparation for using coccinelle to remove all mmiowb() instances from drivers, remove all trailing comments since they won't be picked up by spatch later on and will end up being preserved in the code. Acked-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Will Deacon <will.deacon@arm.com>
-rw-r--r--drivers/infiniband/hw/hfi1/chip.c2
-rw-r--r--drivers/infiniband/hw/qedr/verbs.c2
-rw-r--r--drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h2
-rw-r--r--drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c2
-rw-r--r--drivers/scsi/bnx2i/bnx2i_hwi.c2
5 files changed, 5 insertions, 5 deletions
diff --git a/drivers/infiniband/hw/hfi1/chip.c b/drivers/infiniband/hw/hfi1/chip.c
index 612f04190ed8..12e67a91e578 100644
--- a/drivers/infiniband/hw/hfi1/chip.c
+++ b/drivers/infiniband/hw/hfi1/chip.c
@@ -8365,7 +8365,7 @@ static inline void clear_recv_intr(struct hfi1_ctxtdata *rcd)
8365 struct hfi1_devdata *dd = rcd->dd; 8365 struct hfi1_devdata *dd = rcd->dd;
8366 u32 addr = CCE_INT_CLEAR + (8 * rcd->ireg); 8366 u32 addr = CCE_INT_CLEAR + (8 * rcd->ireg);
8367 8367
8368 mmiowb(); /* make sure everything before is written */ 8368 mmiowb();
8369 write_csr(dd, addr, rcd->imask); 8369 write_csr(dd, addr, rcd->imask);
8370 /* force the above write on the chip and get a value back */ 8370 /* force the above write on the chip and get a value back */
8371 (void)read_csr(dd, addr); 8371 (void)read_csr(dd, addr);
diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
index 59ad4202422c..4dab2b5ffb0e 100644
--- a/drivers/infiniband/hw/qedr/verbs.c
+++ b/drivers/infiniband/hw/qedr/verbs.c
@@ -3700,7 +3700,7 @@ int qedr_post_recv(struct ib_qp *ibqp, const struct ib_recv_wr *wr,
3700 3700
3701 if (rdma_protocol_iwarp(&dev->ibdev, 1)) { 3701 if (rdma_protocol_iwarp(&dev->ibdev, 1)) {
3702 writel(qp->rq.iwarp_db2_data.raw, qp->rq.iwarp_db2); 3702 writel(qp->rq.iwarp_db2_data.raw, qp->rq.iwarp_db2);
3703 mmiowb(); /* for second doorbell */ 3703 mmiowb();
3704 } 3704 }
3705 3705
3706 wr = wr->next; 3706 wr = wr->next;
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
index 2462e7aa0c5d..1ed068509337 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
@@ -527,7 +527,7 @@ static inline void bnx2x_update_rx_prod(struct bnx2x *bp,
527 REG_WR_RELAXED(bp, fp->ustorm_rx_prods_offset + i * 4, 527 REG_WR_RELAXED(bp, fp->ustorm_rx_prods_offset + i * 4,
528 ((u32 *)&rx_prods)[i]); 528 ((u32 *)&rx_prods)[i]);
529 529
530 mmiowb(); /* keep prod updates ordered */ 530 mmiowb();
531 531
532 DP(NETIF_MSG_RX_STATUS, 532 DP(NETIF_MSG_RX_STATUS,
533 "queue[%d]: wrote bd_prod %u cqe_prod %u sge_prod %u\n", 533 "queue[%d]: wrote bd_prod %u cqe_prod %u sge_prod %u\n",
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 626b491f7674..e46786a56b0c 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -5244,7 +5244,7 @@ static void bnx2x_update_eq_prod(struct bnx2x *bp, u16 prod)
5244{ 5244{
5245 /* No memory barriers */ 5245 /* No memory barriers */
5246 storm_memset_eq_prod(bp, prod, BP_FUNC(bp)); 5246 storm_memset_eq_prod(bp, prod, BP_FUNC(bp));
5247 mmiowb(); /* keep prod updates ordered */ 5247 mmiowb();
5248} 5248}
5249 5249
5250static int bnx2x_cnic_handle_cfc_del(struct bnx2x *bp, u32 cid, 5250static int bnx2x_cnic_handle_cfc_del(struct bnx2x *bp, u32 cid,
diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index fae6f71e677d..d56a78f411cd 100644
--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
@@ -280,7 +280,7 @@ static void bnx2i_ring_sq_dbell(struct bnx2i_conn *bnx2i_conn, int count)
280 } else 280 } else
281 writew(count, ep->qp.ctx_base + CNIC_SEND_DOORBELL); 281 writew(count, ep->qp.ctx_base + CNIC_SEND_DOORBELL);
282 282
283 mmiowb(); /* flush posted PCI writes */ 283 mmiowb();
284} 284}
285 285
286 286