aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKai-Heng Feng <kai.heng.feng@canonical.com>2018-09-12 02:58:20 -0400
committerDavid S. Miller <davem@davemloft.net>2018-09-17 21:45:55 -0400
commit94235460f9eaefc4f0a3a4a6014fb4c6db4241cc (patch)
treea2a40ef88e7520de71e1b243afe2f0bb71c43d35
parent3275b4df3c39f97ee3fe982c9bafd6f3b7ff0dfe (diff)
r8169: Align ASPM/CLKREQ setting function with vendor driver
There's a small delay after setting ASPM in vendor drivers, r8101 and r8168. In addition, those drivers enable ASPM before ClkReq, also change that to align with vendor driver. I haven't seen anything bad becasue of this, but I think it's better to keep in sync with vendor driver. Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/realtek/r8169.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 1d8631303b53..8195b1f5036d 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -4775,12 +4775,14 @@ static void rtl_pcie_state_l2l3_enable(struct rtl8169_private *tp, bool enable)
4775static void rtl_hw_aspm_clkreq_enable(struct rtl8169_private *tp, bool enable) 4775static void rtl_hw_aspm_clkreq_enable(struct rtl8169_private *tp, bool enable)
4776{ 4776{
4777 if (enable) { 4777 if (enable) {
4778 RTL_W8(tp, Config2, RTL_R8(tp, Config2) | ClkReqEn);
4779 RTL_W8(tp, Config5, RTL_R8(tp, Config5) | ASPM_en); 4778 RTL_W8(tp, Config5, RTL_R8(tp, Config5) | ASPM_en);
4779 RTL_W8(tp, Config2, RTL_R8(tp, Config2) | ClkReqEn);
4780 } else { 4780 } else {
4781 RTL_W8(tp, Config2, RTL_R8(tp, Config2) & ~ClkReqEn); 4781 RTL_W8(tp, Config2, RTL_R8(tp, Config2) & ~ClkReqEn);
4782 RTL_W8(tp, Config5, RTL_R8(tp, Config5) & ~ASPM_en); 4782 RTL_W8(tp, Config5, RTL_R8(tp, Config5) & ~ASPM_en);
4783 } 4783 }
4784
4785 udelay(10);
4784} 4786}
4785 4787
4786static void rtl_hw_start_8168bb(struct rtl8169_private *tp) 4788static void rtl_hw_start_8168bb(struct rtl8169_private *tp)