diff options
author | Dave Airlie <airlied@redhat.com> | 2017-01-22 18:25:53 -0500 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2017-01-22 18:25:53 -0500 |
commit | 932790109f62aa52bdb4bb62aa66653c0b51bc75 (patch) | |
tree | 4bedb54f139d1e74637707eae2b04978a85243bf | |
parent | 2f39258e5744d34db5db27a1272fd41ac9d2397d (diff) | |
parent | af3076e67c31ceb3e314933dd61cb68a1d5120cf (diff) |
Merge tag 'drm-qemu-20170110' of git://git.kraxel.org/linux into drm-fixes
drm-qemu: virtio sparse fix, MAINTAINERS updates.
* tag 'drm-qemu-20170110' of git://git.kraxel.org/linux:
drm: flip cirrus driver status to "obsolete".
drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)
drm/virtio: fix framebuffer sparse warning
-rw-r--r-- | MAINTAINERS | 16 | ||||
-rw-r--r-- | drivers/gpu/drm/cirrus/Kconfig | 9 | ||||
-rw-r--r-- | drivers/gpu/drm/virtio/virtgpu_fb.c | 2 |
3 files changed, 23 insertions, 4 deletions
diff --git a/MAINTAINERS b/MAINTAINERS index 35c9cbfe4f2d..ffbfeffc1ee2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS | |||
@@ -4106,12 +4106,18 @@ F: drivers/gpu/drm/bridge/ | |||
4106 | 4106 | ||
4107 | DRM DRIVER FOR BOCHS VIRTUAL GPU | 4107 | DRM DRIVER FOR BOCHS VIRTUAL GPU |
4108 | M: Gerd Hoffmann <kraxel@redhat.com> | 4108 | M: Gerd Hoffmann <kraxel@redhat.com> |
4109 | S: Odd Fixes | 4109 | L: virtualization@lists.linux-foundation.org |
4110 | T: git git://git.kraxel.org/linux drm-qemu | ||
4111 | S: Maintained | ||
4110 | F: drivers/gpu/drm/bochs/ | 4112 | F: drivers/gpu/drm/bochs/ |
4111 | 4113 | ||
4112 | DRM DRIVER FOR QEMU'S CIRRUS DEVICE | 4114 | DRM DRIVER FOR QEMU'S CIRRUS DEVICE |
4113 | M: Dave Airlie <airlied@redhat.com> | 4115 | M: Dave Airlie <airlied@redhat.com> |
4114 | S: Odd Fixes | 4116 | M: Gerd Hoffmann <kraxel@redhat.com> |
4117 | L: virtualization@lists.linux-foundation.org | ||
4118 | T: git git://git.kraxel.org/linux drm-qemu | ||
4119 | S: Obsolete | ||
4120 | W: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ | ||
4115 | F: drivers/gpu/drm/cirrus/ | 4121 | F: drivers/gpu/drm/cirrus/ |
4116 | 4122 | ||
4117 | RADEON and AMDGPU DRM DRIVERS | 4123 | RADEON and AMDGPU DRM DRIVERS |
@@ -4304,7 +4310,10 @@ F: Documentation/devicetree/bindings/display/renesas,du.txt | |||
4304 | 4310 | ||
4305 | DRM DRIVER FOR QXL VIRTUAL GPU | 4311 | DRM DRIVER FOR QXL VIRTUAL GPU |
4306 | M: Dave Airlie <airlied@redhat.com> | 4312 | M: Dave Airlie <airlied@redhat.com> |
4307 | S: Odd Fixes | 4313 | M: Gerd Hoffmann <kraxel@redhat.com> |
4314 | L: virtualization@lists.linux-foundation.org | ||
4315 | T: git git://git.kraxel.org/linux drm-qemu | ||
4316 | S: Maintained | ||
4308 | F: drivers/gpu/drm/qxl/ | 4317 | F: drivers/gpu/drm/qxl/ |
4309 | F: include/uapi/drm/qxl_drm.h | 4318 | F: include/uapi/drm/qxl_drm.h |
4310 | 4319 | ||
@@ -13085,6 +13094,7 @@ M: David Airlie <airlied@linux.ie> | |||
13085 | M: Gerd Hoffmann <kraxel@redhat.com> | 13094 | M: Gerd Hoffmann <kraxel@redhat.com> |
13086 | L: dri-devel@lists.freedesktop.org | 13095 | L: dri-devel@lists.freedesktop.org |
13087 | L: virtualization@lists.linux-foundation.org | 13096 | L: virtualization@lists.linux-foundation.org |
13097 | T: git git://git.kraxel.org/linux drm-qemu | ||
13088 | S: Maintained | 13098 | S: Maintained |
13089 | F: drivers/gpu/drm/virtio/ | 13099 | F: drivers/gpu/drm/virtio/ |
13090 | F: include/uapi/linux/virtio_gpu.h | 13100 | F: include/uapi/linux/virtio_gpu.h |
diff --git a/drivers/gpu/drm/cirrus/Kconfig b/drivers/gpu/drm/cirrus/Kconfig index 04b3c161dfae..7f4cc6e172ab 100644 --- a/drivers/gpu/drm/cirrus/Kconfig +++ b/drivers/gpu/drm/cirrus/Kconfig | |||
@@ -7,3 +7,12 @@ config DRM_CIRRUS_QEMU | |||
7 | This is a KMS driver for emulated cirrus device in qemu. | 7 | This is a KMS driver for emulated cirrus device in qemu. |
8 | It is *NOT* intended for real cirrus devices. This requires | 8 | It is *NOT* intended for real cirrus devices. This requires |
9 | the modesetting userspace X.org driver. | 9 | the modesetting userspace X.org driver. |
10 | |||
11 | Cirrus is obsolete, the hardware was designed in the 90ies | ||
12 | and can't keep up with todays needs. More background: | ||
13 | https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ | ||
14 | |||
15 | Better alternatives are: | ||
16 | - stdvga (DRM_BOCHS, qemu -vga std, default in qemu 2.2+) | ||
17 | - qxl (DRM_QXL, qemu -vga qxl, works best with spice) | ||
18 | - virtio (DRM_VIRTIO_GPU), qemu -vga virtio) | ||
diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c index dd21f950e129..cde9f3758106 100644 --- a/drivers/gpu/drm/virtio/virtgpu_fb.c +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c | |||
@@ -331,7 +331,7 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper, | |||
331 | info->fbops = &virtio_gpufb_ops; | 331 | info->fbops = &virtio_gpufb_ops; |
332 | info->pixmap.flags = FB_PIXMAP_SYSTEM; | 332 | info->pixmap.flags = FB_PIXMAP_SYSTEM; |
333 | 333 | ||
334 | info->screen_base = obj->vmap; | 334 | info->screen_buffer = obj->vmap; |
335 | info->screen_size = obj->gem_base.size; | 335 | info->screen_size = obj->gem_base.size; |
336 | drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); | 336 | drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); |
337 | drm_fb_helper_fill_var(info, &vfbdev->helper, | 337 | drm_fb_helper_fill_var(info, &vfbdev->helper, |