diff options
author | Olof Johansson <olof@lixom.net> | 2017-06-18 23:32:44 -0400 |
---|---|---|
committer | Olof Johansson <olof@lixom.net> | 2017-06-18 23:32:44 -0400 |
commit | 92042d292d89c79a7c874dc706c2b96b81010cdd (patch) | |
tree | 1c85c259a44c79f42ea6c993ca4c952bd065aad3 | |
parent | b9e44ddbe528217090a8d8c54fc99cc71885949f (diff) | |
parent | 764e4ef0a8871339eeddaf27ccc47aeeea28b974 (diff) |
Merge tag 'omap-for-v4.13/omap1-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into next/soc
A series of omap1 changes for issues found by Coccinelle.
* tag 'omap-for-v4.13/omap1-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap:
ARM: OMAP1: Fix a typo in a comment line
ARM: OMAP1: Delete an error message for a failed memory allocation in omap1_dm_timer_init()
ARM: OMAP1: DMA: Delete an unnecessary return statement in omap1_show_dma_caps()
ARM: OMAP1: DMA: Delete an error message for a failed memory allocation in omap1_system_dma_init()
ARM: OMAP1: DMA: Improve a size determination in omap1_system_dma_init()
Signed-off-by: Olof Johansson <olof@lixom.net>
-rw-r--r-- | arch/arm/mach-omap1/dma.c | 5 | ||||
-rw-r--r-- | arch/arm/mach-omap1/timer.c | 4 |
2 files changed, 2 insertions, 7 deletions
diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c index c821c1d5610e..52d7eda1adec 100644 --- a/arch/arm/mach-omap1/dma.c +++ b/arch/arm/mach-omap1/dma.c | |||
@@ -240,7 +240,6 @@ static void omap1_show_dma_caps(void) | |||
240 | w |= 1 << 3; | 240 | w |= 1 << 3; |
241 | dma_write(w, GSCR, 0); | 241 | dma_write(w, GSCR, 0); |
242 | } | 242 | } |
243 | return; | ||
244 | } | 243 | } |
245 | 244 | ||
246 | static unsigned configure_dma_errata(void) | 245 | static unsigned configure_dma_errata(void) |
@@ -339,10 +338,8 @@ static int __init omap1_system_dma_init(void) | |||
339 | goto exit_iounmap; | 338 | goto exit_iounmap; |
340 | } | 339 | } |
341 | 340 | ||
342 | d = kzalloc(sizeof(struct omap_dma_dev_attr), GFP_KERNEL); | 341 | d = kzalloc(sizeof(*d), GFP_KERNEL); |
343 | if (!d) { | 342 | if (!d) { |
344 | dev_err(&pdev->dev, "%s: Unable to allocate 'd' for %s\n", | ||
345 | __func__, pdev->name); | ||
346 | ret = -ENOMEM; | 343 | ret = -ENOMEM; |
347 | goto exit_iounmap; | 344 | goto exit_iounmap; |
348 | } | 345 | } |
diff --git a/arch/arm/mach-omap1/timer.c b/arch/arm/mach-omap1/timer.c index 06c5ba7574a5..8fb1ec6fa999 100644 --- a/arch/arm/mach-omap1/timer.c +++ b/arch/arm/mach-omap1/timer.c | |||
@@ -3,7 +3,7 @@ | |||
3 | * | 3 | * |
4 | * Contains first level initialization routines which internally | 4 | * Contains first level initialization routines which internally |
5 | * generates timer device information and registers with linux | 5 | * generates timer device information and registers with linux |
6 | * device model. It also has low level function to chnage the timer | 6 | * device model. It also has a low level function to change the timer |
7 | * input clock source. | 7 | * input clock source. |
8 | * | 8 | * |
9 | * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/ | 9 | * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/ |
@@ -134,8 +134,6 @@ static int __init omap1_dm_timer_init(void) | |||
134 | 134 | ||
135 | pdata = kzalloc(sizeof(*pdata), GFP_KERNEL); | 135 | pdata = kzalloc(sizeof(*pdata), GFP_KERNEL); |
136 | if (!pdata) { | 136 | if (!pdata) { |
137 | dev_err(&pdev->dev, "%s: Failed to allocate pdata.\n", | ||
138 | __func__); | ||
139 | ret = -ENOMEM; | 137 | ret = -ENOMEM; |
140 | goto err_free_pdata; | 138 | goto err_free_pdata; |
141 | } | 139 | } |