diff options
author | Dan Williams <dan.j.williams@intel.com> | 2018-10-04 19:32:08 -0400 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2018-10-09 03:04:56 -0400 |
commit | 91ed7ac444ef749603a95629a5ec483988c4f14b (patch) | |
tree | 84101eb63683e8848b25309186a8338bc789f2e9 | |
parent | 55781b66936ee4e15cdd6d591b26662ab9d2d847 (diff) |
libnvdimm, pmem: Fix badblocks population for 'raw' namespaces
The driver is only initializing bb_res in the devm_memremap_pages()
paths, but the raw namespace case is passing an uninitialized bb_res to
nvdimm_badblocks_populate().
Fixes: e8d513483300 ("memremap: change devm_memremap_pages interface...")
Cc: <stable@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Reported-by: Jacek Zloch <jacek.zloch@intel.com>
Reported-by: Krzysztof Rusocki <krzysztof.rusocki@intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r-- | drivers/nvdimm/pmem.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 6071e2942053..2082ae01b9c8 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c | |||
@@ -421,9 +421,11 @@ static int pmem_attach_disk(struct device *dev, | |||
421 | addr = devm_memremap_pages(dev, &pmem->pgmap); | 421 | addr = devm_memremap_pages(dev, &pmem->pgmap); |
422 | pmem->pfn_flags |= PFN_MAP; | 422 | pmem->pfn_flags |= PFN_MAP; |
423 | memcpy(&bb_res, &pmem->pgmap.res, sizeof(bb_res)); | 423 | memcpy(&bb_res, &pmem->pgmap.res, sizeof(bb_res)); |
424 | } else | 424 | } else { |
425 | addr = devm_memremap(dev, pmem->phys_addr, | 425 | addr = devm_memremap(dev, pmem->phys_addr, |
426 | pmem->size, ARCH_MEMREMAP_PMEM); | 426 | pmem->size, ARCH_MEMREMAP_PMEM); |
427 | memcpy(&bb_res, &nsio->res, sizeof(bb_res)); | ||
428 | } | ||
427 | 429 | ||
428 | /* | 430 | /* |
429 | * At release time the queue must be frozen before | 431 | * At release time the queue must be frozen before |