diff options
author | Kalderon, Michal <Michal.Kalderon@cavium.com> | 2017-07-09 06:00:16 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-07-11 16:36:05 -0400 |
commit | 91d1ae475b9833097e078c2581c9265d033cdbe4 (patch) | |
tree | c0c61b10f141dcb8d0332ff61d241e0dbb31c85b | |
parent | 5e34fa23ced16f03fe163d3f31fddcae91c3f2fc (diff) |
qed: Fix printk option passed when printing ipv6 addresses
The option "h" (host order ) exists for ipv4 only.
Remove the h when printing ipv6 addresses.
Lead to the following smatch warning:
drivers/net/ethernet/qlogic/qed/qed_iwarp.c:585 qed_iwarp_print_tcp_ramrod()
warn: '%pI6' can only be followed by c
drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1521 qed_iwarp_print_cm_info()
warn: '%pI6' can only be followed by c
Fixes commit 456a584947d5 ("qed: iWARP CM add passive side connect")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michal Kalderon <Michal.Kalderon@cavium.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c index b251ebaec4db..9d989c96278c 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c | |||
@@ -575,7 +575,7 @@ qed_iwarp_print_tcp_ramrod(struct qed_hwfn *p_hwfn, | |||
575 | 575 | ||
576 | if (p_tcp_ramrod->tcp.ip_version == TCP_IPV4) { | 576 | if (p_tcp_ramrod->tcp.ip_version == TCP_IPV4) { |
577 | DP_VERBOSE(p_hwfn, QED_MSG_RDMA, | 577 | DP_VERBOSE(p_hwfn, QED_MSG_RDMA, |
578 | "local_ip=%pI4h:%x, remote_ip=%pI4h%x, vlan=%x\n", | 578 | "local_ip=%pI4h:%x, remote_ip=%pI4h:%x, vlan=%x\n", |
579 | p_tcp_ramrod->tcp.local_ip, | 579 | p_tcp_ramrod->tcp.local_ip, |
580 | p_tcp_ramrod->tcp.local_port, | 580 | p_tcp_ramrod->tcp.local_port, |
581 | p_tcp_ramrod->tcp.remote_ip, | 581 | p_tcp_ramrod->tcp.remote_ip, |
@@ -583,7 +583,7 @@ qed_iwarp_print_tcp_ramrod(struct qed_hwfn *p_hwfn, | |||
583 | p_tcp_ramrod->tcp.vlan_id); | 583 | p_tcp_ramrod->tcp.vlan_id); |
584 | } else { | 584 | } else { |
585 | DP_VERBOSE(p_hwfn, QED_MSG_RDMA, | 585 | DP_VERBOSE(p_hwfn, QED_MSG_RDMA, |
586 | "local_ip=%pI6h:%x, remote_ip=%pI6h:%x, vlan=%x\n", | 586 | "local_ip=%pI6:%x, remote_ip=%pI6:%x, vlan=%x\n", |
587 | p_tcp_ramrod->tcp.local_ip, | 587 | p_tcp_ramrod->tcp.local_ip, |
588 | p_tcp_ramrod->tcp.local_port, | 588 | p_tcp_ramrod->tcp.local_port, |
589 | p_tcp_ramrod->tcp.remote_ip, | 589 | p_tcp_ramrod->tcp.remote_ip, |
@@ -1519,7 +1519,7 @@ qed_iwarp_print_cm_info(struct qed_hwfn *p_hwfn, | |||
1519 | cm_info->vlan); | 1519 | cm_info->vlan); |
1520 | else | 1520 | else |
1521 | DP_VERBOSE(p_hwfn, QED_MSG_RDMA, | 1521 | DP_VERBOSE(p_hwfn, QED_MSG_RDMA, |
1522 | "remote_ip %pI6h:%x, local_ip %pI6h:%x vlan=%x\n", | 1522 | "remote_ip %pI6:%x, local_ip %pI6:%x vlan=%x\n", |
1523 | cm_info->remote_ip, cm_info->remote_port, | 1523 | cm_info->remote_ip, cm_info->remote_port, |
1524 | cm_info->local_ip, cm_info->local_port, | 1524 | cm_info->local_ip, cm_info->local_port, |
1525 | cm_info->vlan); | 1525 | cm_info->vlan); |