aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>2018-09-21 08:26:28 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-09-28 09:11:08 -0400
commit91b20c5a5be0088f9534483276f86230c3a5872f (patch)
tree3fe1211055bb2a8f39d1be29a8699fa73134ab60
parent201af55da8a3986297d7c3493f839dfc96ffd7db (diff)
Revert "usb: renesas_usbhs: add extcon notifier to set mode for non-otg channel"
This reverts commit 8ada211d0383b72878582bd312b984a9eae62b30. R-Car D3 can use OTG mode in fact. So, the commit doesn't need anymore. In other words, like other R-Car Gen3 SoCs, R-Car D3 can change the mode by using the phy-rcar-gen3-usb2 driver. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/renesas_usbhs/common.c9
-rw-r--r--drivers/usb/renesas_usbhs/common.h1
-rw-r--r--drivers/usb/renesas_usbhs/rcar3.c11
3 files changed, 0 insertions, 21 deletions
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index d6c39ba73190..522cc091a59c 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -677,15 +677,6 @@ static int usbhs_probe(struct platform_device *pdev)
677 break; 677 break;
678 case USBHS_TYPE_RCAR_GEN3_WITH_PLL: 678 case USBHS_TYPE_RCAR_GEN3_WITH_PLL:
679 priv->pfunc = usbhs_rcar3_with_pll_ops; 679 priv->pfunc = usbhs_rcar3_with_pll_ops;
680 if (!IS_ERR_OR_NULL(priv->edev)) {
681 priv->nb.notifier_call = priv->pfunc.notifier;
682 ret = devm_extcon_register_notifier(&pdev->dev,
683 priv->edev,
684 EXTCON_USB_HOST,
685 &priv->nb);
686 if (ret < 0)
687 dev_err(&pdev->dev, "no notifier registered\n");
688 }
689 break; 680 break;
690 case USBHS_TYPE_RZA1: 681 case USBHS_TYPE_RZA1:
691 priv->pfunc = usbhs_rza1_ops; 682 priv->pfunc = usbhs_rza1_ops;
diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h
index 555b3e788c6d..3777af848a35 100644
--- a/drivers/usb/renesas_usbhs/common.h
+++ b/drivers/usb/renesas_usbhs/common.h
@@ -257,7 +257,6 @@ struct usbhs_priv {
257 struct platform_device *pdev; 257 struct platform_device *pdev;
258 258
259 struct extcon_dev *edev; 259 struct extcon_dev *edev;
260 struct notifier_block nb;
261 260
262 spinlock_t lock; 261 spinlock_t lock;
263 262
diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c
index d0ea4ff89622..b9a8453a5e68 100644
--- a/drivers/usb/renesas_usbhs/rcar3.c
+++ b/drivers/usb/renesas_usbhs/rcar3.c
@@ -112,16 +112,6 @@ static int usbhs_rcar3_get_id(struct platform_device *pdev)
112 return USBHS_GADGET; 112 return USBHS_GADGET;
113} 113}
114 114
115static int usbhs_rcar3_notifier(struct notifier_block *nb, unsigned long event,
116 void *data)
117{
118 struct usbhs_priv *priv = container_of(nb, struct usbhs_priv, nb);
119
120 usbhs_rcar3_set_usbsel(priv, !!event);
121
122 return NOTIFY_DONE;
123}
124
125const struct renesas_usbhs_platform_callback usbhs_rcar3_ops = { 115const struct renesas_usbhs_platform_callback usbhs_rcar3_ops = {
126 .power_ctrl = usbhs_rcar3_power_ctrl, 116 .power_ctrl = usbhs_rcar3_power_ctrl,
127 .get_id = usbhs_rcar3_get_id, 117 .get_id = usbhs_rcar3_get_id,
@@ -130,5 +120,4 @@ const struct renesas_usbhs_platform_callback usbhs_rcar3_ops = {
130const struct renesas_usbhs_platform_callback usbhs_rcar3_with_pll_ops = { 120const struct renesas_usbhs_platform_callback usbhs_rcar3_with_pll_ops = {
131 .power_ctrl = usbhs_rcar3_power_and_pll_ctrl, 121 .power_ctrl = usbhs_rcar3_power_and_pll_ctrl,
132 .get_id = usbhs_rcar3_get_id, 122 .get_id = usbhs_rcar3_get_id,
133 .notifier = usbhs_rcar3_notifier,
134}; 123};