diff options
author | Vaishali Thakkar <vthakkar1994@gmail.com> | 2015-07-09 00:55:39 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-07-09 03:19:00 -0400 |
commit | 910be1abbec9cac102fde8ab6dd68a9b410ca441 (patch) | |
tree | 532213d0c28ad9d9a8ef84347c4cc8b8494d030b | |
parent | 71d3c0b49a72fd092b7490b923d1721ceced8170 (diff) |
neterion: s2io: Use module_pci_driver
Use module_pci_driver for drivers whose init and exit functions
only register and unregister, respectively.
A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:
@a@
identifier f, x;
@@
-static f(...) { return pci_register_driver(&x); }
@b depends on a@
identifier e, a.x;
statement S;
@@
-static e(...) {
-pci_unregister_driver(&x);
-DBG_PRINT(INIT_DBG,"S");
- }
@c depends on a && b@
identifier a.f;
declarer name module_init;
@@
-module_init(f);
@d depends on a && b && c@
identifier b.e, a.x;
declarer name module_exit;
declarer name module_pci_driver;
@@
-module_exit(e);
+module_pci_driver(x);
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/neterion/s2io.c | 26 | ||||
-rw-r--r-- | drivers/net/ethernet/neterion/s2io.h | 2 |
2 files changed, 1 insertions, 27 deletions
diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index c28111749e1f..2d1b94274079 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c | |||
@@ -8226,31 +8226,7 @@ static void s2io_rem_nic(struct pci_dev *pdev) | |||
8226 | pci_disable_device(pdev); | 8226 | pci_disable_device(pdev); |
8227 | } | 8227 | } |
8228 | 8228 | ||
8229 | /** | 8229 | module_pci_driver(s2io_driver); |
8230 | * s2io_starter - Entry point for the driver | ||
8231 | * Description: This function is the entry point for the driver. It verifies | ||
8232 | * the module loadable parameters and initializes PCI configuration space. | ||
8233 | */ | ||
8234 | |||
8235 | static int __init s2io_starter(void) | ||
8236 | { | ||
8237 | return pci_register_driver(&s2io_driver); | ||
8238 | } | ||
8239 | |||
8240 | /** | ||
8241 | * s2io_closer - Cleanup routine for the driver | ||
8242 | * Description: This function is the cleanup routine for the driver. It | ||
8243 | * unregisters the driver. | ||
8244 | */ | ||
8245 | |||
8246 | static __exit void s2io_closer(void) | ||
8247 | { | ||
8248 | pci_unregister_driver(&s2io_driver); | ||
8249 | DBG_PRINT(INIT_DBG, "cleanup done\n"); | ||
8250 | } | ||
8251 | |||
8252 | module_init(s2io_starter); | ||
8253 | module_exit(s2io_closer); | ||
8254 | 8230 | ||
8255 | static int check_L2_lro_capable(u8 *buffer, struct iphdr **ip, | 8231 | static int check_L2_lro_capable(u8 *buffer, struct iphdr **ip, |
8256 | struct tcphdr **tcp, struct RxD_t *rxdp, | 8232 | struct tcphdr **tcp, struct RxD_t *rxdp, |
diff --git a/drivers/net/ethernet/neterion/s2io.h b/drivers/net/ethernet/neterion/s2io.h index d89b6ed82c51..6c5997dc8afc 100644 --- a/drivers/net/ethernet/neterion/s2io.h +++ b/drivers/net/ethernet/neterion/s2io.h | |||
@@ -1085,8 +1085,6 @@ static void s2io_txpic_intr_handle(struct s2io_nic *sp); | |||
1085 | static void tx_intr_handler(struct fifo_info *fifo_data); | 1085 | static void tx_intr_handler(struct fifo_info *fifo_data); |
1086 | static void s2io_handle_errors(void * dev_id); | 1086 | static void s2io_handle_errors(void * dev_id); |
1087 | 1087 | ||
1088 | static int s2io_starter(void); | ||
1089 | static void s2io_closer(void); | ||
1090 | static void s2io_tx_watchdog(struct net_device *dev); | 1088 | static void s2io_tx_watchdog(struct net_device *dev); |
1091 | static void s2io_set_multicast(struct net_device *dev); | 1089 | static void s2io_set_multicast(struct net_device *dev); |
1092 | static int rx_osm_handler(struct ring_info *ring_data, struct RxD_t * rxdp); | 1090 | static int rx_osm_handler(struct ring_info *ring_data, struct RxD_t * rxdp); |