aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFlorian Vaussard <florian.vaussard@epfl.ch>2014-02-28 15:42:34 -0500
committerJoerg Roedel <joro@8bytes.org>2014-03-04 11:01:44 -0500
commit90e569c4ca727b59ba8f82a9cd5e2f43462bbc3b (patch)
tree3979ca093ad5a4e95a6a7e57443565ddb669590d
parent7ee08b9ef2e942a5477f02a71947b933eb4101d2 (diff)
iommu/omap: Allow enable/disable even without pdata
When booting with a devicetree, no platform data is provided. Do not prematurely exit iommu_enable() and iommu_disable() in such a case. Note: As OMAP do not yet has a proper reset controller driver, IOMMUs requiring a reset signal should use pdata-quirks as a transitional solution. Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> Signed-off-by: Suman Anna <s-anna@ti.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Joerg Roedel <joro@8bytes.org>
-rw-r--r--drivers/iommu/omap-iommu.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 647e4ba0df95..217952b993e1 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -146,13 +146,10 @@ static int iommu_enable(struct omap_iommu *obj)
146 struct platform_device *pdev = to_platform_device(obj->dev); 146 struct platform_device *pdev = to_platform_device(obj->dev);
147 struct iommu_platform_data *pdata = pdev->dev.platform_data; 147 struct iommu_platform_data *pdata = pdev->dev.platform_data;
148 148
149 if (!pdata)
150 return -EINVAL;
151
152 if (!arch_iommu) 149 if (!arch_iommu)
153 return -ENODEV; 150 return -ENODEV;
154 151
155 if (pdata->deassert_reset) { 152 if (pdata && pdata->deassert_reset) {
156 err = pdata->deassert_reset(pdev, pdata->reset_name); 153 err = pdata->deassert_reset(pdev, pdata->reset_name);
157 if (err) { 154 if (err) {
158 dev_err(obj->dev, "deassert_reset failed: %d\n", err); 155 dev_err(obj->dev, "deassert_reset failed: %d\n", err);
@@ -172,14 +169,11 @@ static void iommu_disable(struct omap_iommu *obj)
172 struct platform_device *pdev = to_platform_device(obj->dev); 169 struct platform_device *pdev = to_platform_device(obj->dev);
173 struct iommu_platform_data *pdata = pdev->dev.platform_data; 170 struct iommu_platform_data *pdata = pdev->dev.platform_data;
174 171
175 if (!pdata)
176 return;
177
178 arch_iommu->disable(obj); 172 arch_iommu->disable(obj);
179 173
180 pm_runtime_put_sync(obj->dev); 174 pm_runtime_put_sync(obj->dev);
181 175
182 if (pdata->assert_reset) 176 if (pdata && pdata->assert_reset)
183 pdata->assert_reset(pdev, pdata->reset_name); 177 pdata->assert_reset(pdev, pdata->reset_name);
184} 178}
185 179