diff options
| author | Enric Balletbo i Serra <enric.balletbo@collabora.com> | 2019-05-08 05:19:55 -0400 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2019-05-14 03:13:28 -0400 |
| commit | 90486af5e0f7334091b94264a84713611933e97e (patch) | |
| tree | 922bc0011aeb7055040e093d8c9fb2649bcfe672 | |
| parent | 93abf68b6bcb50481d84db41e4d7e7e143f24757 (diff) | |
mfd: cros_ec: Instantiate properly CrOS FP MCU device
Support Fingerprint MCU as a special of CrOS EC devices. The current FP
MCU uses the same EC SPI protocol v3 as other CrOS EC devices on a SPI
bus.
When a MCU has fingerprint support (aka EC_FEATURE_FINGERPRINT), it is
instantiated as a special CrOS EC device with device name 'cros_fp'. So
regardless of the probing order between the actual cros_ec and cros_fp,
the userspace and other kernel drivers should not confuse them.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/mfd/cros_ec_dev.c | 10 | ||||
| -rw-r--r-- | include/linux/mfd/cros_ec.h | 1 |
2 files changed, 11 insertions, 0 deletions
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index a3b319913097..71a01a096595 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c | |||
| @@ -419,6 +419,16 @@ static int ec_device_probe(struct platform_device *pdev) | |||
| 419 | device_initialize(&ec->class_dev); | 419 | device_initialize(&ec->class_dev); |
| 420 | cdev_init(&ec->cdev, &fops); | 420 | cdev_init(&ec->cdev, &fops); |
| 421 | 421 | ||
| 422 | /* Check whether this is actually a Fingerprint MCU rather than an EC */ | ||
| 423 | if (cros_ec_check_features(ec, EC_FEATURE_FINGERPRINT)) { | ||
| 424 | dev_info(dev, "CrOS Fingerprint MCU detected.\n"); | ||
| 425 | /* | ||
| 426 | * Help userspace differentiating ECs from FP MCU, | ||
| 427 | * regardless of the probing order. | ||
| 428 | */ | ||
| 429 | ec_platform->ec_name = CROS_EC_DEV_FP_NAME; | ||
| 430 | } | ||
| 431 | |||
| 422 | /* | 432 | /* |
| 423 | * Check whether this is actually an Integrated Sensor Hub (ISH) | 433 | * Check whether this is actually an Integrated Sensor Hub (ISH) |
| 424 | * rather than an EC. | 434 | * rather than an EC. |
diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h index 31c88a0070a3..276079699504 100644 --- a/include/linux/mfd/cros_ec.h +++ b/include/linux/mfd/cros_ec.h | |||
| @@ -23,6 +23,7 @@ | |||
| 23 | #include <linux/mutex.h> | 23 | #include <linux/mutex.h> |
| 24 | 24 | ||
| 25 | #define CROS_EC_DEV_NAME "cros_ec" | 25 | #define CROS_EC_DEV_NAME "cros_ec" |
| 26 | #define CROS_EC_DEV_FP_NAME "cros_fp" | ||
| 26 | #define CROS_EC_DEV_PD_NAME "cros_pd" | 27 | #define CROS_EC_DEV_PD_NAME "cros_pd" |
| 27 | #define CROS_EC_DEV_ISH_NAME "cros_ish" | 28 | #define CROS_EC_DEV_ISH_NAME "cros_ish" |
| 28 | 29 | ||
