aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-10-10 08:30:51 -0400
committerSebastian Reichel <sre@kernel.org>2015-10-15 04:55:44 -0400
commit8e5cfb74bc9c8c12cf91d253b3d27753d54b0d86 (patch)
tree21224dac3ce54d4715dcb3b975940065dedf0908
parent6169588f69f864c39f04e6d65cc620e58822aec5 (diff)
power_supply: charger-manager: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
-rw-r--r--drivers/power/charger-manager.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
index 907293e6f2a4..1ea5d1aa268b 100644
--- a/drivers/power/charger-manager.c
+++ b/drivers/power/charger-manager.c
@@ -1581,8 +1581,10 @@ static struct charger_desc *of_cm_parse_desc(struct device *dev)
1581 cables = devm_kzalloc(dev, sizeof(*cables) 1581 cables = devm_kzalloc(dev, sizeof(*cables)
1582 * chg_regs->num_cables, 1582 * chg_regs->num_cables,
1583 GFP_KERNEL); 1583 GFP_KERNEL);
1584 if (!cables) 1584 if (!cables) {
1585 of_node_put(child);
1585 return ERR_PTR(-ENOMEM); 1586 return ERR_PTR(-ENOMEM);
1587 }
1586 1588
1587 chg_regs->cables = cables; 1589 chg_regs->cables = cables;
1588 1590