diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-07-11 19:11:49 -0400 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2017-08-01 04:04:41 -0400 |
commit | 8db63f5361a80bb91e1c54bccd888060ca07f513 (patch) | |
tree | 8a30fe4f70bff63d5010b88c39ef15b2fde7216c | |
parent | fa8f6d0619fa6775083fff24061e46e7039a8493 (diff) |
pinctrl: stm32: select IRQ_DOMAIN_HIERARCHY instead of depends on
Drivers that need IRQ_DOMAIN_HIERARCHY should "select" it, but
drivers/pinctrl/stm32/Kconfig is the only exception that uses
"depends on" syntax. This prevents GPIO drivers from select'ing
IRQ_DOMAIN_HIERARCHY.
For example, if I add "select IRQ_DOMAIN_HIERARCHY" to GPIO_XGENE_SB,
I get the following recursive dependency error.
drivers/gpio/Kconfig:13:error: recursive dependency detected!
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpio/Kconfig:13: symbol GPIOLIB is selected by PINCTRL_STM32
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/pinctrl/stm32/Kconfig:3: symbol PINCTRL_STM32 is selected by PINCTRL_STM32F429
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/pinctrl/stm32/Kconfig:11: symbol PINCTRL_STM32F429 depends on IRQ_DOMAIN_HIERARCHY
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
kernel/irq/Kconfig:67: symbol IRQ_DOMAIN_HIERARCHY is selected by GPIO_XGENE_SB
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpio/Kconfig:502: symbol GPIO_XGENE_SB depends on GPIOLIB
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Alexandre TORGUE <alexandre.torgue@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r-- | drivers/pinctrl/stm32/Kconfig | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig index 3b8026fca057..7e1fe39a56a5 100644 --- a/drivers/pinctrl/stm32/Kconfig +++ b/drivers/pinctrl/stm32/Kconfig | |||
@@ -6,29 +6,30 @@ config PINCTRL_STM32 | |||
6 | select PINMUX | 6 | select PINMUX |
7 | select GENERIC_PINCONF | 7 | select GENERIC_PINCONF |
8 | select GPIOLIB | 8 | select GPIOLIB |
9 | select IRQ_DOMAIN_HIERARCHY | ||
9 | select MFD_SYSCON | 10 | select MFD_SYSCON |
10 | 11 | ||
11 | config PINCTRL_STM32F429 | 12 | config PINCTRL_STM32F429 |
12 | bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429 | 13 | bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429 |
13 | depends on OF && IRQ_DOMAIN_HIERARCHY | 14 | depends on OF |
14 | default MACH_STM32F429 | 15 | default MACH_STM32F429 |
15 | select PINCTRL_STM32 | 16 | select PINCTRL_STM32 |
16 | 17 | ||
17 | config PINCTRL_STM32F469 | 18 | config PINCTRL_STM32F469 |
18 | bool "STMicroelectronics STM32F469 pin control" if COMPILE_TEST && !MACH_STM32F469 | 19 | bool "STMicroelectronics STM32F469 pin control" if COMPILE_TEST && !MACH_STM32F469 |
19 | depends on OF && IRQ_DOMAIN_HIERARCHY | 20 | depends on OF |
20 | default MACH_STM32F469 | 21 | default MACH_STM32F469 |
21 | select PINCTRL_STM32 | 22 | select PINCTRL_STM32 |
22 | 23 | ||
23 | config PINCTRL_STM32F746 | 24 | config PINCTRL_STM32F746 |
24 | bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746 | 25 | bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746 |
25 | depends on OF && IRQ_DOMAIN_HIERARCHY | 26 | depends on OF |
26 | default MACH_STM32F746 | 27 | default MACH_STM32F746 |
27 | select PINCTRL_STM32 | 28 | select PINCTRL_STM32 |
28 | 29 | ||
29 | config PINCTRL_STM32H743 | 30 | config PINCTRL_STM32H743 |
30 | bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 | 31 | bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743 |
31 | depends on OF && IRQ_DOMAIN_HIERARCHY | 32 | depends on OF |
32 | default MACH_STM32H743 | 33 | default MACH_STM32H743 |
33 | select PINCTRL_STM32 | 34 | select PINCTRL_STM32 |
34 | endif | 35 | endif |