aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2018-07-29 18:04:46 -0400
committerDavid Sterba <dsterba@suse.com>2018-08-06 07:13:02 -0400
commit8d9e220ca0844bf75b98cb5b8e2c25d203c0d0f6 (patch)
treecd43d2412db0f5ee0b34642b11711229bb12f068
parent2e19f1f9d31b3515356710b8bdfb655f47a98448 (diff)
btrfs: simplify IS_ERR/PTR_ERR checks
IS_ERR(p) && PTR_ERR(p) == n is a weird way to spell p == ERR_PTR(n). Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Reviewed-by: David Sterba <dsterba@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> [ update changelog ] Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r--fs/btrfs/transaction.c2
-rw-r--r--fs/btrfs/tree-log.c5
2 files changed, 3 insertions, 4 deletions
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index 001ed1bc2aa8..3b84f5015029 100644
--- a/fs/btrfs/transaction.c
+++ b/fs/btrfs/transaction.c
@@ -680,7 +680,7 @@ btrfs_attach_transaction_barrier(struct btrfs_root *root)
680 680
681 trans = start_transaction(root, 0, TRANS_ATTACH, 681 trans = start_transaction(root, 0, TRANS_ATTACH,
682 BTRFS_RESERVE_NO_FLUSH, true); 682 BTRFS_RESERVE_NO_FLUSH, true);
683 if (IS_ERR(trans) && PTR_ERR(trans) == -ENOENT) 683 if (trans == ERR_PTR(-ENOENT))
684 btrfs_wait_for_commit(root->fs_info, 0); 684 btrfs_wait_for_commit(root->fs_info, 0);
685 685
686 return trans; 686 return trans;
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 730b97dee955..1650dc44a5e3 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -2181,7 +2181,7 @@ again:
2181 dir_key->offset, 2181 dir_key->offset,
2182 name, name_len, 0); 2182 name, name_len, 0);
2183 } 2183 }
2184 if (!log_di || (IS_ERR(log_di) && PTR_ERR(log_di) == -ENOENT)) { 2184 if (!log_di || log_di == ERR_PTR(-ENOENT)) {
2185 btrfs_dir_item_key_to_cpu(eb, di, &location); 2185 btrfs_dir_item_key_to_cpu(eb, di, &location);
2186 btrfs_release_path(path); 2186 btrfs_release_path(path);
2187 btrfs_release_path(log_path); 2187 btrfs_release_path(log_path);
@@ -5011,8 +5011,7 @@ again:
5011 * we don't need to do more work nor fallback to 5011 * we don't need to do more work nor fallback to
5012 * a transaction commit. 5012 * a transaction commit.
5013 */ 5013 */
5014 if (IS_ERR(other_inode) && 5014 if (other_inode == ERR_PTR(-ENOENT)) {
5015 PTR_ERR(other_inode) == -ENOENT) {
5016 goto next_key; 5015 goto next_key;
5017 } else if (IS_ERR(other_inode)) { 5016 } else if (IS_ERR(other_inode)) {
5018 err = PTR_ERR(other_inode); 5017 err = PTR_ERR(other_inode);