diff options
author | Toshi Kani <toshi.kani@hpe.com> | 2016-10-19 10:19:44 -0400 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2016-10-19 11:53:26 -0400 |
commit | 8d7c22ac0c036978a072b7e13c607b5402c474e0 (patch) | |
tree | b50717d21aa2beffb83beadde1b2c232c41e17c9 | |
parent | 1001354ca34179f3db924eb66672442a173147dc (diff) |
libnvdimm: use generic iostat interfaces
nd_iostat_start() and nd_iostat_end() implement the same functionality
that generic_start_io_acct() and generic_end_io_acct() already provide.
Change nd_iostat_start() and nd_iostat_end() to call the generic iostat
interfaces. There is no change in the nd interfaces.
Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r-- | drivers/nvdimm/core.c | 29 | ||||
-rw-r--r-- | drivers/nvdimm/nd.h | 11 |
2 files changed, 9 insertions, 31 deletions
diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c index 7ceba08774b6..9303cfeb8bee 100644 --- a/drivers/nvdimm/core.c +++ b/drivers/nvdimm/core.c | |||
@@ -317,35 +317,6 @@ ssize_t nd_sector_size_store(struct device *dev, const char *buf, | |||
317 | } | 317 | } |
318 | } | 318 | } |
319 | 319 | ||
320 | void __nd_iostat_start(struct bio *bio, unsigned long *start) | ||
321 | { | ||
322 | struct gendisk *disk = bio->bi_bdev->bd_disk; | ||
323 | const int rw = bio_data_dir(bio); | ||
324 | int cpu = part_stat_lock(); | ||
325 | |||
326 | *start = jiffies; | ||
327 | part_round_stats(cpu, &disk->part0); | ||
328 | part_stat_inc(cpu, &disk->part0, ios[rw]); | ||
329 | part_stat_add(cpu, &disk->part0, sectors[rw], bio_sectors(bio)); | ||
330 | part_inc_in_flight(&disk->part0, rw); | ||
331 | part_stat_unlock(); | ||
332 | } | ||
333 | EXPORT_SYMBOL(__nd_iostat_start); | ||
334 | |||
335 | void nd_iostat_end(struct bio *bio, unsigned long start) | ||
336 | { | ||
337 | struct gendisk *disk = bio->bi_bdev->bd_disk; | ||
338 | unsigned long duration = jiffies - start; | ||
339 | const int rw = bio_data_dir(bio); | ||
340 | int cpu = part_stat_lock(); | ||
341 | |||
342 | part_stat_add(cpu, &disk->part0, ticks[rw], duration); | ||
343 | part_round_stats(cpu, &disk->part0); | ||
344 | part_dec_in_flight(&disk->part0, rw); | ||
345 | part_stat_unlock(); | ||
346 | } | ||
347 | EXPORT_SYMBOL(nd_iostat_end); | ||
348 | |||
349 | static ssize_t commands_show(struct device *dev, | 320 | static ssize_t commands_show(struct device *dev, |
350 | struct device_attribute *attr, char *buf) | 321 | struct device_attribute *attr, char *buf) |
351 | { | 322 | { |
diff --git a/drivers/nvdimm/nd.h b/drivers/nvdimm/nd.h index d3b2fca8deec..065abf1b8f32 100644 --- a/drivers/nvdimm/nd.h +++ b/drivers/nvdimm/nd.h | |||
@@ -377,10 +377,17 @@ static inline bool nd_iostat_start(struct bio *bio, unsigned long *start) | |||
377 | if (!blk_queue_io_stat(disk->queue)) | 377 | if (!blk_queue_io_stat(disk->queue)) |
378 | return false; | 378 | return false; |
379 | 379 | ||
380 | __nd_iostat_start(bio, start); | 380 | *start = jiffies; |
381 | generic_start_io_acct(bio_data_dir(bio), | ||
382 | bio_sectors(bio), &disk->part0); | ||
381 | return true; | 383 | return true; |
382 | } | 384 | } |
383 | void nd_iostat_end(struct bio *bio, unsigned long start); | 385 | static inline void nd_iostat_end(struct bio *bio, unsigned long start) |
386 | { | ||
387 | struct gendisk *disk = bio->bi_bdev->bd_disk; | ||
388 | |||
389 | generic_end_io_acct(bio_data_dir(bio), &disk->part0, start); | ||
390 | } | ||
384 | static inline bool is_bad_pmem(struct badblocks *bb, sector_t sector, | 391 | static inline bool is_bad_pmem(struct badblocks *bb, sector_t sector, |
385 | unsigned int len) | 392 | unsigned int len) |
386 | { | 393 | { |