diff options
author | Vitaly Kuznetsov <vkuznets@redhat.com> | 2015-06-24 10:02:06 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2015-06-24 17:48:44 -0400 |
commit | 8c506608c3b2eac939fa244bcdea5faa31818f95 (patch) | |
tree | 1fa7751072f64fb495333f73d363416d20a8aef7 | |
parent | ffa64eff956a25548cad0391dbc14c672827be7b (diff) |
PM / hibernate: re-enable nonboot cpus on disable_nonboot_cpus() failure
When disable_nonboot_cpus() fails on some cpu it doesn't bring back all
cpus it managed to offline, a consequent call to enable_nonboot_cpus() is
expected. In hibernation_platform_enter() we don't call
enable_nonboot_cpus() on error so cpus stay offlined.
create_image() and resume_target_kernel() functions handle
disable_nonboot_cpus() faults correctly, hibernation_platform_enter()
is the only one which is doing it wrong.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r-- | kernel/power/hibernate.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index 2329daae5255..690f78f210f2 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c | |||
@@ -552,7 +552,7 @@ int hibernation_platform_enter(void) | |||
552 | 552 | ||
553 | error = disable_nonboot_cpus(); | 553 | error = disable_nonboot_cpus(); |
554 | if (error) | 554 | if (error) |
555 | goto Platform_finish; | 555 | goto Enable_cpus; |
556 | 556 | ||
557 | local_irq_disable(); | 557 | local_irq_disable(); |
558 | syscore_suspend(); | 558 | syscore_suspend(); |
@@ -568,6 +568,8 @@ int hibernation_platform_enter(void) | |||
568 | Power_up: | 568 | Power_up: |
569 | syscore_resume(); | 569 | syscore_resume(); |
570 | local_irq_enable(); | 570 | local_irq_enable(); |
571 | |||
572 | Enable_cpus: | ||
571 | enable_nonboot_cpus(); | 573 | enable_nonboot_cpus(); |
572 | 574 | ||
573 | Platform_finish: | 575 | Platform_finish: |