aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPankaj Gupta <pagupta@redhat.com>2019-07-12 01:16:10 -0400
committerDan Williams <dan.j.williams@intel.com>2019-07-16 22:44:26 -0400
commit8c2e408e73f735d2e6e8b43f9b038c9abb082939 (patch)
tree838c0205bd26f1f17fbae2b9b4e7b5d07057c4db
parentb21fec414095d966789581c1466fb2f55de33bfe (diff)
virtio_pmem: fix sparse warning
This patch fixes below sparse warning related to __virtio type in virtio pmem driver. This is reported by Intel test bot on linux-next tree. nd_virtio.c:56:28: warning: incorrect type in assignment (different base types) nd_virtio.c:56:28: expected unsigned int [unsigned] [usertype] type nd_virtio.c:56:28: got restricted __virtio32 nd_virtio.c:93:59: warning: incorrect type in argument 2 (different base types) nd_virtio.c:93:59: expected restricted __virtio32 [usertype] val nd_virtio.c:93:59: got unsigned int [unsigned] [usertype] ret Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Pankaj Gupta <pagupta@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
-rw-r--r--drivers/nvdimm/nd_virtio.c4
-rw-r--r--include/uapi/linux/virtio_pmem.h4
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
index 8645275c08c2..10351d5b49fa 100644
--- a/drivers/nvdimm/nd_virtio.c
+++ b/drivers/nvdimm/nd_virtio.c
@@ -53,7 +53,7 @@ static int virtio_pmem_flush(struct nd_region *nd_region)
53 init_waitqueue_head(&req_data->host_acked); 53 init_waitqueue_head(&req_data->host_acked);
54 init_waitqueue_head(&req_data->wq_buf); 54 init_waitqueue_head(&req_data->wq_buf);
55 INIT_LIST_HEAD(&req_data->list); 55 INIT_LIST_HEAD(&req_data->list);
56 req_data->req.type = cpu_to_virtio32(vdev, VIRTIO_PMEM_REQ_TYPE_FLUSH); 56 req_data->req.type = cpu_to_le32(VIRTIO_PMEM_REQ_TYPE_FLUSH);
57 sg_init_one(&sg, &req_data->req, sizeof(req_data->req)); 57 sg_init_one(&sg, &req_data->req, sizeof(req_data->req));
58 sgs[0] = &sg; 58 sgs[0] = &sg;
59 sg_init_one(&ret, &req_data->resp.ret, sizeof(req_data->resp)); 59 sg_init_one(&ret, &req_data->resp.ret, sizeof(req_data->resp));
@@ -90,7 +90,7 @@ static int virtio_pmem_flush(struct nd_region *nd_region)
90 } else { 90 } else {
91 /* A host repsonse results in "host_ack" getting called */ 91 /* A host repsonse results in "host_ack" getting called */
92 wait_event(req_data->host_acked, req_data->done); 92 wait_event(req_data->host_acked, req_data->done);
93 err = virtio32_to_cpu(vdev, req_data->resp.ret); 93 err = le32_to_cpu(req_data->resp.ret);
94 } 94 }
95 95
96 kfree(req_data); 96 kfree(req_data);
diff --git a/include/uapi/linux/virtio_pmem.h b/include/uapi/linux/virtio_pmem.h
index efcd72f2d20d..9a63ed6d062f 100644
--- a/include/uapi/linux/virtio_pmem.h
+++ b/include/uapi/linux/virtio_pmem.h
@@ -23,12 +23,12 @@ struct virtio_pmem_config {
23 23
24struct virtio_pmem_resp { 24struct virtio_pmem_resp {
25 /* Host return status corresponding to flush request */ 25 /* Host return status corresponding to flush request */
26 __u32 ret; 26 __le32 ret;
27}; 27};
28 28
29struct virtio_pmem_req { 29struct virtio_pmem_req {
30 /* command type */ 30 /* command type */
31 __u32 type; 31 __le32 type;
32}; 32};
33 33
34#endif 34#endif