aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2017-01-13 08:06:10 -0500
committerMark Brown <broonie@kernel.org>2017-01-17 13:28:18 -0500
commit8b6c8955b5dc21358cb1f67cadc5514d2353375d (patch)
tree238b240f1fc379d293f6ef0fac3b8ff7f3538286
parentfafd67940774733fa97f4b09412aea6981b82e0a (diff)
spi/mpc52xx: Use kmalloc_array() in mpc52xx_spi_probe()
* A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/spi/spi-mpc52xx.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/spi/spi-mpc52xx.c b/drivers/spi/spi-mpc52xx.c
index c36002110c30..8cc129efe7ba 100644
--- a/drivers/spi/spi-mpc52xx.c
+++ b/drivers/spi/spi-mpc52xx.c
@@ -437,8 +437,9 @@ static int mpc52xx_spi_probe(struct platform_device *op)
437 ms->gpio_cs_count = of_gpio_count(op->dev.of_node); 437 ms->gpio_cs_count = of_gpio_count(op->dev.of_node);
438 if (ms->gpio_cs_count > 0) { 438 if (ms->gpio_cs_count > 0) {
439 master->num_chipselect = ms->gpio_cs_count; 439 master->num_chipselect = ms->gpio_cs_count;
440 ms->gpio_cs = kmalloc(ms->gpio_cs_count * sizeof(unsigned int), 440 ms->gpio_cs = kmalloc_array(ms->gpio_cs_count,
441 GFP_KERNEL); 441 sizeof(*ms->gpio_cs),
442 GFP_KERNEL);
442 if (!ms->gpio_cs) { 443 if (!ms->gpio_cs) {
443 rc = -ENOMEM; 444 rc = -ENOMEM;
444 goto err_alloc_gpio; 445 goto err_alloc_gpio;