aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIngo Molnar <mingo@kernel.org>2013-10-10 00:25:23 -0400
committerIngo Molnar <mingo@kernel.org>2013-10-10 00:25:23 -0400
commit8a749de5e32d2b72def93f7bd7a2745580d75872 (patch)
treee46d9059d0328bcb2faea1c084d17f749338cfe4
parenta44eb870f815356dac56adf3a380ee9b94787424 (diff)
parentb4042ceaabbd913bc5b397ddd1e396eeb312d72f (diff)
Merge branch 'fortglx/3.13/time' of git://git.linaro.org/people/jstultz/linux into timers/core
Pull more timekeeping items for v3.13 from John Stultz: * Small cleanup in the clocksource code. * Fix for rtc-pl031 to let it work with alarmtimers. * Move arm64 to using the generic sched_clock framework & resulting cleanup in the generic sched_clock code. Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--arch/arm/kernel/arch_timer.c14
-rw-r--r--arch/arm64/Kconfig1
-rw-r--r--arch/arm64/kernel/time.c10
-rw-r--r--drivers/clocksource/arm_arch_timer.c10
-rw-r--r--drivers/rtc/rtc-pl031.c3
-rw-r--r--include/linux/sched_clock.h2
-rw-r--r--kernel/time/clocksource.c4
-rw-r--r--kernel/time/sched_clock.c9
8 files changed, 15 insertions, 38 deletions
diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
index 221f07b11ccb..1791f12c180b 100644
--- a/arch/arm/kernel/arch_timer.c
+++ b/arch/arm/kernel/arch_timer.c
@@ -11,7 +11,6 @@
11#include <linux/init.h> 11#include <linux/init.h>
12#include <linux/types.h> 12#include <linux/types.h>
13#include <linux/errno.h> 13#include <linux/errno.h>
14#include <linux/sched_clock.h>
15 14
16#include <asm/delay.h> 15#include <asm/delay.h>
17 16
@@ -22,13 +21,6 @@ static unsigned long arch_timer_read_counter_long(void)
22 return arch_timer_read_counter(); 21 return arch_timer_read_counter();
23} 22}
24 23
25static u32 sched_clock_mult __read_mostly;
26
27static unsigned long long notrace arch_timer_sched_clock(void)
28{
29 return arch_timer_read_counter() * sched_clock_mult;
30}
31
32static struct delay_timer arch_delay_timer; 24static struct delay_timer arch_delay_timer;
33 25
34static void __init arch_timer_delay_timer_register(void) 26static void __init arch_timer_delay_timer_register(void)
@@ -48,11 +40,5 @@ int __init arch_timer_arch_init(void)
48 40
49 arch_timer_delay_timer_register(); 41 arch_timer_delay_timer_register();
50 42
51 /* Cache the sched_clock multiplier to save a divide in the hot path. */
52 sched_clock_mult = NSEC_PER_SEC / arch_timer_rate;
53 sched_clock_func = arch_timer_sched_clock;
54 pr_info("sched_clock: ARM arch timer >56 bits at %ukHz, resolution %uns\n",
55 arch_timer_rate / 1000, sched_clock_mult);
56
57 return 0; 43 return 0;
58} 44}
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index c04454876bcb..35fd0eb57270 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -14,6 +14,7 @@ config ARM64
14 select GENERIC_IOMAP 14 select GENERIC_IOMAP
15 select GENERIC_IRQ_PROBE 15 select GENERIC_IRQ_PROBE
16 select GENERIC_IRQ_SHOW 16 select GENERIC_IRQ_SHOW
17 select GENERIC_SCHED_CLOCK
17 select GENERIC_SMP_IDLE_THREAD 18 select GENERIC_SMP_IDLE_THREAD
18 select GENERIC_TIME_VSYSCALL 19 select GENERIC_TIME_VSYSCALL
19 select HARDIRQS_SW_RESEND 20 select HARDIRQS_SW_RESEND
diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
index 03dc3718eb13..29c39d5d77e3 100644
--- a/arch/arm64/kernel/time.c
+++ b/arch/arm64/kernel/time.c
@@ -61,13 +61,6 @@ unsigned long profile_pc(struct pt_regs *regs)
61EXPORT_SYMBOL(profile_pc); 61EXPORT_SYMBOL(profile_pc);
62#endif 62#endif
63 63
64static u64 sched_clock_mult __read_mostly;
65
66unsigned long long notrace sched_clock(void)
67{
68 return arch_timer_read_counter() * sched_clock_mult;
69}
70
71void __init time_init(void) 64void __init time_init(void)
72{ 65{
73 u32 arch_timer_rate; 66 u32 arch_timer_rate;
@@ -78,9 +71,6 @@ void __init time_init(void)
78 if (!arch_timer_rate) 71 if (!arch_timer_rate)
79 panic("Unable to initialise architected timer.\n"); 72 panic("Unable to initialise architected timer.\n");
80 73
81 /* Cache the sched_clock multiplier to save a divide in the hot path. */
82 sched_clock_mult = NSEC_PER_SEC / arch_timer_rate;
83
84 /* Calibrate the delay loop directly */ 74 /* Calibrate the delay loop directly */
85 lpj_fine = arch_timer_rate / HZ; 75 lpj_fine = arch_timer_rate / HZ;
86} 76}
diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index b94b0d44c158..f655036b524f 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -20,6 +20,7 @@
20#include <linux/of_address.h> 20#include <linux/of_address.h>
21#include <linux/io.h> 21#include <linux/io.h>
22#include <linux/slab.h> 22#include <linux/slab.h>
23#include <linux/sched_clock.h>
23 24
24#include <asm/arch_timer.h> 25#include <asm/arch_timer.h>
25#include <asm/virt.h> 26#include <asm/virt.h>
@@ -514,6 +515,15 @@ static int __init arch_timer_register(void)
514 goto out; 515 goto out;
515 } 516 }
516 517
518 clocksource_register_hz(&clocksource_counter, arch_timer_rate);
519 cyclecounter.mult = clocksource_counter.mult;
520 cyclecounter.shift = clocksource_counter.shift;
521 timecounter_init(&timecounter, &cyclecounter,
522 arch_counter_get_cntvct());
523
524 /* 56 bits minimum, so we assume worst case rollover */
525 sched_clock_register(arch_timer_read_counter, 56, arch_timer_rate);
526
517 if (arch_timer_use_virtual) { 527 if (arch_timer_use_virtual) {
518 ppi = arch_timer_ppi[VIRT_PPI]; 528 ppi = arch_timer_ppi[VIRT_PPI];
519 err = request_percpu_irq(ppi, arch_timer_handler_virt, 529 err = request_percpu_irq(ppi, arch_timer_handler_virt,
diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
index 0f0609b1aa2c..e3b25712b659 100644
--- a/drivers/rtc/rtc-pl031.c
+++ b/drivers/rtc/rtc-pl031.c
@@ -371,6 +371,7 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id)
371 } 371 }
372 } 372 }
373 373
374 device_init_wakeup(&adev->dev, 1);
374 ldata->rtc = rtc_device_register("pl031", &adev->dev, ops, 375 ldata->rtc = rtc_device_register("pl031", &adev->dev, ops,
375 THIS_MODULE); 376 THIS_MODULE);
376 if (IS_ERR(ldata->rtc)) { 377 if (IS_ERR(ldata->rtc)) {
@@ -384,8 +385,6 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id)
384 goto out_no_irq; 385 goto out_no_irq;
385 } 386 }
386 387
387 device_init_wakeup(&adev->dev, 1);
388
389 return 0; 388 return 0;
390 389
391out_no_irq: 390out_no_irq:
diff --git a/include/linux/sched_clock.h b/include/linux/sched_clock.h
index eca7abeb86fc..cddf0c2940b6 100644
--- a/include/linux/sched_clock.h
+++ b/include/linux/sched_clock.h
@@ -18,6 +18,4 @@ extern void setup_sched_clock(u32 (*read)(void), int bits, unsigned long rate);
18extern void sched_clock_register(u64 (*read)(void), int bits, 18extern void sched_clock_register(u64 (*read)(void), int bits,
19 unsigned long rate); 19 unsigned long rate);
20 20
21extern unsigned long long (*sched_clock_func)(void);
22
23#endif 21#endif
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 64cf63ca09cc..c9317e14aae6 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -940,7 +940,7 @@ static ssize_t sysfs_override_clocksource(struct device *dev,
940 struct device_attribute *attr, 940 struct device_attribute *attr,
941 const char *buf, size_t count) 941 const char *buf, size_t count)
942{ 942{
943 size_t ret; 943 ssize_t ret;
944 944
945 mutex_lock(&clocksource_mutex); 945 mutex_lock(&clocksource_mutex);
946 946
@@ -968,7 +968,7 @@ static ssize_t sysfs_unbind_clocksource(struct device *dev,
968{ 968{
969 struct clocksource *cs; 969 struct clocksource *cs;
970 char name[CS_NAME_LEN]; 970 char name[CS_NAME_LEN];
971 size_t ret; 971 ssize_t ret;
972 972
973 ret = sysfs_get_uname(buf, name, count); 973 ret = sysfs_get_uname(buf, name, count);
974 if (ret < 0) 974 if (ret < 0)
diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c
index f388baeaf2b6..68b799375981 100644
--- a/kernel/time/sched_clock.c
+++ b/kernel/time/sched_clock.c
@@ -63,7 +63,7 @@ static inline u64 notrace cyc_to_ns(u64 cyc, u32 mult, u32 shift)
63 return (cyc * mult) >> shift; 63 return (cyc * mult) >> shift;
64} 64}
65 65
66static unsigned long long notrace sched_clock_32(void) 66unsigned long long notrace sched_clock(void)
67{ 67{
68 u64 epoch_ns; 68 u64 epoch_ns;
69 u64 epoch_cyc; 69 u64 epoch_cyc;
@@ -170,13 +170,6 @@ void __init setup_sched_clock(u32 (*read)(void), int bits, unsigned long rate)
170 sched_clock_register(read_sched_clock_32_wrapper, bits, rate); 170 sched_clock_register(read_sched_clock_32_wrapper, bits, rate);
171} 171}
172 172
173unsigned long long __read_mostly (*sched_clock_func)(void) = sched_clock_32;
174
175unsigned long long notrace sched_clock(void)
176{
177 return sched_clock_func();
178}
179
180void __init sched_clock_postinit(void) 173void __init sched_clock_postinit(void)
181{ 174{
182 /* 175 /*