aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomi Valkeinen <tomi.valkeinen@ti.com>2015-11-10 08:50:53 -0500
committerTomi Valkeinen <tomi.valkeinen@ti.com>2017-04-03 05:36:40 -0400
commit892fdcb05e3123192fb954a02fe75b9444d001a3 (patch)
tree27c5b08976f48a84080fe36e20b941030b168468
parent39637e10032a15dc56abef1846d5be47698be1bb (diff)
drm/omap: display: don't use dsi_get_pixel_size()
display.c uses dsi_get_pixel_size() which is implemented in the DSI driver, and we won't have that in the omapdss-base module, to which we want to move display.c This patch changes display.c not to use dsi_get_pixel_size(). The call can be replaced with a simple check for OMAP_DSS_DSI_FMT_RGB565. We can also make dsi_get_pixel_size() static as it's no longer used outside dsi.c. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
-rw-r--r--drivers/gpu/drm/omapdrm/dss/display.c6
-rw-r--r--drivers/gpu/drm/omapdrm/dss/dsi.c2
-rw-r--r--drivers/gpu/drm/omapdrm/dss/dss.h8
3 files changed, 4 insertions, 12 deletions
diff --git a/drivers/gpu/drm/omapdrm/dss/display.c b/drivers/gpu/drm/omapdrm/dss/display.c
index 425a5a8dff8b..333ba284ef6d 100644
--- a/drivers/gpu/drm/omapdrm/dss/display.c
+++ b/drivers/gpu/drm/omapdrm/dss/display.c
@@ -55,10 +55,10 @@ int omapdss_default_get_recommended_bpp(struct omap_dss_device *dssdev)
55 else 55 else
56 return 16; 56 return 16;
57 case OMAP_DISPLAY_TYPE_DSI: 57 case OMAP_DISPLAY_TYPE_DSI:
58 if (dsi_get_pixel_size(dssdev->panel.dsi_pix_fmt) > 16) 58 if (dssdev->panel.dsi_pix_fmt == OMAP_DSS_DSI_FMT_RGB565)
59 return 24;
60 else
61 return 16; 59 return 16;
60 else
61 return 24;
62 case OMAP_DISPLAY_TYPE_VENC: 62 case OMAP_DISPLAY_TYPE_VENC:
63 case OMAP_DISPLAY_TYPE_SDI: 63 case OMAP_DISPLAY_TYPE_SDI:
64 case OMAP_DISPLAY_TYPE_HDMI: 64 case OMAP_DISPLAY_TYPE_HDMI:
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
index 5e51a5649efb..f50d6fc0d92e 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -527,7 +527,7 @@ static inline int wait_for_bit_change(struct platform_device *dsidev,
527 return !value; 527 return !value;
528} 528}
529 529
530u8 dsi_get_pixel_size(enum omap_dss_dsi_pixel_format fmt) 530static u8 dsi_get_pixel_size(enum omap_dss_dsi_pixel_format fmt)
531{ 531{
532 switch (fmt) { 532 switch (fmt) {
533 case OMAP_DSS_DSI_FMT_RGB888: 533 case OMAP_DSS_DSI_FMT_RGB888:
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.h b/drivers/gpu/drm/omapdrm/dss/dss.h
index 78f6fc75948b..4d568ac76826 100644
--- a/drivers/gpu/drm/omapdrm/dss/dss.h
+++ b/drivers/gpu/drm/omapdrm/dss/dss.h
@@ -315,15 +315,7 @@ void dsi_uninit_platform_driver(void);
315void dsi_dump_clocks(struct seq_file *s); 315void dsi_dump_clocks(struct seq_file *s);
316 316
317void dsi_irq_handler(void); 317void dsi_irq_handler(void);
318u8 dsi_get_pixel_size(enum omap_dss_dsi_pixel_format fmt);
319 318
320#else
321static inline u8 dsi_get_pixel_size(enum omap_dss_dsi_pixel_format fmt)
322{
323 WARN(1, "%s: DSI not compiled in, returning pixel_size as 0\n",
324 __func__);
325 return 0;
326}
327#endif 319#endif
328 320
329/* DPI */ 321/* DPI */