aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2017-09-15 09:09:29 -0400
committerChris Wilson <chris@chris-wilson.co.uk>2017-09-26 09:19:25 -0400
commit87dc03ad268f285065cdd2e2ac75701a1f04d0b8 (patch)
tree92a00663fa6963404fd51d1d6f8da500109ba452
parent9a2cbf2d7b94660e4c4920cfae4a5eecc83ee485 (diff)
drm/i915/selftests: Try to recover from a wedged GPU during reset tests
If we see the seqno stop progressing, we abandon the test for fear that the GPU died following the reset. However, during test teardown we still wait for the GPU to idle before continuing, but we have already confirmed that the GPU is dead. Furthermore, since we are inside a reset test, we have disabled the hangchecker, and so there is no safety net and we wait indefinitely. Detect the stuck GPU and declare it wedged as a state of emergency so we can escape. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Jari Tahvanainen <jari.tahvanainen@intel.com> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20170915130929.18892-1-chris@chris-wilson.co.uk Tested-by: Jari Tahvanainen <jari.tahvanainen@intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
-rw-r--r--drivers/gpu/drm/i915/selftests/intel_hangcheck.c24
1 files changed, 19 insertions, 5 deletions
diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
index 02e52a146ed8..377c1de766ce 100644
--- a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
+++ b/drivers/gpu/drm/i915/selftests/intel_hangcheck.c
@@ -621,7 +621,12 @@ static int igt_wait_reset(void *arg)
621 __i915_add_request(rq, true); 621 __i915_add_request(rq, true);
622 622
623 if (!wait_for_hang(&h, rq)) { 623 if (!wait_for_hang(&h, rq)) {
624 pr_err("Failed to start request %x\n", rq->fence.seqno); 624 pr_err("Failed to start request %x, at %x\n",
625 rq->fence.seqno, hws_seqno(&h, rq));
626
627 i915_reset(i915, 0);
628 i915_gem_set_wedged(i915);
629
625 err = -EIO; 630 err = -EIO;
626 goto out_rq; 631 goto out_rq;
627 } 632 }
@@ -708,10 +713,14 @@ static int igt_reset_queue(void *arg)
708 __i915_add_request(rq, true); 713 __i915_add_request(rq, true);
709 714
710 if (!wait_for_hang(&h, prev)) { 715 if (!wait_for_hang(&h, prev)) {
711 pr_err("Failed to start request %x\n", 716 pr_err("Failed to start request %x, at %x\n",
712 prev->fence.seqno); 717 prev->fence.seqno, hws_seqno(&h, prev));
713 i915_gem_request_put(rq); 718 i915_gem_request_put(rq);
714 i915_gem_request_put(prev); 719 i915_gem_request_put(prev);
720
721 i915_reset(i915, 0);
722 i915_gem_set_wedged(i915);
723
715 err = -EIO; 724 err = -EIO;
716 goto fini; 725 goto fini;
717 } 726 }
@@ -806,7 +815,12 @@ static int igt_handle_error(void *arg)
806 __i915_add_request(rq, true); 815 __i915_add_request(rq, true);
807 816
808 if (!wait_for_hang(&h, rq)) { 817 if (!wait_for_hang(&h, rq)) {
809 pr_err("Failed to start request %x\n", rq->fence.seqno); 818 pr_err("Failed to start request %x, at %x\n",
819 rq->fence.seqno, hws_seqno(&h, rq));
820
821 i915_reset(i915, 0);
822 i915_gem_set_wedged(i915);
823
810 err = -EIO; 824 err = -EIO;
811 goto err_request; 825 goto err_request;
812 } 826 }
@@ -843,8 +857,8 @@ err_unlock:
843int intel_hangcheck_live_selftests(struct drm_i915_private *i915) 857int intel_hangcheck_live_selftests(struct drm_i915_private *i915)
844{ 858{
845 static const struct i915_subtest tests[] = { 859 static const struct i915_subtest tests[] = {
860 SUBTEST(igt_global_reset), /* attempt to recover GPU first */
846 SUBTEST(igt_hang_sanitycheck), 861 SUBTEST(igt_hang_sanitycheck),
847 SUBTEST(igt_global_reset),
848 SUBTEST(igt_reset_engine), 862 SUBTEST(igt_reset_engine),
849 SUBTEST(igt_reset_active_engines), 863 SUBTEST(igt_reset_active_engines),
850 SUBTEST(igt_wait_reset), 864 SUBTEST(igt_wait_reset),