aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2018-03-08 06:01:25 -0500
committerTakashi Iwai <tiwai@suse.de>2018-03-08 06:06:07 -0500
commit85d59b57be59970e892e9ab13f3cc3d21f14ac23 (patch)
treeb03e3bac71822daff9bbeef34639155388315d56
parent7bd80091567789f1c0cb70eb4737aac8bcd2b6b9 (diff)
ALSA: seq: Remove superfluous snd_seq_queue_client_leave_cells() call
With the previous two fixes for the write / ioctl races: ALSA: seq: Don't allow resizing pool in use ALSA: seq: More protection for concurrent write and ioctl races the cells aren't any longer in queues at the point calling snd_seq_pool_done() in snd_seq_ioctl_set_client_pool(). Hence the function call snd_seq_queue_client_leave_cells() can be dropped safely from there. Suggested-by: Nicolai Stange <nstange@suse.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/core/seq/seq_clientmgr.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c
index 1b62421dadd1..918338dea5b9 100644
--- a/sound/core/seq/seq_clientmgr.c
+++ b/sound/core/seq/seq_clientmgr.c
@@ -1846,7 +1846,6 @@ static int snd_seq_ioctl_set_client_pool(struct snd_seq_client *client,
1846 return -EBUSY; 1846 return -EBUSY;
1847 /* remove all existing cells */ 1847 /* remove all existing cells */
1848 snd_seq_pool_mark_closing(client->pool); 1848 snd_seq_pool_mark_closing(client->pool);
1849 snd_seq_queue_client_leave_cells(client->number);
1850 snd_seq_pool_done(client->pool); 1849 snd_seq_pool_done(client->pool);
1851 } 1850 }
1852 client->pool->size = info->output_pool; 1851 client->pool->size = info->output_pool;