aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGilad Ben-Yossef <gilad@benyossef.com>2017-06-27 03:27:22 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-06-29 10:38:51 -0400
commit8422f1120bcfacc724a1928ea691d3953c62756e (patch)
tree0789fc0787a71d1c2c4af6aa3895f3adb141c020
parent1de8f59fa44b070d5ae6c3f2f4b06d42ab4c8b46 (diff)
staging: ccree: remove custom type ssi_fips_error_t
Replace custom type ssi_fips_error_t with underlying enum. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/ccree/ssi_fips.c4
-rw-r--r--drivers/staging/ccree/ssi_fips.h6
-rw-r--r--drivers/staging/ccree/ssi_fips_ext.c6
-rw-r--r--drivers/staging/ccree/ssi_fips_ll.c30
-rw-r--r--drivers/staging/ccree/ssi_fips_local.c28
-rw-r--r--drivers/staging/ccree/ssi_fips_local.h2
6 files changed, 38 insertions, 38 deletions
diff --git a/drivers/staging/ccree/ssi_fips.c b/drivers/staging/ccree/ssi_fips.c
index 2b8a616b5f01..948ea4996ef0 100644
--- a/drivers/staging/ccree/ssi_fips.c
+++ b/drivers/staging/ccree/ssi_fips.c
@@ -24,7 +24,7 @@
24 24
25 25
26extern int ssi_fips_ext_get_state(ssi_fips_state_t *p_state); 26extern int ssi_fips_ext_get_state(ssi_fips_state_t *p_state);
27extern int ssi_fips_ext_get_error(ssi_fips_error_t *p_err); 27extern int ssi_fips_ext_get_error(enum cc_fips_error *p_err);
28 28
29/* 29/*
30 * This function returns the REE FIPS state. 30 * This function returns the REE FIPS state.
@@ -48,7 +48,7 @@ EXPORT_SYMBOL(ssi_fips_get_state);
48 * This function returns the REE FIPS error. 48 * This function returns the REE FIPS error.
49 * It should be called by kernel module. 49 * It should be called by kernel module.
50 */ 50 */
51int ssi_fips_get_error(ssi_fips_error_t *p_err) 51int ssi_fips_get_error(enum cc_fips_error *p_err)
52{ 52{
53 int rc = 0; 53 int rc = 0;
54 54
diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h
index 2fdb1b90a890..d1cd489eb465 100644
--- a/drivers/staging/ccree/ssi_fips.h
+++ b/drivers/staging/ccree/ssi_fips.h
@@ -30,7 +30,7 @@ typedef enum ssi_fips_state {
30} ssi_fips_state_t; 30} ssi_fips_state_t;
31 31
32 32
33typedef enum ssi_fips_error { 33enum cc_fips_error {
34 CC_REE_FIPS_ERROR_OK = 0, 34 CC_REE_FIPS_ERROR_OK = 0,
35 CC_REE_FIPS_ERROR_GENERAL, 35 CC_REE_FIPS_ERROR_GENERAL,
36 CC_REE_FIPS_ERROR_FROM_TEE, 36 CC_REE_FIPS_ERROR_FROM_TEE,
@@ -53,12 +53,12 @@ typedef enum ssi_fips_error {
53 CC_REE_FIPS_ERROR_HMAC_SHA512_PUT, 53 CC_REE_FIPS_ERROR_HMAC_SHA512_PUT,
54 CC_REE_FIPS_ERROR_ROM_CHECKSUM, 54 CC_REE_FIPS_ERROR_ROM_CHECKSUM,
55 CC_REE_FIPS_ERROR_RESERVE32B = S32_MAX 55 CC_REE_FIPS_ERROR_RESERVE32B = S32_MAX
56} ssi_fips_error_t; 56};
57 57
58 58
59 59
60int ssi_fips_get_state(ssi_fips_state_t *p_state); 60int ssi_fips_get_state(ssi_fips_state_t *p_state);
61int ssi_fips_get_error(ssi_fips_error_t *p_err); 61int ssi_fips_get_error(enum cc_fips_error *p_err);
62 62
63#endif /*__SSI_FIPS_H__*/ 63#endif /*__SSI_FIPS_H__*/
64 64
diff --git a/drivers/staging/ccree/ssi_fips_ext.c b/drivers/staging/ccree/ssi_fips_ext.c
index b897c0386264..aab2805d63ac 100644
--- a/drivers/staging/ccree/ssi_fips_ext.c
+++ b/drivers/staging/ccree/ssi_fips_ext.c
@@ -29,7 +29,7 @@ module_param(tee_error, bool, 0644);
29MODULE_PARM_DESC(tee_error, "Simulate TEE library failure flag: 0 - no error (default), 1 - TEE error occured "); 29MODULE_PARM_DESC(tee_error, "Simulate TEE library failure flag: 0 - no error (default), 1 - TEE error occured ");
30 30
31static ssi_fips_state_t fips_state = CC_FIPS_STATE_NOT_SUPPORTED; 31static ssi_fips_state_t fips_state = CC_FIPS_STATE_NOT_SUPPORTED;
32static ssi_fips_error_t fips_error = CC_REE_FIPS_ERROR_OK; 32static enum cc_fips_error fips_error = CC_REE_FIPS_ERROR_OK;
33 33
34/* 34/*
35 * This function returns the FIPS REE state. 35 * This function returns the FIPS REE state.
@@ -55,7 +55,7 @@ int ssi_fips_ext_get_state(ssi_fips_state_t *p_state)
55 * the error value is stored. 55 * the error value is stored.
56 * The reference code uses global variable. 56 * The reference code uses global variable.
57 */ 57 */
58int ssi_fips_ext_get_error(ssi_fips_error_t *p_err) 58int ssi_fips_ext_get_error(enum cc_fips_error *p_err)
59{ 59{
60 int rc = 0; 60 int rc = 0;
61 61
@@ -85,7 +85,7 @@ int ssi_fips_ext_set_state(ssi_fips_state_t state)
85 * the error value is stored. 85 * the error value is stored.
86 * The reference code uses global variable. 86 * The reference code uses global variable.
87 */ 87 */
88int ssi_fips_ext_set_error(ssi_fips_error_t err) 88int ssi_fips_ext_set_error(enum cc_fips_error err)
89{ 89{
90 fips_error = err; 90 fips_error = err;
91 return 0; 91 return 0;
diff --git a/drivers/staging/ccree/ssi_fips_ll.c b/drivers/staging/ccree/ssi_fips_ll.c
index 4a11f15b18af..cbb0fe26722c 100644
--- a/drivers/staging/ccree/ssi_fips_ll.c
+++ b/drivers/staging/ccree/ssi_fips_ll.c
@@ -271,7 +271,7 @@ static const FipsGcmData FipsGcmDataTable[] = {
271#define FIPS_GCM_NUM_OF_TESTS (sizeof(FipsGcmDataTable) / sizeof(FipsGcmData)) 271#define FIPS_GCM_NUM_OF_TESTS (sizeof(FipsGcmDataTable) / sizeof(FipsGcmData))
272 272
273 273
274static inline ssi_fips_error_t 274static inline enum cc_fips_error
275FIPS_CipherToFipsError(enum drv_cipher_mode mode, bool is_aes) 275FIPS_CipherToFipsError(enum drv_cipher_mode mode, bool is_aes)
276{ 276{
277 switch (mode) 277 switch (mode)
@@ -415,10 +415,10 @@ ssi_cipher_fips_run_test(struct ssi_drvdata *drvdata,
415} 415}
416 416
417 417
418ssi_fips_error_t 418enum cc_fips_error
419ssi_cipher_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer) 419ssi_cipher_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer)
420{ 420{
421 ssi_fips_error_t error = CC_REE_FIPS_ERROR_OK; 421 enum cc_fips_error error = CC_REE_FIPS_ERROR_OK;
422 size_t i; 422 size_t i;
423 struct fips_cipher_ctx *virt_ctx = (struct fips_cipher_ctx *)cpu_addr_buffer; 423 struct fips_cipher_ctx *virt_ctx = (struct fips_cipher_ctx *)cpu_addr_buffer;
424 424
@@ -544,10 +544,10 @@ ssi_cmac_fips_run_test(struct ssi_drvdata *drvdata,
544 return rc; 544 return rc;
545} 545}
546 546
547ssi_fips_error_t 547enum cc_fips_error
548ssi_cmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer) 548ssi_cmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer)
549{ 549{
550 ssi_fips_error_t error = CC_REE_FIPS_ERROR_OK; 550 enum cc_fips_error error = CC_REE_FIPS_ERROR_OK;
551 size_t i; 551 size_t i;
552 struct fips_cmac_ctx *virt_ctx = (struct fips_cmac_ctx *)cpu_addr_buffer; 552 struct fips_cmac_ctx *virt_ctx = (struct fips_cmac_ctx *)cpu_addr_buffer;
553 553
@@ -604,7 +604,7 @@ ssi_cmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer,
604} 604}
605 605
606 606
607static inline ssi_fips_error_t 607static inline enum cc_fips_error
608FIPS_HashToFipsError(enum drv_hash_mode hash_mode) 608FIPS_HashToFipsError(enum drv_hash_mode hash_mode)
609{ 609{
610 switch (hash_mode) { 610 switch (hash_mode) {
@@ -690,10 +690,10 @@ ssi_hash_fips_run_test(struct ssi_drvdata *drvdata,
690 return rc; 690 return rc;
691} 691}
692 692
693ssi_fips_error_t 693enum cc_fips_error
694ssi_hash_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer) 694ssi_hash_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer)
695{ 695{
696 ssi_fips_error_t error = CC_REE_FIPS_ERROR_OK; 696 enum cc_fips_error error = CC_REE_FIPS_ERROR_OK;
697 size_t i; 697 size_t i;
698 struct fips_hash_ctx *virt_ctx = (struct fips_hash_ctx *)cpu_addr_buffer; 698 struct fips_hash_ctx *virt_ctx = (struct fips_hash_ctx *)cpu_addr_buffer;
699 699
@@ -780,7 +780,7 @@ ssi_hash_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer,
780} 780}
781 781
782 782
783static inline ssi_fips_error_t 783static inline enum cc_fips_error
784FIPS_HmacToFipsError(enum drv_hash_mode hash_mode) 784FIPS_HmacToFipsError(enum drv_hash_mode hash_mode)
785{ 785{
786 switch (hash_mode) { 786 switch (hash_mode) {
@@ -1006,10 +1006,10 @@ ssi_hmac_fips_run_test(struct ssi_drvdata *drvdata,
1006 return rc; 1006 return rc;
1007} 1007}
1008 1008
1009ssi_fips_error_t 1009enum cc_fips_error
1010ssi_hmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer) 1010ssi_hmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer)
1011{ 1011{
1012 ssi_fips_error_t error = CC_REE_FIPS_ERROR_OK; 1012 enum cc_fips_error error = CC_REE_FIPS_ERROR_OK;
1013 size_t i; 1013 size_t i;
1014 struct fips_hmac_ctx *virt_ctx = (struct fips_hmac_ctx *)cpu_addr_buffer; 1014 struct fips_hmac_ctx *virt_ctx = (struct fips_hmac_ctx *)cpu_addr_buffer;
1015 1015
@@ -1248,10 +1248,10 @@ ssi_ccm_fips_run_test(struct ssi_drvdata *drvdata,
1248 return rc; 1248 return rc;
1249} 1249}
1250 1250
1251ssi_fips_error_t 1251enum cc_fips_error
1252ssi_ccm_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer) 1252ssi_ccm_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer)
1253{ 1253{
1254 ssi_fips_error_t error = CC_REE_FIPS_ERROR_OK; 1254 enum cc_fips_error error = CC_REE_FIPS_ERROR_OK;
1255 size_t i; 1255 size_t i;
1256 struct fips_ccm_ctx *virt_ctx = (struct fips_ccm_ctx *)cpu_addr_buffer; 1256 struct fips_ccm_ctx *virt_ctx = (struct fips_ccm_ctx *)cpu_addr_buffer;
1257 1257
@@ -1546,10 +1546,10 @@ ssi_gcm_fips_run_test(struct ssi_drvdata *drvdata,
1546 return rc; 1546 return rc;
1547} 1547}
1548 1548
1549ssi_fips_error_t 1549enum cc_fips_error
1550ssi_gcm_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer) 1550ssi_gcm_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer)
1551{ 1551{
1552 ssi_fips_error_t error = CC_REE_FIPS_ERROR_OK; 1552 enum cc_fips_error error = CC_REE_FIPS_ERROR_OK;
1553 size_t i; 1553 size_t i;
1554 struct fips_gcm_ctx *virt_ctx = (struct fips_gcm_ctx *)cpu_addr_buffer; 1554 struct fips_gcm_ctx *virt_ctx = (struct fips_gcm_ctx *)cpu_addr_buffer;
1555 1555
diff --git a/drivers/staging/ccree/ssi_fips_local.c b/drivers/staging/ccree/ssi_fips_local.c
index 50d7189994e9..dfc871da5efb 100644
--- a/drivers/staging/ccree/ssi_fips_local.c
+++ b/drivers/staging/ccree/ssi_fips_local.c
@@ -51,17 +51,17 @@ struct ssi_fips_handle {
51 51
52 52
53extern int ssi_fips_get_state(ssi_fips_state_t *p_state); 53extern int ssi_fips_get_state(ssi_fips_state_t *p_state);
54extern int ssi_fips_get_error(ssi_fips_error_t *p_err); 54extern int ssi_fips_get_error(enum cc_fips_error *p_err);
55extern int ssi_fips_ext_set_state(ssi_fips_state_t state); 55extern int ssi_fips_ext_set_state(ssi_fips_state_t state);
56extern int ssi_fips_ext_set_error(ssi_fips_error_t err); 56extern int ssi_fips_ext_set_error(enum cc_fips_error err);
57 57
58/* FIPS power-up tests */ 58/* FIPS power-up tests */
59extern ssi_fips_error_t ssi_cipher_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer); 59extern enum cc_fips_error ssi_cipher_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer);
60extern ssi_fips_error_t ssi_cmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer); 60extern enum cc_fips_error ssi_cmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer);
61extern ssi_fips_error_t ssi_hash_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer); 61extern enum cc_fips_error ssi_hash_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer);
62extern ssi_fips_error_t ssi_hmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer); 62extern enum cc_fips_error ssi_hmac_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer);
63extern ssi_fips_error_t ssi_ccm_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer); 63extern enum cc_fips_error ssi_ccm_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer);
64extern ssi_fips_error_t ssi_gcm_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer); 64extern enum cc_fips_error ssi_gcm_fips_power_up_tests(struct ssi_drvdata *drvdata, void *cpu_addr_buffer, dma_addr_t dma_coherent_buffer);
65extern size_t ssi_fips_max_mem_alloc_size(void); 65extern size_t ssi_fips_max_mem_alloc_size(void);
66 66
67 67
@@ -84,7 +84,7 @@ static enum ssi_fips_error ssi_fips_get_tee_error(struct ssi_drvdata *drvdata)
84 * By writing the error state to HOST_GPR0 register. The function is called from 84 * By writing the error state to HOST_GPR0 register. The function is called from
85 * driver entry point so no need to protect by mutex. 85 * driver entry point so no need to protect by mutex.
86 */ 86 */
87static void ssi_fips_update_tee_upon_ree_status(struct ssi_drvdata *drvdata, ssi_fips_error_t err) 87static void ssi_fips_update_tee_upon_ree_status(struct ssi_drvdata *drvdata, enum cc_fips_error err)
88{ 88{
89 void __iomem *cc_base = drvdata->cc_base; 89 void __iomem *cc_base = drvdata->cc_base;
90 if (err == CC_REE_FIPS_ERROR_OK) 90 if (err == CC_REE_FIPS_ERROR_OK)
@@ -162,9 +162,9 @@ static void fips_dsr(unsigned long devarg)
162} 162}
163 163
164 164
165ssi_fips_error_t cc_fips_run_power_up_tests(struct ssi_drvdata *drvdata) 165enum cc_fips_error cc_fips_run_power_up_tests(struct ssi_drvdata *drvdata)
166{ 166{
167 ssi_fips_error_t fips_error = CC_REE_FIPS_ERROR_OK; 167 enum cc_fips_error fips_error = CC_REE_FIPS_ERROR_OK;
168 void *cpu_addr_buffer = NULL; 168 void *cpu_addr_buffer = NULL;
169 dma_addr_t dma_handle; 169 dma_addr_t dma_handle;
170 size_t alloc_buff_size = ssi_fips_max_mem_alloc_size(); 170 size_t alloc_buff_size = ssi_fips_max_mem_alloc_size();
@@ -259,10 +259,10 @@ int ssi_fips_set_state(ssi_fips_state_t state)
259/* The function sets the REE FIPS error, and pushes the error to TEE library. * 259/* The function sets the REE FIPS error, and pushes the error to TEE library. *
260 * It should be used when any of the KAT tests fails. 260 * It should be used when any of the KAT tests fails.
261 */ 261 */
262int ssi_fips_set_error(struct ssi_drvdata *p_drvdata, ssi_fips_error_t err) 262int ssi_fips_set_error(struct ssi_drvdata *p_drvdata, enum cc_fips_error err)
263{ 263{
264 int rc = 0; 264 int rc = 0;
265 ssi_fips_error_t current_err; 265 enum cc_fips_error current_err;
266 266
267 FIPS_LOG("ssi_fips_set_error - fips_error = %d \n", err); 267 FIPS_LOG("ssi_fips_set_error - fips_error = %d \n", err);
268 268
@@ -297,7 +297,7 @@ int ssi_fips_set_error(struct ssi_drvdata *p_drvdata, ssi_fips_error_t err)
297/* The function called once at driver entry point .*/ 297/* The function called once at driver entry point .*/
298int ssi_fips_init(struct ssi_drvdata *p_drvdata) 298int ssi_fips_init(struct ssi_drvdata *p_drvdata)
299{ 299{
300 ssi_fips_error_t rc = CC_REE_FIPS_ERROR_OK; 300 enum cc_fips_error rc = CC_REE_FIPS_ERROR_OK;
301 struct ssi_fips_handle *fips_h; 301 struct ssi_fips_handle *fips_h;
302 302
303 FIPS_DBG("CC FIPS code .. (fips=%d) \n", ssi_fips_support); 303 FIPS_DBG("CC FIPS code .. (fips=%d) \n", ssi_fips_support);
diff --git a/drivers/staging/ccree/ssi_fips_local.h b/drivers/staging/ccree/ssi_fips_local.h
index fa0908434602..0fbb1e0cea31 100644
--- a/drivers/staging/ccree/ssi_fips_local.h
+++ b/drivers/staging/ccree/ssi_fips_local.h
@@ -53,7 +53,7 @@ typedef enum CC_FipsSyncStatus {
53int ssi_fips_init(struct ssi_drvdata *p_drvdata); 53int ssi_fips_init(struct ssi_drvdata *p_drvdata);
54void ssi_fips_fini(struct ssi_drvdata *drvdata); 54void ssi_fips_fini(struct ssi_drvdata *drvdata);
55int ssi_fips_check_fips_error(void); 55int ssi_fips_check_fips_error(void);
56int ssi_fips_set_error(struct ssi_drvdata *p_drvdata, ssi_fips_error_t err); 56int ssi_fips_set_error(struct ssi_drvdata *p_drvdata, enum cc_fips_error err);
57void fips_handler(struct ssi_drvdata *drvdata); 57void fips_handler(struct ssi_drvdata *drvdata);
58 58
59#else /* CONFIG_CC7XXREE_FIPS_SUPPORT */ 59#else /* CONFIG_CC7XXREE_FIPS_SUPPORT */