diff options
author | Paul Moore <paul@paul-moore.com> | 2019-05-30 12:53:42 -0400 |
---|---|---|
committer | Paul Moore <paul@paul-moore.com> | 2019-05-30 12:53:42 -0400 |
commit | 839d05e413856bd686a33b59294d4e8238169320 (patch) | |
tree | dbf4bd3494b443ac7e6907a4aaa503e8d6a7e284 | |
parent | 0223fad3c98a9588c159a35dda2ef6e68ca27e3f (diff) |
audit: remove the BUG() calls in the audit rule comparison functions
The audit_data_to_entry() function ensures that the operator is valid
so we can get rid of these BUG() calls. We keep the "return 0" just
so the system behaves in a sane-ish manner should something go
horribly wrong.
Signed-off-by: Paul Moore <paul@paul-moore.com>
Acked-by: Richard Guy Briggs <rgb@redhat.com>
-rw-r--r-- | kernel/auditfilter.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c index e69d136eeaf6..1a21b6aa50d1 100644 --- a/kernel/auditfilter.c +++ b/kernel/auditfilter.c | |||
@@ -1220,7 +1220,6 @@ int audit_comparator(u32 left, u32 op, u32 right) | |||
1220 | case Audit_bittest: | 1220 | case Audit_bittest: |
1221 | return ((left & right) == right); | 1221 | return ((left & right) == right); |
1222 | default: | 1222 | default: |
1223 | BUG(); | ||
1224 | return 0; | 1223 | return 0; |
1225 | } | 1224 | } |
1226 | } | 1225 | } |
@@ -1243,7 +1242,6 @@ int audit_uid_comparator(kuid_t left, u32 op, kuid_t right) | |||
1243 | case Audit_bitmask: | 1242 | case Audit_bitmask: |
1244 | case Audit_bittest: | 1243 | case Audit_bittest: |
1245 | default: | 1244 | default: |
1246 | BUG(); | ||
1247 | return 0; | 1245 | return 0; |
1248 | } | 1246 | } |
1249 | } | 1247 | } |
@@ -1266,7 +1264,6 @@ int audit_gid_comparator(kgid_t left, u32 op, kgid_t right) | |||
1266 | case Audit_bitmask: | 1264 | case Audit_bitmask: |
1267 | case Audit_bittest: | 1265 | case Audit_bittest: |
1268 | default: | 1266 | default: |
1269 | BUG(); | ||
1270 | return 0; | 1267 | return 0; |
1271 | } | 1268 | } |
1272 | } | 1269 | } |