aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNayan Deshmukh <nayan26deshmukh@gmail.com>2018-03-29 13:06:32 -0400
committerAlex Deucher <alexander.deucher@amd.com>2018-05-15 14:44:27 -0400
commit8344c53f57057b42a5da87e9557c40fcda18fb7a (patch)
tree295778ddf3582cb8c745f649cdf7ae1b811ed910
parent1297bf2e916d2012995b642dd6851332a73126c2 (diff)
drm/scheduler: remove unused parameter
this patch also effect the amdgpu and etnaviv drivers which use the function drm_sched_entity_init Signed-off-by: Nayan Deshmukh <nayan26deshmukh@gmail.com> Suggested-by: Christian König <christian.koenig@amd.com> Acked-by: Lucas Stach <l.stach@pengutronix.de> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c4
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c2
-rw-r--r--drivers/gpu/drm/etnaviv/etnaviv_drv.c2
-rw-r--r--drivers/gpu/drm/scheduler/gpu_scheduler.c3
-rw-r--r--include/drm/gpu_scheduler.h2
11 files changed, 12 insertions, 13 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
index 6741a62a7d15..a8e531d604fa 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
@@ -91,7 +91,7 @@ static int amdgpu_ctx_init(struct amdgpu_device *adev,
91 continue; 91 continue;
92 92
93 r = drm_sched_entity_init(&ring->sched, &ctx->rings[i].entity, 93 r = drm_sched_entity_init(&ring->sched, &ctx->rings[i].entity,
94 rq, amdgpu_sched_jobs, &ctx->guilty); 94 rq, &ctx->guilty);
95 if (r) 95 if (r)
96 goto failed; 96 goto failed;
97 } 97 }
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index cc3b067e1ec6..5e9fd256faad 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -111,7 +111,7 @@ static int amdgpu_ttm_global_init(struct amdgpu_device *adev)
111 ring = adev->mman.buffer_funcs_ring; 111 ring = adev->mman.buffer_funcs_ring;
112 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_KERNEL]; 112 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_KERNEL];
113 r = drm_sched_entity_init(&ring->sched, &adev->mman.entity, 113 r = drm_sched_entity_init(&ring->sched, &adev->mman.entity,
114 rq, amdgpu_sched_jobs, NULL); 114 rq, NULL);
115 if (r) { 115 if (r) {
116 DRM_ERROR("Failed setting up TTM BO move run queue.\n"); 116 DRM_ERROR("Failed setting up TTM BO move run queue.\n");
117 goto error_entity; 117 goto error_entity;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
index d8dd4028c2bb..de4d77af02ae 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
@@ -242,7 +242,7 @@ int amdgpu_uvd_sw_init(struct amdgpu_device *adev)
242 ring = &adev->uvd.ring; 242 ring = &adev->uvd.ring;
243 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL]; 243 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL];
244 r = drm_sched_entity_init(&ring->sched, &adev->uvd.entity, 244 r = drm_sched_entity_init(&ring->sched, &adev->uvd.entity,
245 rq, amdgpu_sched_jobs, NULL); 245 rq, NULL);
246 if (r != 0) { 246 if (r != 0) {
247 DRM_ERROR("Failed setting up UVD run queue.\n"); 247 DRM_ERROR("Failed setting up UVD run queue.\n");
248 return r; 248 return r;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
index e2186eda3271..a86322f5164f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
@@ -186,7 +186,7 @@ int amdgpu_vce_sw_init(struct amdgpu_device *adev, unsigned long size)
186 ring = &adev->vce.ring[0]; 186 ring = &adev->vce.ring[0];
187 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL]; 187 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL];
188 r = drm_sched_entity_init(&ring->sched, &adev->vce.entity, 188 r = drm_sched_entity_init(&ring->sched, &adev->vce.entity,
189 rq, amdgpu_sched_jobs, NULL); 189 rq, NULL);
190 if (r != 0) { 190 if (r != 0) {
191 DRM_ERROR("Failed setting up VCE run queue.\n"); 191 DRM_ERROR("Failed setting up VCE run queue.\n");
192 return r; 192 return r;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
index 58e495330b38..e5d234cf804f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
@@ -105,7 +105,7 @@ int amdgpu_vcn_sw_init(struct amdgpu_device *adev)
105 ring = &adev->vcn.ring_dec; 105 ring = &adev->vcn.ring_dec;
106 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL]; 106 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL];
107 r = drm_sched_entity_init(&ring->sched, &adev->vcn.entity_dec, 107 r = drm_sched_entity_init(&ring->sched, &adev->vcn.entity_dec,
108 rq, amdgpu_sched_jobs, NULL); 108 rq, NULL);
109 if (r != 0) { 109 if (r != 0) {
110 DRM_ERROR("Failed setting up VCN dec run queue.\n"); 110 DRM_ERROR("Failed setting up VCN dec run queue.\n");
111 return r; 111 return r;
@@ -114,7 +114,7 @@ int amdgpu_vcn_sw_init(struct amdgpu_device *adev)
114 ring = &adev->vcn.ring_enc[0]; 114 ring = &adev->vcn.ring_enc[0];
115 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL]; 115 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL];
116 r = drm_sched_entity_init(&ring->sched, &adev->vcn.entity_enc, 116 r = drm_sched_entity_init(&ring->sched, &adev->vcn.entity_enc,
117 rq, amdgpu_sched_jobs, NULL); 117 rq, NULL);
118 if (r != 0) { 118 if (r != 0) {
119 DRM_ERROR("Failed setting up VCN enc run queue.\n"); 119 DRM_ERROR("Failed setting up VCN enc run queue.\n");
120 return r; 120 return r;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 8e71d3984016..1a8f4e0dd023 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2404,7 +2404,7 @@ int amdgpu_vm_init(struct amdgpu_device *adev, struct amdgpu_vm *vm,
2404 ring = adev->vm_manager.vm_pte_rings[ring_instance]; 2404 ring = adev->vm_manager.vm_pte_rings[ring_instance];
2405 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_KERNEL]; 2405 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_KERNEL];
2406 r = drm_sched_entity_init(&ring->sched, &vm->entity, 2406 r = drm_sched_entity_init(&ring->sched, &vm->entity,
2407 rq, amdgpu_sched_jobs, NULL); 2407 rq, NULL);
2408 if (r) 2408 if (r)
2409 return r; 2409 return r;
2410 2410
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
index 8041b26a7a21..ca6ab56357b5 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
@@ -429,7 +429,7 @@ static int uvd_v6_0_sw_init(void *handle)
429 ring = &adev->uvd.ring_enc[0]; 429 ring = &adev->uvd.ring_enc[0];
430 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL]; 430 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL];
431 r = drm_sched_entity_init(&ring->sched, &adev->uvd.entity_enc, 431 r = drm_sched_entity_init(&ring->sched, &adev->uvd.entity_enc,
432 rq, amdgpu_sched_jobs, NULL); 432 rq, NULL);
433 if (r) { 433 if (r) {
434 DRM_ERROR("Failed setting up UVD ENC run queue.\n"); 434 DRM_ERROR("Failed setting up UVD ENC run queue.\n");
435 return r; 435 return r;
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
index b0de1e04093b..0ca63d588670 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
@@ -418,7 +418,7 @@ static int uvd_v7_0_sw_init(void *handle)
418 ring = &adev->uvd.ring_enc[0]; 418 ring = &adev->uvd.ring_enc[0];
419 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL]; 419 rq = &ring->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL];
420 r = drm_sched_entity_init(&ring->sched, &adev->uvd.entity_enc, 420 r = drm_sched_entity_init(&ring->sched, &adev->uvd.entity_enc,
421 rq, amdgpu_sched_jobs, NULL); 421 rq, NULL);
422 if (r) { 422 if (r) {
423 DRM_ERROR("Failed setting up UVD ENC run queue.\n"); 423 DRM_ERROR("Failed setting up UVD ENC run queue.\n");
424 return r; 424 return r;
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index ab50090d066c..23e73c2a19f4 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -116,7 +116,7 @@ static int etnaviv_open(struct drm_device *dev, struct drm_file *file)
116 drm_sched_entity_init(&gpu->sched, 116 drm_sched_entity_init(&gpu->sched,
117 &ctx->sched_entity[i], 117 &ctx->sched_entity[i],
118 &gpu->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL], 118 &gpu->sched.sched_rq[DRM_SCHED_PRIORITY_NORMAL],
119 32, NULL); 119 NULL);
120 } 120 }
121 } 121 }
122 122
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c
index 1f1dd70125a7..a364fc0b38c3 100644
--- a/drivers/gpu/drm/scheduler/gpu_scheduler.c
+++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c
@@ -117,7 +117,6 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
117 * @sched The pointer to the scheduler 117 * @sched The pointer to the scheduler
118 * @entity The pointer to a valid drm_sched_entity 118 * @entity The pointer to a valid drm_sched_entity
119 * @rq The run queue this entity belongs 119 * @rq The run queue this entity belongs
120 * @jobs The max number of jobs in the job queue
121 * @guilty atomic_t set to 1 when a job on this queue 120 * @guilty atomic_t set to 1 when a job on this queue
122 * is found to be guilty causing a timeout 121 * is found to be guilty causing a timeout
123 * 122 *
@@ -126,7 +125,7 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
126int drm_sched_entity_init(struct drm_gpu_scheduler *sched, 125int drm_sched_entity_init(struct drm_gpu_scheduler *sched,
127 struct drm_sched_entity *entity, 126 struct drm_sched_entity *entity,
128 struct drm_sched_rq *rq, 127 struct drm_sched_rq *rq,
129 uint32_t jobs, atomic_t *guilty) 128 atomic_t *guilty)
130{ 129{
131 if (!(sched && entity && rq)) 130 if (!(sched && entity && rq))
132 return -EINVAL; 131 return -EINVAL;
diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index 350a62c26b29..52380067a43f 100644
--- a/include/drm/gpu_scheduler.h
+++ b/include/drm/gpu_scheduler.h
@@ -188,7 +188,7 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched);
188int drm_sched_entity_init(struct drm_gpu_scheduler *sched, 188int drm_sched_entity_init(struct drm_gpu_scheduler *sched,
189 struct drm_sched_entity *entity, 189 struct drm_sched_entity *entity,
190 struct drm_sched_rq *rq, 190 struct drm_sched_rq *rq,
191 uint32_t jobs, atomic_t *guilty); 191 atomic_t *guilty);
192void drm_sched_entity_do_release(struct drm_gpu_scheduler *sched, 192void drm_sched_entity_do_release(struct drm_gpu_scheduler *sched,
193 struct drm_sched_entity *entity); 193 struct drm_sched_entity *entity);
194void drm_sched_entity_cleanup(struct drm_gpu_scheduler *sched, 194void drm_sched_entity_cleanup(struct drm_gpu_scheduler *sched,