aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt Fleming <matt.fleming@intel.com>2014-07-08 07:28:33 -0400
committerMatt Fleming <matt.fleming@intel.com>2014-07-18 16:24:00 -0400
commit82f990a82244f8dfeb7e776186dc4811eb651ed7 (patch)
treed47030c4f6972cb17769aa5dd019335d829f7651
parentf383d00a0d1f94a7d60c753ec8e3e402889f9622 (diff)
efi: Update stale locking comment for struct efivars
The comment describing how struct efivars->lock is used hasn't been updated in sync with the code. Fix it. Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Mike Waychison <mikew@google.com> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
-rw-r--r--include/linux/efi.h8
1 files changed, 2 insertions, 6 deletions
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 59c8acfebca7..efc681fd5895 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -1040,12 +1040,8 @@ struct efivar_operations {
1040struct efivars { 1040struct efivars {
1041 /* 1041 /*
1042 * ->lock protects two things: 1042 * ->lock protects two things:
1043 * 1) ->list - adds, removals, reads, writes 1043 * 1) efivarfs_list and efivars_sysfs_list
1044 * 2) ops.[gs]et_variable() calls. 1044 * 2) ->ops calls
1045 * It must not be held when creating sysfs entries or calling kmalloc.
1046 * ops.get_next_variable() is only called from register_efivars()
1047 * or efivar_update_sysfs_entries(),
1048 * which is protected by the BKL, so that path is safe.
1049 */ 1045 */
1050 spinlock_t lock; 1046 spinlock_t lock;
1051 struct kset *kset; 1047 struct kset *kset;