aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNamrata A Shettar <namrataashettar@gmail.com>2016-09-30 09:44:54 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-10-02 11:19:51 -0400
commit8244d269098348f9bcfbcfed5c443857b4c8ffc7 (patch)
tree38ea65b2f29f0dbb13b9576b30a4ba0eef539d31
parent0ca8df12e78f3085224faac9058a2d278992dd82 (diff)
staging: wilc1000: wilc_spi: Compress return logic
Compress return logic. Done using Coccinelle : @@ local idexpression ret; expression e; @@ -ret= +return e; -return ret; Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/wilc1000/wilc_spi.c18
1 files changed, 6 insertions, 12 deletions
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index f6c47cab23b9..d865fb1dde1f 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -419,8 +419,7 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz,
419 419
420 if (wilc_spi_tx_rx(wilc, wb, rb, len2)) { 420 if (wilc_spi_tx_rx(wilc, wb, rb, len2)) {
421 dev_err(&spi->dev, "Failed cmd write, bus error...\n"); 421 dev_err(&spi->dev, "Failed cmd write, bus error...\n");
422 result = N_FAIL; 422 return N_FAIL;
423 return result;
424 } 423 }
425 424
426 /** 425 /**
@@ -441,8 +440,7 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz,
441 dev_err(&spi->dev, 440 dev_err(&spi->dev,
442 "Failed cmd response, cmd (%02x), resp (%02x)\n", 441 "Failed cmd response, cmd (%02x), resp (%02x)\n",
443 cmd, rsp); 442 cmd, rsp);
444 result = N_FAIL; 443 return N_FAIL;
445 return result;
446 } 444 }
447 445
448 /** 446 /**
@@ -452,8 +450,7 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz,
452 if (rsp != 0x00) { 450 if (rsp != 0x00) {
453 dev_err(&spi->dev, "Failed cmd state response state (%02x)\n", 451 dev_err(&spi->dev, "Failed cmd state response state (%02x)\n",
454 rsp); 452 rsp);
455 result = N_FAIL; 453 return N_FAIL;
456 return result;
457 } 454 }
458 455
459 if ((cmd == CMD_INTERNAL_READ) || (cmd == CMD_SINGLE_READ) 456 if ((cmd == CMD_INTERNAL_READ) || (cmd == CMD_SINGLE_READ)
@@ -480,8 +477,7 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz,
480 if (retry <= 0) { 477 if (retry <= 0) {
481 dev_err(&spi->dev, 478 dev_err(&spi->dev,
482 "Error, data read response (%02x)\n", rsp); 479 "Error, data read response (%02x)\n", rsp);
483 result = N_RESET; 480 return N_RESET;
484 return result;
485 } 481 }
486 482
487 if ((cmd == CMD_INTERNAL_READ) || (cmd == CMD_SINGLE_READ)) { 483 if ((cmd == CMD_INTERNAL_READ) || (cmd == CMD_SINGLE_READ)) {
@@ -496,8 +492,7 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz,
496 } else { 492 } else {
497 dev_err(&spi->dev, 493 dev_err(&spi->dev,
498 "buffer overrun when reading data.\n"); 494 "buffer overrun when reading data.\n");
499 result = N_FAIL; 495 return N_FAIL;
500 return result;
501 } 496 }
502 497
503 if (!g_spi.crc_off) { 498 if (!g_spi.crc_off) {
@@ -509,8 +504,7 @@ static int spi_cmd_complete(struct wilc *wilc, u8 cmd, u32 adr, u8 *b, u32 sz,
509 crc[1] = rb[rix++]; 504 crc[1] = rb[rix++];
510 } else { 505 } else {
511 dev_err(&spi->dev, "buffer overrun when reading crc.\n"); 506 dev_err(&spi->dev, "buffer overrun when reading crc.\n");
512 result = N_FAIL; 507 return N_FAIL;
513 return result;
514 } 508 }
515 } 509 }
516 } else if ((cmd == CMD_DMA_READ) || (cmd == CMD_DMA_EXT_READ)) { 510 } else if ((cmd == CMD_DMA_READ) || (cmd == CMD_DMA_EXT_READ)) {