aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>2018-05-04 10:24:43 -0400
committerDavid S. Miller <davem@davemloft.net>2018-06-05 16:26:46 -0400
commit820ec411e67c8dab645fb7e180875d619b6ab7e7 (patch)
treed71094d86f2f4806c1a75c815f27a4e5c224c325
parent5037be168f0e4ee910602935b1180291082d3aac (diff)
alim15x3: move irq-restore before pci_dev_put()
init_chipset_ali15x3() initializes the chipset during init with disabled interrupts. There is no need to keep the interrupts disabled during pci_dev_put(). Move the irq-restore before pci_dev_put() is invoked. Side note: The same init is performed in drivers/ata/pata_ali.c::ali_init_chipset() without disabled interrupts. It looks that the same hardware is supported in the ATA land. Would it make sense to remove this driver since it is supported in the other subsystem? Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: David S. Miller <davem@davemloft.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/ide/alim15x3.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ide/alim15x3.c b/drivers/ide/alim15x3.c
index 36f76e28a0bf..3265970aee34 100644
--- a/drivers/ide/alim15x3.c
+++ b/drivers/ide/alim15x3.c
@@ -323,9 +323,9 @@ out:
323 323
324 pci_write_config_byte(dev, 0x53, tmpbyte); 324 pci_write_config_byte(dev, 0x53, tmpbyte);
325 } 325 }
326 local_irq_restore(flags);
326 pci_dev_put(north); 327 pci_dev_put(north);
327 pci_dev_put(isa_dev); 328 pci_dev_put(isa_dev);
328 local_irq_restore(flags);
329 return 0; 329 return 0;
330} 330}
331 331