diff options
author | YueHaibing <yuehaibing@huawei.com> | 2019-05-30 04:49:32 -0400 |
---|---|---|
committer | Enric Balletbo i Serra <enric.balletbo@collabora.com> | 2019-06-05 11:28:53 -0400 |
commit | 81bc8c03e1b06a79df6a855ccf55af44965dbdba (patch) | |
tree | 3966d1d6b4d649692b9b30cc308b7c874d873bd0 | |
parent | 79e3f1d3db3d99ac7ae4f29b00da545df231a5a7 (diff) |
platform/chrome: cros_ec: Make some symbols static
Fix sparse warning:
drivers/platform/chrome/cros_ec_debugfs.c:256:30: warning: symbol 'cros_ec_console_log_fops' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_debugfs.c:265:30: warning: symbol 'cros_ec_pdinfo_fops' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_lightbar.c:550:24: warning: symbol 'cros_ec_lightbar_attr_group' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_sysfs.c:338:24: warning: symbol 'cros_ec_attr_group' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_vbc.c:104:24: warning: symbol 'cros_ec_vbc_attr_group' was not declared. Should it be static?
drivers/platform/chrome/cros_ec_lpc.c:408:25: warning: symbol 'cros_ec_lpc_pm_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
-rw-r--r-- | drivers/platform/chrome/cros_ec_debugfs.c | 4 | ||||
-rw-r--r-- | drivers/platform/chrome/cros_ec_lightbar.c | 2 | ||||
-rw-r--r-- | drivers/platform/chrome/cros_ec_lpc.c | 2 | ||||
-rw-r--r-- | drivers/platform/chrome/cros_ec_sysfs.c | 2 | ||||
-rw-r--r-- | drivers/platform/chrome/cros_ec_vbc.c | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c index 4c2a27f6a6d0..4578eb3e0731 100644 --- a/drivers/platform/chrome/cros_ec_debugfs.c +++ b/drivers/platform/chrome/cros_ec_debugfs.c | |||
@@ -241,7 +241,7 @@ static ssize_t cros_ec_pdinfo_read(struct file *file, | |||
241 | read_buf, p - read_buf); | 241 | read_buf, p - read_buf); |
242 | } | 242 | } |
243 | 243 | ||
244 | const struct file_operations cros_ec_console_log_fops = { | 244 | static const struct file_operations cros_ec_console_log_fops = { |
245 | .owner = THIS_MODULE, | 245 | .owner = THIS_MODULE, |
246 | .open = cros_ec_console_log_open, | 246 | .open = cros_ec_console_log_open, |
247 | .read = cros_ec_console_log_read, | 247 | .read = cros_ec_console_log_read, |
@@ -250,7 +250,7 @@ const struct file_operations cros_ec_console_log_fops = { | |||
250 | .release = cros_ec_console_log_release, | 250 | .release = cros_ec_console_log_release, |
251 | }; | 251 | }; |
252 | 252 | ||
253 | const struct file_operations cros_ec_pdinfo_fops = { | 253 | static const struct file_operations cros_ec_pdinfo_fops = { |
254 | .owner = THIS_MODULE, | 254 | .owner = THIS_MODULE, |
255 | .open = simple_open, | 255 | .open = simple_open, |
256 | .read = cros_ec_pdinfo_read, | 256 | .read = cros_ec_pdinfo_read, |
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c index d30a6650b0b5..23a82ee4c785 100644 --- a/drivers/platform/chrome/cros_ec_lightbar.c +++ b/drivers/platform/chrome/cros_ec_lightbar.c | |||
@@ -547,7 +547,7 @@ static struct attribute *__lb_cmds_attrs[] = { | |||
547 | NULL, | 547 | NULL, |
548 | }; | 548 | }; |
549 | 549 | ||
550 | struct attribute_group cros_ec_lightbar_attr_group = { | 550 | static struct attribute_group cros_ec_lightbar_attr_group = { |
551 | .name = "lightbar", | 551 | .name = "lightbar", |
552 | .attrs = __lb_cmds_attrs, | 552 | .attrs = __lb_cmds_attrs, |
553 | }; | 553 | }; |
diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c index c9c240fbe7c6..aaa21803633a 100644 --- a/drivers/platform/chrome/cros_ec_lpc.c +++ b/drivers/platform/chrome/cros_ec_lpc.c | |||
@@ -405,7 +405,7 @@ static int cros_ec_lpc_resume(struct device *dev) | |||
405 | } | 405 | } |
406 | #endif | 406 | #endif |
407 | 407 | ||
408 | const struct dev_pm_ops cros_ec_lpc_pm_ops = { | 408 | static const struct dev_pm_ops cros_ec_lpc_pm_ops = { |
409 | SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume) | 409 | SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume) |
410 | }; | 410 | }; |
411 | 411 | ||
diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c index fe0b7614ae1b..3edb237bf8ed 100644 --- a/drivers/platform/chrome/cros_ec_sysfs.c +++ b/drivers/platform/chrome/cros_ec_sysfs.c | |||
@@ -335,7 +335,7 @@ static umode_t cros_ec_ctrl_visible(struct kobject *kobj, | |||
335 | return a->mode; | 335 | return a->mode; |
336 | } | 336 | } |
337 | 337 | ||
338 | struct attribute_group cros_ec_attr_group = { | 338 | static struct attribute_group cros_ec_attr_group = { |
339 | .attrs = __ec_attrs, | 339 | .attrs = __ec_attrs, |
340 | .is_visible = cros_ec_ctrl_visible, | 340 | .is_visible = cros_ec_ctrl_visible, |
341 | }; | 341 | }; |
diff --git a/drivers/platform/chrome/cros_ec_vbc.c b/drivers/platform/chrome/cros_ec_vbc.c index 8392a1ec33a7..2aaefed87eb4 100644 --- a/drivers/platform/chrome/cros_ec_vbc.c +++ b/drivers/platform/chrome/cros_ec_vbc.c | |||
@@ -101,7 +101,7 @@ static struct bin_attribute *cros_ec_vbc_bin_attrs[] = { | |||
101 | NULL | 101 | NULL |
102 | }; | 102 | }; |
103 | 103 | ||
104 | struct attribute_group cros_ec_vbc_attr_group = { | 104 | static struct attribute_group cros_ec_vbc_attr_group = { |
105 | .name = "vbc", | 105 | .name = "vbc", |
106 | .bin_attrs = cros_ec_vbc_bin_attrs, | 106 | .bin_attrs = cros_ec_vbc_bin_attrs, |
107 | }; | 107 | }; |