aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLudovic Barre <ludovic.barre@st.com>2019-04-26 03:46:34 -0400
committerUlf Hansson <ulf.hansson@linaro.org>2019-05-06 06:33:03 -0400
commit812513c7b18c7de825da3d4a7501329925b4ec1b (patch)
tree7e7441f55445405c1e0e8a06925e49bca379f7f7
parent7a019f9b432b371156989be49db43f86aefdf5d3 (diff)
mmc: mmci: Cleanup mmci_cmd_irq() for busy detect
Let's cleanup the mmci_cmd_irq() a bit, to make the busy detect code more clear. Signed-off-by: Ludovic Barre <ludovic.barre@st.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-rw-r--r--drivers/mmc/host/mmci.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 9e9596a68f4c..049f8e3676ac 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -1205,12 +1205,13 @@ mmci_cmd_irq(struct mmci_host *host, struct mmc_command *cmd,
1205 unsigned int status) 1205 unsigned int status)
1206{ 1206{
1207 void __iomem *base = host->base; 1207 void __iomem *base = host->base;
1208 bool sbc; 1208 bool sbc, busy_resp;
1209 1209
1210 if (!cmd) 1210 if (!cmd)
1211 return; 1211 return;
1212 1212
1213 sbc = (cmd == host->mrq->sbc); 1213 sbc = (cmd == host->mrq->sbc);
1214 busy_resp = !!(cmd->flags & MMC_RSP_BUSY);
1214 1215
1215 /* 1216 /*
1216 * We need to be one of these interrupts to be considered worth 1217 * We need to be one of these interrupts to be considered worth
@@ -1224,8 +1225,7 @@ mmci_cmd_irq(struct mmci_host *host, struct mmc_command *cmd,
1224 /* 1225 /*
1225 * ST Micro variant: handle busy detection. 1226 * ST Micro variant: handle busy detection.
1226 */ 1227 */
1227 if (host->variant->busy_detect) { 1228 if (busy_resp && host->variant->busy_detect) {
1228 bool busy_resp = !!(cmd->flags & MMC_RSP_BUSY);
1229 1229
1230 /* We are busy with a command, return */ 1230 /* We are busy with a command, return */
1231 if (host->busy_status && 1231 if (host->busy_status &&
@@ -1238,7 +1238,7 @@ mmci_cmd_irq(struct mmci_host *host, struct mmc_command *cmd,
1238 * that the special busy status bit is still set before 1238 * that the special busy status bit is still set before
1239 * proceeding. 1239 * proceeding.
1240 */ 1240 */
1241 if (!host->busy_status && busy_resp && 1241 if (!host->busy_status &&
1242 !(status & (MCI_CMDCRCFAIL|MCI_CMDTIMEOUT)) && 1242 !(status & (MCI_CMDCRCFAIL|MCI_CMDTIMEOUT)) &&
1243 (readl(base + MMCISTATUS) & host->variant->busy_detect_flag)) { 1243 (readl(base + MMCISTATUS) & host->variant->busy_detect_flag)) {
1244 1244