aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRex Zhu <Rex.Zhu@amd.com>2018-03-05 03:07:22 -0500
committerAlex Deucher <alexander.deucher@amd.com>2018-03-07 16:10:09 -0500
commit807f93ac6a1d37498fcd8f6af28f1e5f569ad8e4 (patch)
tree8c4c9885b6a150b9b1c183408a78922357b93fdb
parentcdd02dda4ff94b8f86c2c478cce7218e4613dc56 (diff)
drm/amd/pp: Remove cgs wrapper function for temperature update
Reviewed-by: Alex Deucher <alexdeucher@amd.com> Acked-by: Christian König <christian.koenig@amd.com> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c13
-rw-r--r--drivers/gpu/drm/amd/include/cgs_common.h6
-rw-r--r--drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c4
3 files changed, 3 insertions, 20 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
index f37482c76e20..76f4758ead3e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
@@ -905,18 +905,6 @@ static int amdgpu_cgs_notify_dpm_enabled(struct cgs_device *cgs_device, bool ena
905 return 0; 905 return 0;
906} 906}
907 907
908static int amdgpu_cgs_set_temperature_range(struct cgs_device *cgs_device,
909 int min_temperature,
910 int max_temperature)
911{
912 CGS_FUNC_ADEV;
913
914 adev->pm.dpm.thermal.min_temp = min_temperature;
915 adev->pm.dpm.thermal.max_temp = max_temperature;
916
917 return 0;
918}
919
920static const struct cgs_ops amdgpu_cgs_ops = { 908static const struct cgs_ops amdgpu_cgs_ops = {
921 .alloc_gpu_mem = amdgpu_cgs_alloc_gpu_mem, 909 .alloc_gpu_mem = amdgpu_cgs_alloc_gpu_mem,
922 .free_gpu_mem = amdgpu_cgs_free_gpu_mem, 910 .free_gpu_mem = amdgpu_cgs_free_gpu_mem,
@@ -941,7 +929,6 @@ static const struct cgs_ops amdgpu_cgs_ops = {
941 .is_virtualization_enabled = amdgpu_cgs_is_virtualization_enabled, 929 .is_virtualization_enabled = amdgpu_cgs_is_virtualization_enabled,
942 .enter_safe_mode = amdgpu_cgs_enter_safe_mode, 930 .enter_safe_mode = amdgpu_cgs_enter_safe_mode,
943 .lock_grbm_idx = amdgpu_cgs_lock_grbm_idx, 931 .lock_grbm_idx = amdgpu_cgs_lock_grbm_idx,
944 .set_temperature_range = amdgpu_cgs_set_temperature_range,
945}; 932};
946 933
947static const struct cgs_os_ops amdgpu_cgs_os_ops = { 934static const struct cgs_os_ops amdgpu_cgs_os_ops = {
diff --git a/drivers/gpu/drm/amd/include/cgs_common.h b/drivers/gpu/drm/amd/include/cgs_common.h
index 113ba6f07171..7f26f2054bce 100644
--- a/drivers/gpu/drm/amd/include/cgs_common.h
+++ b/drivers/gpu/drm/amd/include/cgs_common.h
@@ -354,9 +354,6 @@ typedef int (*cgs_enter_safe_mode)(struct cgs_device *cgs_device, bool en);
354 354
355typedef void (*cgs_lock_grbm_idx)(struct cgs_device *cgs_device, bool lock); 355typedef void (*cgs_lock_grbm_idx)(struct cgs_device *cgs_device, bool lock);
356 356
357typedef int (*cgs_set_temperature_range)(struct cgs_device *cgs_device,
358 int min_temperature,
359 int max_temperature);
360struct cgs_ops { 357struct cgs_ops {
361 /* memory management calls (similar to KFD interface) */ 358 /* memory management calls (similar to KFD interface) */
362 cgs_alloc_gpu_mem_t alloc_gpu_mem; 359 cgs_alloc_gpu_mem_t alloc_gpu_mem;
@@ -389,7 +386,6 @@ struct cgs_ops {
389 cgs_is_virtualization_enabled_t is_virtualization_enabled; 386 cgs_is_virtualization_enabled_t is_virtualization_enabled;
390 cgs_enter_safe_mode enter_safe_mode; 387 cgs_enter_safe_mode enter_safe_mode;
391 cgs_lock_grbm_idx lock_grbm_idx; 388 cgs_lock_grbm_idx lock_grbm_idx;
392 cgs_set_temperature_range set_temperature_range;
393}; 389};
394 390
395struct cgs_os_ops; /* To be define in OS-specific CGS header */ 391struct cgs_os_ops; /* To be define in OS-specific CGS header */
@@ -465,7 +461,5 @@ struct cgs_device
465#define cgs_lock_grbm_idx(cgs_device, lock) \ 461#define cgs_lock_grbm_idx(cgs_device, lock) \
466 CGS_CALL(lock_grbm_idx, cgs_device, lock) 462 CGS_CALL(lock_grbm_idx, cgs_device, lock)
467 463
468#define cgs_set_temperature_range(dev, min_temp, max_temp) \
469 CGS_CALL(set_temperature_range, dev, min_temp, max_temp)
470 464
471#endif /* _CGS_COMMON_H */ 465#endif /* _CGS_COMMON_H */
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
index f06f8f42e776..b784131d0f87 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
@@ -222,6 +222,7 @@ int phm_start_thermal_controller(struct pp_hwmgr *hwmgr)
222{ 222{
223 int ret = 0; 223 int ret = 0;
224 struct PP_TemperatureRange range = {TEMP_RANGE_MIN, TEMP_RANGE_MAX}; 224 struct PP_TemperatureRange range = {TEMP_RANGE_MIN, TEMP_RANGE_MAX};
225 struct amdgpu_device *adev = hwmgr->adev;
225 226
226 if (hwmgr->hwmgr_func->get_thermal_temperature_range) 227 if (hwmgr->hwmgr_func->get_thermal_temperature_range)
227 hwmgr->hwmgr_func->get_thermal_temperature_range( 228 hwmgr->hwmgr_func->get_thermal_temperature_range(
@@ -232,7 +233,8 @@ int phm_start_thermal_controller(struct pp_hwmgr *hwmgr)
232 && hwmgr->hwmgr_func->start_thermal_controller != NULL) 233 && hwmgr->hwmgr_func->start_thermal_controller != NULL)
233 ret = hwmgr->hwmgr_func->start_thermal_controller(hwmgr, &range); 234 ret = hwmgr->hwmgr_func->start_thermal_controller(hwmgr, &range);
234 235
235 cgs_set_temperature_range(hwmgr->device, range.min, range.max); 236 adev->pm.dpm.thermal.min_temp = range.min;
237 adev->pm.dpm.thermal.max_temp = range.max;
236 238
237 return ret; 239 return ret;
238} 240}