diff options
author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2018-02-23 14:25:06 -0500 |
---|---|---|
committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2018-03-16 09:44:01 -0400 |
commit | 80343b3e477f3b3b5a01be664a526878a18eb57d (patch) | |
tree | c8a13b92c4c0ea4a05000454be45406bd7790f47 | |
parent | d5517a39dce40f57665c714823843eea4f8dd7b6 (diff) |
drm/i915: Use drm_color_lut_size()
Avoid all the sizeof(drm_color_lut) business by using
drm_color_lut_size() to convert the blob length into
number of LUT entries.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180223192506.29992-6-ville.syrjala@linux.intel.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/i915/intel_color.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index 58d779e94af7..768f1c26080e 100644 --- a/drivers/gpu/drm/i915/intel_color.c +++ b/drivers/gpu/drm/i915/intel_color.c | |||
@@ -39,7 +39,7 @@ | |||
39 | #define CTM_COEFF_NEGATIVE(coeff) (((coeff) & CTM_COEFF_SIGN) != 0) | 39 | #define CTM_COEFF_NEGATIVE(coeff) (((coeff) & CTM_COEFF_SIGN) != 0) |
40 | #define CTM_COEFF_ABS(coeff) ((coeff) & (CTM_COEFF_SIGN - 1)) | 40 | #define CTM_COEFF_ABS(coeff) ((coeff) & (CTM_COEFF_SIGN - 1)) |
41 | 41 | ||
42 | #define LEGACY_LUT_LENGTH (sizeof(struct drm_color_lut) * 256) | 42 | #define LEGACY_LUT_LENGTH 256 |
43 | 43 | ||
44 | /* Post offset values for RGB->YCBCR conversion */ | 44 | /* Post offset values for RGB->YCBCR conversion */ |
45 | #define POSTOFF_RGB_TO_YUV_HI 0x800 | 45 | #define POSTOFF_RGB_TO_YUV_HI 0x800 |
@@ -79,7 +79,7 @@ static bool crtc_state_is_legacy_gamma(struct drm_crtc_state *state) | |||
79 | return !state->degamma_lut && | 79 | return !state->degamma_lut && |
80 | !state->ctm && | 80 | !state->ctm && |
81 | state->gamma_lut && | 81 | state->gamma_lut && |
82 | state->gamma_lut->length == LEGACY_LUT_LENGTH; | 82 | drm_color_lut_size(state->gamma_lut) == LEGACY_LUT_LENGTH; |
83 | } | 83 | } |
84 | 84 | ||
85 | /* | 85 | /* |
@@ -612,19 +612,17 @@ int intel_color_check(struct drm_crtc *crtc, | |||
612 | struct drm_i915_private *dev_priv = to_i915(crtc->dev); | 612 | struct drm_i915_private *dev_priv = to_i915(crtc->dev); |
613 | size_t gamma_length, degamma_length; | 613 | size_t gamma_length, degamma_length; |
614 | 614 | ||
615 | degamma_length = INTEL_INFO(dev_priv)->color.degamma_lut_size * | 615 | degamma_length = INTEL_INFO(dev_priv)->color.degamma_lut_size; |
616 | sizeof(struct drm_color_lut); | 616 | gamma_length = INTEL_INFO(dev_priv)->color.gamma_lut_size; |
617 | gamma_length = INTEL_INFO(dev_priv)->color.gamma_lut_size * | ||
618 | sizeof(struct drm_color_lut); | ||
619 | 617 | ||
620 | /* | 618 | /* |
621 | * We allow both degamma & gamma luts at the right size or | 619 | * We allow both degamma & gamma luts at the right size or |
622 | * NULL. | 620 | * NULL. |
623 | */ | 621 | */ |
624 | if ((!crtc_state->degamma_lut || | 622 | if ((!crtc_state->degamma_lut || |
625 | crtc_state->degamma_lut->length == degamma_length) && | 623 | drm_color_lut_size(crtc_state->degamma_lut) == degamma_length) && |
626 | (!crtc_state->gamma_lut || | 624 | (!crtc_state->gamma_lut || |
627 | crtc_state->gamma_lut->length == gamma_length)) | 625 | drm_color_lut_size(crtc_state->gamma_lut) == gamma_length)) |
628 | return 0; | 626 | return 0; |
629 | 627 | ||
630 | /* | 628 | /* |